)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8a3387b508bfb0d908afaae4f728ea433ec65027","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bob Fournier \u003cbfournie@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 17:21:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"   Remove unused enable_tunneling in openvswitch_agent.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    As described in https://bugs.launchpad.net/neutron/+bug/1531890, the ovs"},{"line_number":10,"context_line":"    agent does not use the \u0027agent_tunneling\u0027 setting in openvswitch_agent.ini,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_d59f8d5d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-07-15 22:07:48.000000000","message":"extra space is not needed","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8a3387b508bfb0d908afaae4f728ea433ec65027","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"   Remove unused enable_tunneling in openvswitch_agent.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    As described in https://bugs.launchpad.net/neutron/+bug/1531890, the ovs"},{"line_number":10,"context_line":"    agent does not use the \u0027agent_tunneling\u0027 setting in openvswitch_agent.ini,"},{"line_number":11,"context_line":"    instead it uses \u0027tunnel_types\u0027.  This fix removes it from being set in"},{"line_number":12,"context_line":"    the .ini file and also sets local_ip, tunnel_bridge, etc. based on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_75a06191","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2016-07-15 22:07:48.000000000","message":"same","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8a3387b508bfb0d908afaae4f728ea433ec65027","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u0027tunnel_types\u0027 hieradata parameter.  The hieradata \u0027enable_tunneling\u0027"},{"line_number":14,"context_line":"    is being removed in https://review.openstack.org/#/c/335235/."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    Partial-Bug: 1532830"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I73630653330c67444827f32740c44e9d25b5db31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_f593b14d","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":4},"updated":"2016-07-15 22:07:48.000000000","message":"same here","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"}],"manifests/agents/ml2/ovs.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3a169be38faceac3d19bfbc8f097228ed2545a85","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  $purge_config               \u003d false,"},{"line_number":169,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":170,"context_line":"  $prevent_arp_spoofing       \u003d $::os_service_default,"},{"line_number":171,"context_line":"  $enable_tunneling           \u003d false,"},{"line_number":172,"context_line":") {"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_54b6ff8a","line":171,"range":{"start_line":171,"start_character":3,"end_line":171,"end_character":19},"updated":"2016-07-18 12:39:02.000000000","message":"Please add warning that this variable is deprecated","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"99f886caf5f7d97501c86e2bccad8d4a8eddde83","unresolved":false,"context_lines":[{"line_number":168,"context_line":"  $purge_config               \u003d false,"},{"line_number":169,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":170,"context_line":"  $prevent_arp_spoofing       \u003d $::os_service_default,"},{"line_number":171,"context_line":"  $enable_tunneling           \u003d false,"},{"line_number":172,"context_line":") {"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_19dcb711","line":171,"range":{"start_line":171,"start_character":3,"end_line":171,"end_character":19},"in_reply_to":"dada55a8_54b6ff8a","updated":"2016-07-18 14:57:21.000000000","message":"Will fix to add warning.","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3a169be38faceac3d19bfbc8f097228ed2545a85","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    require ::vswitch::ovs"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if size($tunnel_types) \u003e 0 {"},{"line_number":181,"context_line":"    $tunneling_enabled \u003d true"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    $tunneling_enabled \u003d false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_b4901bee","line":180,"range":{"start_line":180,"start_character":5,"end_line":180,"end_character":24},"updated":"2016-07-18 12:39:02.000000000","message":"I think we need variable type validation here","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"99f886caf5f7d97501c86e2bccad8d4a8eddde83","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    require ::vswitch::ovs"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if size($tunnel_types) \u003e 0 {"},{"line_number":181,"context_line":"    $tunneling_enabled \u003d true"},{"line_number":182,"context_line":"  } else {"},{"line_number":183,"context_line":"    $tunneling_enabled \u003d false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_398d3b32","line":180,"range":{"start_line":180,"start_character":5,"end_line":180,"end_character":24},"in_reply_to":"dada55a8_b4901bee","updated":"2016-07-18 14:57:21.000000000","message":"Will fix to add validate_array().","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3a169be38faceac3d19bfbc8f097228ed2545a85","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    $tunneling_enabled \u003d false"},{"line_number":184,"context_line":"  }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"  if $tunneling_enabled and ! $local_ip {"},{"line_number":187,"context_line":"    fail(\u0027Local ip for ovs agent must be set when tunneling is enabled\u0027)"},{"line_number":188,"context_line":"  }"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_d4582f59","line":186,"range":{"start_line":186,"start_character":6,"end_line":186,"end_character":23},"updated":"2016-07-18 12:39:02.000000000","message":"Such variable name looks confusing. Probably we can also check old variable value and use smth like \"enable_tunneling_real\" ?","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"99f886caf5f7d97501c86e2bccad8d4a8eddde83","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    $tunneling_enabled \u003d false"},{"line_number":184,"context_line":"  }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"  if $tunneling_enabled and ! $local_ip {"},{"line_number":187,"context_line":"    fail(\u0027Local ip for ovs agent must be set when tunneling is enabled\u0027)"},{"line_number":188,"context_line":"  }"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_19c5d73b","line":186,"range":{"start_line":186,"start_character":6,"end_line":186,"end_character":23},"in_reply_to":"dada55a8_d4582f59","updated":"2016-07-18 14:57:21.000000000","message":"OK, will change to use \u0027enable_tunneling_real\u0027 and also check old variable value.","commit_id":"17430e9d7e540a6b3e6faed10272001f1870e2b7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e617cd50fae6b49aa1f1f5cee30e688eba611907","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    require ::vswitch::ovs"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_9a8ade19","line":180,"updated":"2016-07-20 14:45:19.000000000","message":"This is wrong, it should be:\n  if ! $enable_tunneling { }","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"229375a6844ab7dc54b796ad88c60d46e7e806dd","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    require ::vswitch::ovs"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_099cd70d","line":180,"updated":"2016-07-20 21:14:22.000000000","message":"You can use if $enable_tunneling. is_service_default(...) is used when the value \u003d $::os_service_default","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"3ff9807da60239ffedfd61b7524d6642b695b172","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    require ::vswitch::ovs"},{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_4f71bd75","line":180,"in_reply_to":"dada55a8_9a8ade19","updated":"2016-07-20 16:40:47.000000000","message":"For this I was attempting to log a warning if $enable_tunneling was being set to a value different than the default.  Should I output the warning just if enable_tunneling is false?","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e617cd50fae6b49aa1f1f5cee30e688eba611907","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  validate_array($tunnel_types)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_7a8f2a2a","line":181,"updated":"2016-07-20 14:45:19.000000000","message":"Also, please add a release note about this deprecation.","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"229375a6844ab7dc54b796ad88c60d46e7e806dd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  validate_array($tunnel_types)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_699d9309","line":181,"updated":"2016-07-20 21:14:22.000000000","message":"You use reno to create the release note, http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"3ff9807da60239ffedfd61b7524d6642b695b172","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if ! is_service_default ($enable_tunneling) {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  validate_array($tunnel_types)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_8fa8d578","line":181,"in_reply_to":"dada55a8_7a8f2a2a","updated":"2016-07-20 16:40:47.000000000","message":"OK, for a release note, I will add a new file to puppet-neutron/releasenotes/notes \ncalled remove_enable_tunneling-xxxx.yaml that describes that the parameter has been deprecated.  Its not clear what I should be using for the id in this file, can you help? Thanks.","commit_id":"a14d788294f6b41ddbf53fa473db3d6e3b4dce4d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"14f44273c8b382340586270b2e23b76999fedeca","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"  if $enable_tunneling {"},{"line_number":181,"context_line":"    warning(\u0027The enable_tunneling parameter is deprecated\u0027)"},{"line_number":182,"context_line":"  }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  validate_array($tunnel_types)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_c328bc9c","line":181,"updated":"2016-07-21 12:45:41.000000000","message":"enable_tunneling is deprecated and will be removed in a next release. Please use tunnel_types instead.","commit_id":"886f07dfefbaed292e0be492e09b704b96c4fe09"}],"releasenotes/notes/newton_deprecate_enable_tunneling-d7f6e2de1091b458.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"14f44273c8b382340586270b2e23b76999fedeca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The option enable_tunneling has been deprecated"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_0306541f","line":3,"updated":"2016-07-21 12:45:41.000000000","message":"Can you elaborate a bit? Look at my suggestion for the warning. Please think about our users, they\u0027ll read it and need to understand what\u0027s going on with the option. Make something a bit longer that explain what is deprecated, why and how to proceed. Thanks.","commit_id":"886f07dfefbaed292e0be492e09b704b96c4fe09"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8c1dbdd7e4e791dc0aab29c92104e7bb080a69eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The option enable_tunneling has been deprecated as it is no longer used.  In order to enable tunneling, tunnel_types should be set to the desired type. If tunnel_types is not set, tunneling will be disabled."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dada55a8_bb0e8ce2","line":3,"updated":"2016-07-21 13:45:29.000000000","message":"I have a last comment and we\u0027re good. This is a YAML file and for the sake of readability (like many other types of files), we try to respect a maximum amount of characters. Please avoid big lines like this and make it multi-line. Thanks. I\u0027ll +2 right after your next patchset.","commit_id":"ccadec7d54473517443e67fea3753e514c7555f6"}]}