)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"c12dbbed94db07230e20425597165d4e6922664b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure the numvfs for SRIOV interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch shall create VF\u0027s via the PCI SYS interface."},{"line_number":10,"context_line":"Default value : $::os_service_default"},{"line_number":11,"context_line":"Sample Format : [\u0027eth0:4\u0027,\u0027eth2:128\u0027]"},{"line_number":12,"context_line":"For values as in sample format, the sriov_numvfs config files"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1ac06dbe_9ea7ff4e","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":28},"updated":"2016-08-19 14:49:26.000000000","message":"nit: VFs","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"}],"lib/puppet/provider/neutron_agent_sriov_maxvfs/sriov_maxvfs.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d70caeab7a1676554505e53c2ac149cdd90cd936","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_agent_sriov_maxvfs).provide(:sriov_maxvfs) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  def value\u003d(value)"},{"line_number":4,"context_line":"    cur_value \u003d self.value().to_i"},{"line_number":5,"context_line":"    if sriov_numvfs_value !\u003d cur_value"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bacf61ea_c4817691","line":2,"updated":"2016-08-03 13:33:36.000000000","message":"could you please take a look on other providers (e.g. for neutron). They contains important methods like prefetch, create, destroy, exists?. I think this provider should be rewritten in that way as well.","commit_id":"8e596c35d9e1fa361f94c666da6cc1581edfc02c"}],"lib/puppet/provider/neutron_agent_sriov_numvfs/sriov_numvfs.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c7ffadb9a2b47a875ed4edfb0b7c500fa20d0655","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_agent_sriov_numvfs).provide(:sriov_numvfs) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  def create"},{"line_number":4,"context_line":"    if File.file?(sriov_numvfs_path)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"7ac969e8_7a5501c5","line":1,"updated":"2016-08-12 23:11:43.000000000","message":"I realize that a lot of providers have no documentation whatsoever, but it feels like we could here. Especially for things like destruction physically reconfigures the system. Maybe the puppet-X cores could chime in here whether it is worthwhile?","commit_id":"b233421c6495345742a30650b1e6cbcbe5077a65"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"539e3b0f206da68a3ee633e0f6b1513a37060777","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_agent_sriov_numvfs).provide(:sriov_numvfs) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  def create"},{"line_number":4,"context_line":"    if File.file?(sriov_numvfs_path)"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3ac371cc_e2bf3ff9","line":1,"in_reply_to":"7ac969e8_7a5501c5","updated":"2016-08-16 06:57:08.000000000","message":"Done","commit_id":"b233421c6495345742a30650b1e6cbcbe5077a65"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# file will enable the specified number of VFs. The provider shall read the"},{"line_number":4,"context_line":"# file and ensure that the value is zero, before writing the number of VFs that"},{"line_number":5,"context_line":"# should be enabled. If the VFs needs to be disabled then we shall write a zero"},{"line_number":6,"context_line":"# to this file."},{"line_number":7,"context_line":"Puppet::Type.type(:neutron_agent_sriov_numvfs).provide(:sriov_numvfs) do"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  def create"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_d80bb622","line":6,"updated":"2016-08-17 16:35:00.000000000","message":"Actually a meant \"desc\" text like in neutron_network. As none of the cores have brought it up, I wouldn\u0027t worry about it ;)","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# file will enable the specified number of VFs. The provider shall read the"},{"line_number":4,"context_line":"# file and ensure that the value is zero, before writing the number of VFs that"},{"line_number":5,"context_line":"# should be enabled. If the VFs needs to be disabled then we shall write a zero"},{"line_number":6,"context_line":"# to this file."},{"line_number":7,"context_line":"Puppet::Type.type(:neutron_agent_sriov_numvfs).provide(:sriov_numvfs) do"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  def create"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_f5911448","line":6,"in_reply_to":"3ac371cc_be469b4c","updated":"2016-08-18 14:05:38.000000000","message":"Done","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"18838dcd1fe02d115cbc0974b85c42b8187c78f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# file will enable the specified number of VFs. The provider shall read the"},{"line_number":4,"context_line":"# file and ensure that the value is zero, before writing the number of VFs that"},{"line_number":5,"context_line":"# should be enabled. If the VFs needs to be disabled then we shall write a zero"},{"line_number":6,"context_line":"# to this file."},{"line_number":7,"context_line":"Puppet::Type.type(:neutron_agent_sriov_numvfs).provide(:sriov_numvfs) do"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  def create"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_be469b4c","line":6,"in_reply_to":"3ac371cc_d80bb622","updated":"2016-08-17 17:28:25.000000000","message":"yep, it would be better to add it to \u0027desc\u0027 https://github.com/openstack/puppet-neutron/blob/master/lib/puppet/provider/neutron_network/neutron.rb#L8-L12","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  def _set_numvfs"},{"line_number":34,"context_line":"    # During an update, the content of file sriov_numvfs_path has to be set"},{"line_number":35,"context_line":"    # to 0 (ZERO), before writing the actual value"},{"line_number":36,"context_line":"    cur_value \u003d File.read(sriov_numvfs_path)"},{"line_number":37,"context_line":"    if cur_value !\u003d 0"},{"line_number":38,"context_line":"      File.write(sriov_numvfs_path,\"0\")"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_f385f3ce","line":35,"updated":"2016-08-17 16:35:00.000000000","message":"Since this can be run when a configuration changes to a different time, I feel like there should be validation of some kind somewhere that sriov_numvfs_value is going to give you a valid value. IIUC, you won\u0027t know that the value passed to this type ends in a valid integer until after you try to write it. \n\nIn short, I\u0027d like to see some validation of the mapping before you modify the system.","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  def _set_numvfs"},{"line_number":34,"context_line":"    # During an update, the content of file sriov_numvfs_path has to be set"},{"line_number":35,"context_line":"    # to 0 (ZERO), before writing the actual value"},{"line_number":36,"context_line":"    cur_value \u003d File.read(sriov_numvfs_path)"},{"line_number":37,"context_line":"    if cur_value !\u003d 0"},{"line_number":38,"context_line":"      File.write(sriov_numvfs_path,\"0\")"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_55f6288f","line":35,"in_reply_to":"3ac371cc_f385f3ce","updated":"2016-08-18 14:05:38.000000000","message":"The check is added at https://review.openstack.org/#/c/344918/16/lib/puppet/type/neutron_agent_sriov_numvfs.rb@7","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"18838dcd1fe02d115cbc0974b85c42b8187c78f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  def _set_numvfs"},{"line_number":34,"context_line":"    # During an update, the content of file sriov_numvfs_path has to be set"},{"line_number":35,"context_line":"    # to 0 (ZERO), before writing the actual value"},{"line_number":36,"context_line":"    cur_value \u003d File.read(sriov_numvfs_path)"},{"line_number":37,"context_line":"    if cur_value !\u003d 0"},{"line_number":38,"context_line":"      File.write(sriov_numvfs_path,\"0\")"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_5e7a0778","line":35,"in_reply_to":"3ac371cc_f385f3ce","updated":"2016-08-17 17:28:25.000000000","message":"The validation makes sense","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"}],"lib/puppet/type/neutron_agent_sriov_maxvfs.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d70caeab7a1676554505e53c2ac149cdd90cd936","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_agent_sriov_maxvfs) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  newparam(:name) do"},{"line_number":4,"context_line":"    desc \"The name of the sriov_maxvfs conf\""},{"line_number":5,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bacf61ea_a4a8c278","line":2,"updated":"2016-08-03 13:33:36.000000000","message":"should be ensurable","commit_id":"8e596c35d9e1fa361f94c666da6cc1581edfc02c"}],"lib/puppet/type/neutron_agent_sriov_numvfs.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"The name of the sriov_numvfs conf\""},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_5304c748","line":6,"updated":"2016-08-17 16:35:00.000000000","message":"maybe describe the expected format of the resource name here?","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"The name of the sriov_numvfs conf\""},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_f52d94fe","line":6,"in_reply_to":"3ac371cc_5304c748","updated":"2016-08-18 14:05:38.000000000","message":"Done","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"c12dbbed94db07230e20425597165d4e6922664b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"sriov_numvfs conf as \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e format\""},{"line_number":7,"context_line":"    newvalues(/^[a-z0-9]+:[0-9]+$/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1ac06dbe_bbaacd17","line":6,"range":{"start_line":6,"start_character":41,"end_line":6,"end_character":47},"updated":"2016-08-19 14:49:26.000000000","message":"nit typo (network).\nshouldn\u0027t it be \u003cphysical_interface:number_of_vfs\u003e?","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7c7a444b32d7666e45e3a8513e0d29435ce2cccc","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"sriov_numvfs conf as \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e format\""},{"line_number":7,"context_line":"    newvalues(/^[a-z0-9]+:[0-9]+$/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"3ac371cc_dbeec920","line":7,"updated":"2016-08-19 09:25:27.000000000","message":"cool","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"c12dbbed94db07230e20425597165d4e6922664b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"sriov_numvfs conf as \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e format\""},{"line_number":7,"context_line":"    newvalues(/^[a-z0-9]+:[0-9]+$/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1ac06dbe_5ed8e7ef","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":24},"updated":"2016-08-19 14:49:26.000000000","message":"why not adding \u0027-\u0027 and \u0027_\u0027 (e.g. sriov-pf1:32)?\nAFAIK it is valid and common to udev rename physical interfaces in order to anticipate what will be the name on different systems. I\u0027m not sure that users / devs will expect such a limitation (avoiding some valid characters).","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"c3ef079ed600a0757a51230ea86dac095e3d0643","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"sriov_numvfs conf as \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e format\""},{"line_number":7,"context_line":"    newvalues(/^[a-z0-9]+:[0-9]+$/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1ac06dbe_a41aae15","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":24},"in_reply_to":"1ac06dbe_5ed8e7ef","updated":"2016-08-19 14:54:20.000000000","message":"+1, let add this","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"be6e89dc2fa0adafafb7bd4f90b6ee58cc0267a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name) do"},{"line_number":6,"context_line":"    desc \"sriov_numvfs conf as \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e format\""},{"line_number":7,"context_line":"    newvalues(/^[a-z0-9]+:[0-9]+$/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1ac06dbe_be4636bd","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":24},"in_reply_to":"1ac06dbe_5ed8e7ef","updated":"2016-08-19 15:37:20.000000000","message":"Thanks for the review.","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"}],"manifests/agents/ml2/sriov.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a56179c9a2fe4da21b2194a1631dc0648da1753","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to undef."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":70,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_7e4ed0c1","line":68,"updated":"2016-07-21 10:37:39.000000000","message":"empty line","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"fcc621ecd5e46854a5acf1960e64e870ffecc0f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to undef."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":70,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_0f031bb9","line":68,"in_reply_to":"dada55a8_7e4ed0c1","updated":"2016-07-21 14:29:43.000000000","message":"Done","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a56179c9a2fe4da21b2194a1631dc0648da1753","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  if !is_service_default($max_reserved_vfs) and !empty($max_reserved_vfs) {"},{"line_number":96,"context_line":"    validate_array($max_reserved_vfs)"},{"line_number":97,"context_line":"    neutron::agents::ml2::sriov::max_vfs {$max_reserved_vfs:"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":"  package { \u0027neutron-sriov-nic-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_fe9e4005","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":40},"updated":"2016-07-21 10:37:39.000000000","message":"should be Neutron::Agents::Ml2::Sriov::Max_vfs","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4b0e49212f3b3736818ce35fc0253e6677f2af40","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  if !is_service_default($max_reserved_vfs) and !empty($max_reserved_vfs) {"},{"line_number":96,"context_line":"    validate_array($max_reserved_vfs)"},{"line_number":97,"context_line":"    neutron::agents::ml2::sriov::max_vfs {$max_reserved_vfs:"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":"  package { \u0027neutron-sriov-nic-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_074497b4","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":40},"in_reply_to":"dada55a8_cc94648c","updated":"2016-07-21 14:54:21.000000000","message":"Ah, right, ignore my comment","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"fcc621ecd5e46854a5acf1960e64e870ffecc0f7","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  if !is_service_default($max_reserved_vfs) and !empty($max_reserved_vfs) {"},{"line_number":96,"context_line":"    validate_array($max_reserved_vfs)"},{"line_number":97,"context_line":"    neutron::agents::ml2::sriov::max_vfs {$max_reserved_vfs:"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":"  package { \u0027neutron-sriov-nic-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_cc94648c","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":40},"in_reply_to":"dada55a8_fe9e4005","updated":"2016-07-21 14:29:43.000000000","message":"I am getting error  \"Error: Syntax error at \u0027max_reserved_vfs\u0027; expected \u0027}\u0027\" with \" Neutron::Agents::Ml2::Sriov::Max_vfs\"","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"258b9a36eb1c5c30b351d01f51e7b2598dd6a015","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*max_reserved_vfs*]"},{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to undef."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":69,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_274488b5","line":66,"updated":"2016-07-26 09:52:04.000000000","message":"Defaults to $::os_service_default","commit_id":"9ecd0efa162ac277d4dc869e805dc8f01771e6b6"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"567e13739974c39daa3614554da1f5b9aa8acb50","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*max_reserved_vfs*]"},{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to undef."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":69,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_3b1f3cb8","line":66,"in_reply_to":"dada55a8_274488b5","updated":"2016-07-28 09:28:41.000000000","message":"Done","commit_id":"9ecd0efa162ac277d4dc869e805dc8f01771e6b6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d70caeab7a1676554505e53c2ac149cdd90cd936","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if !is_service_default($max_reserved_vfs) and !empty($max_reserved_vfs) {"},{"line_number":95,"context_line":"    validate_array($max_reserved_vfs)"},{"line_number":96,"context_line":"    neutron::agents::ml2::sriov::max_vfs {$max_reserved_vfs:"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":"  package { \u0027neutron-sriov-nic-agent\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_a471e246","line":96,"updated":"2016-08-03 13:33:36.000000000","message":"you don\u0027t need this define at all. Just call:\n\nneutron_agent_sriov_maxvfs { $max_reserved_vfs: ensure \u003d\u003e present }\n\nThen, in the provider you can parse title as you need and then validate parsed values.","commit_id":"8e596c35d9e1fa361f94c666da6cc1581edfc02c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"e0bde6146306de0ce5c8dba2ff48fee18b1a8d5b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to false."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*sriov_numvfs*]"},{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to $::os_service_default."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9ad45d7e_b98507d0","line":65,"updated":"2016-08-11 12:20:57.000000000","message":"I suggest to make this description more clear. This parameter is number of VF\u0027s per interface. Please add an example as well.","commit_id":"f542dce79529762267fb8219097caeaf8d6c48e4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f7b410fc7fc292d7562cf9731895227a9708d0d4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   Defaults to false."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# [*sriov_numvfs*]"},{"line_number":65,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":66,"context_line":"#   Defaults to $::os_service_default."},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":11,"id":"9ad45d7e_6f2eee8c","line":65,"in_reply_to":"9ad45d7e_b98507d0","updated":"2016-08-12 06:22:41.000000000","message":"Done","commit_id":"f542dce79529762267fb8219097caeaf8d6c48e4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c7ffadb9a2b47a875ed4edfb0b7c500fa20d0655","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#   (optional) List of \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e specifying the number"},{"line_number":66,"context_line":"#   VFs to be exposed per physical interface."},{"line_number":67,"context_line":"#   For example, to configure two inteface with number of VFs, spcifiy it as \"eth1:4,eth2:10\""},{"line_number":68,"context_line":"#   Defaults to $::os_service_default."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":71,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7ac969e8_7a34e1dd","line":68,"updated":"2016-08-12 23:11:43.000000000","message":"in retrospect, I wonder if this might have been better named as sriov_numvfs_list or something. I find my head getting twisted by the fact the name is the same as the file that is being altered fro a device.","commit_id":"b233421c6495345742a30650b1e6cbcbe5077a65"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"539e3b0f206da68a3ee633e0f6b1513a37060777","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#   (optional) List of \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e specifying the number"},{"line_number":66,"context_line":"#   VFs to be exposed per physical interface."},{"line_number":67,"context_line":"#   For example, to configure two inteface with number of VFs, spcifiy it as \"eth1:4,eth2:10\""},{"line_number":68,"context_line":"#   Defaults to $::os_service_default."},{"line_number":69,"context_line":"#"},{"line_number":70,"context_line":"class neutron::agents::ml2::sriov ("},{"line_number":71,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3ac371cc_626fcfc5","line":68,"in_reply_to":"7ac969e8_7a34e1dd","updated":"2016-08-16 06:57:08.000000000","message":"I understand your concern, but if i look at the convention _list is not used generally. Also since this class is specific to sr-iov, i shall rename it as number_of_vfs.","commit_id":"b233421c6495345742a30650b1e6cbcbe5077a65"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to false."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":15,"id":"3ac371cc_f86b12b7","line":66,"updated":"2016-08-17 16:35:00.000000000","message":"example text of format?","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to false."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":15,"id":"3ac371cc_754244af","line":66,"in_reply_to":"3ac371cc_7e4a6327","updated":"2016-08-18 14:05:38.000000000","message":"Done","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"18838dcd1fe02d115cbc0974b85c42b8187c78f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to false."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":15,"id":"3ac371cc_7e4a6327","line":66,"in_reply_to":"3ac371cc_f86b12b7","updated":"2016-08-17 17:28:25.000000000","message":"Description is still not clear. It could be \n\u0027The maximum number of VF\u0027s that needs to be available per interface\u0027.\n\n+1 for example","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to false."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) The maximum number of VF\u0027s that needs to be available"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":15,"id":"3ac371cc_1537904d","line":66,"in_reply_to":"3ac371cc_f86b12b7","updated":"2016-08-18 14:05:38.000000000","message":"Done","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"c12dbbed94db07230e20425597165d4e6922664b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   Defaults to false."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) List of \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e specifying the number"},{"line_number":67,"context_line":"#   VFs to be exposed per physical interface."},{"line_number":68,"context_line":"#   For example, to configure two inteface with number of VFs, specifiy"},{"line_number":69,"context_line":"#   it as \"eth1:4,eth2:10\""}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1ac06dbe_3e124b63","line":66,"range":{"start_line":66,"start_character":33,"end_line":66,"end_character":39},"updated":"2016-08-19 14:49:26.000000000","message":"ditto","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"93ade0eba9c3a274dd320d70ce4578d84068a57c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# [*number_of_vfs*]"},{"line_number":66,"context_line":"#   (optional) List of \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e specifying the number"},{"line_number":67,"context_line":"#   VFs to be exposed per physical interface."},{"line_number":68,"context_line":"#   For example, to configure two inteface with number of VFs, specifiy"},{"line_number":69,"context_line":"#   it as \"eth1:4,eth2:10\""},{"line_number":70,"context_line":"#   Defaults to $::os_service_default."},{"line_number":71,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"1ac06dbe_3ba53d04","line":68,"updated":"2016-08-19 14:23:27.000000000","message":"Good description! nit typo: specify","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7c7a444b32d7666e45e3a8513e0d29435ce2cccc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#   (optional) List of \u003cphysical_netork\u003e:\u003cnumber_of_vfs\u003e specifying the number"},{"line_number":67,"context_line":"#   VFs to be exposed per physical interface."},{"line_number":68,"context_line":"#   For example, to configure two inteface with number of VFs, specifiy"},{"line_number":69,"context_line":"#   it as \"eth1:4,eth2:10\""},{"line_number":70,"context_line":"#   Defaults to $::os_service_default."},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class neutron::agents::ml2::sriov ("}],"source_content_type":"text/x-puppet","patch_set":16,"id":"3ac371cc_3bc9ddac","line":69,"updated":"2016-08-19 09:25:27.000000000","message":"yeah, that\u0027s clear now","commit_id":"c0cd74be349e8ad50984da4467c637546a0168bd"}],"manifests/agents/ml2/sriov/max_vfs.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a56179c9a2fe4da21b2194a1631dc0648da1753","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# neutron::agents::ml2::sriov::max_vfs is used by neutron::agents::ml2::sriov"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# max_vfs of each interface used for SR-IOV shall be configured by this"},{"line_number":4,"context_line":"# module"},{"line_number":5,"context_line":"# the $name is given in the format \"\u003cinterface_name\u003e:\u003cmax_vfs\u003e\""},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_1eafd42a","line":4,"updated":"2016-07-21 10:37:39.000000000","message":"missed doc section for parameters","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"fcc621ecd5e46854a5acf1960e64e870ffecc0f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# neutron::agents::ml2::sriov::max_vfs is used by neutron::agents::ml2::sriov"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# max_vfs of each interface used for SR-IOV shall be configured by this"},{"line_number":4,"context_line":"# module"},{"line_number":5,"context_line":"# the $name is given in the format \"\u003cinterface_name\u003e:\u003cmax_vfs\u003e\""},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_63111004","line":4,"in_reply_to":"dada55a8_1eafd42a","updated":"2016-07-21 14:29:43.000000000","message":"Done","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a56179c9a2fe4da21b2194a1631dc0648da1753","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# module"},{"line_number":5,"context_line":"# the $name is given in the format \"\u003cinterface_name\u003e:\u003cmax_vfs\u003e\""},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"define neutron::agents::ml2::sriov::max_vfs() {"},{"line_number":11,"context_line":"  $interface_maxvfs_pair \u003d split($name, \u0027:\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_deb89c77","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":0},"updated":"2016-07-21 10:37:39.000000000","message":"empty lines","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"fcc621ecd5e46854a5acf1960e64e870ffecc0f7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# module"},{"line_number":5,"context_line":"# the $name is given in the format \"\u003cinterface_name\u003e:\u003cmax_vfs\u003e\""},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"define neutron::agents::ml2::sriov::max_vfs() {"},{"line_number":11,"context_line":"  $interface_maxvfs_pair \u003d split($name, \u0027:\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_c3fc3cba","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":0},"in_reply_to":"dada55a8_deb89c77","updated":"2016-07-21 14:29:43.000000000","message":"Done","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7a56179c9a2fe4da21b2194a1631dc0648da1753","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"define neutron::agents::ml2::sriov::max_vfs() {"},{"line_number":11,"context_line":"  $interface_maxvfs_pair \u003d split($name, \u0027:\u0027)"},{"line_number":12,"context_line":"  "},{"line_number":13,"context_line":"  $interface_name \u003d $interface_maxvfs_pair[0]"},{"line_number":14,"context_line":"  $max_vfs        \u003d $interface_maxvfs_pair[1]"},{"line_number":15,"context_line":"  $sriov_numvfs_path \u003d \"/sys/class/net/${interface_name}/device/sriov_numvfs\""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_9e6904fc","line":12,"updated":"2016-07-21 10:37:39.000000000","message":"empty line","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"fcc621ecd5e46854a5acf1960e64e870ffecc0f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"define neutron::agents::ml2::sriov::max_vfs() {"},{"line_number":11,"context_line":"  $interface_maxvfs_pair \u003d split($name, \u0027:\u0027)"},{"line_number":12,"context_line":"  "},{"line_number":13,"context_line":"  $interface_name \u003d $interface_maxvfs_pair[0]"},{"line_number":14,"context_line":"  $max_vfs        \u003d $interface_maxvfs_pair[1]"},{"line_number":15,"context_line":"  $sriov_numvfs_path \u003d \"/sys/class/net/${interface_name}/device/sriov_numvfs\""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_a3f788d1","line":12,"in_reply_to":"dada55a8_9e6904fc","updated":"2016-07-21 14:29:43.000000000","message":"Done","commit_id":"ed2c83742841a6883a9cafcc7cb2cb9ca43b244b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"258b9a36eb1c5c30b351d01f51e7b2598dd6a015","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    command \u003d\u003e \"echo ${max_vfs} \u003e ${sriov_numvfs_path}\","},{"line_number":29,"context_line":"    onlyif  \u003d\u003e \"test -f ${sriov_numvfs_path}\","},{"line_number":30,"context_line":"    path    \u003d\u003e \u0027/bin\u0027,"},{"line_number":31,"context_line":"    require \u003d\u003e Exec[\"clear_${interface_name}\"],"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_47e37ca4","line":31,"updated":"2016-07-26 09:52:04.000000000","message":"This will be always non-idempotent. We need to check value in the file and change it only if needed.","commit_id":"9ecd0efa162ac277d4dc869e805dc8f01771e6b6"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"567e13739974c39daa3614554da1f5b9aa8acb50","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    command \u003d\u003e \"echo ${max_vfs} \u003e ${sriov_numvfs_path}\","},{"line_number":29,"context_line":"    onlyif  \u003d\u003e \"test -f ${sriov_numvfs_path}\","},{"line_number":30,"context_line":"    path    \u003d\u003e \u0027/bin\u0027,"},{"line_number":31,"context_line":"    require \u003d\u003e Exec[\"clear_${interface_name}\"],"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bacf61ea_f5befbfd","line":31,"in_reply_to":"dada55a8_47e37ca4","updated":"2016-07-28 09:28:41.000000000","message":"I\u0027ve comitted a patch (WIP). Please let me know if this is what expected.","commit_id":"9ecd0efa162ac277d4dc869e805dc8f01771e6b6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"13289160d8cc6158261db2fb97aff75ad3bd0978","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    command \u003d\u003e \"echo ${max_vfs} \u003e ${sriov_numvfs_path}\","},{"line_number":29,"context_line":"    onlyif  \u003d\u003e \"test -f ${sriov_numvfs_path}\","},{"line_number":30,"context_line":"    path    \u003d\u003e \u0027/bin\u0027,"},{"line_number":31,"context_line":"    require \u003d\u003e Exec[\"clear_${interface_name}\"],"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_8d19138b","line":31,"in_reply_to":"dada55a8_47e37ca4","updated":"2016-07-26 10:31:37.000000000","message":"agree, both execs are not idempotent","commit_id":"9ecd0efa162ac277d4dc869e805dc8f01771e6b6"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"303b1d520179b4a2a48a7b20ba3ae78ce23b9b58","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        command \u003d\u003e \"echo 0 \u003e ${sriov_numvfs_path}\","},{"line_number":29,"context_line":"        path    \u003d\u003e \u0027/bin\u0027,"},{"line_number":30,"context_line":"        before  \u003d\u003e Exec[\"set_${interface_name}\"]"},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":"      }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      # set the max_vfs in the file $sriov_numvfs_path"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_591e2164","line":31,"updated":"2016-07-28 10:14:29.000000000","message":"The idempotency for puppet means that second run of the same puppet catalog won\u0027t add any changes (puppet will succeed with return code 0). So, to fix it you need to check first current value in the file. If it equals to the value that you want to set, you should do nothing. It would be better to implement a provider for management of /sys/class/net/${interface_name}/device/sriov_numvfs files. I don\u0027t really like the idea of parsing variables and inline_templates with ruby calls in puppet","commit_id":"713ac4878c2d2d0f81d6aa344c82eb68f9fd890d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"cb58fc63444e4b9eb18199e041c06036c000c8fd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        command \u003d\u003e \"echo 0 \u003e ${sriov_numvfs_path}\","},{"line_number":29,"context_line":"        path    \u003d\u003e \u0027/bin\u0027,"},{"line_number":30,"context_line":"        before  \u003d\u003e Exec[\"set_${interface_name}\"]"},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":"      }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"      # set the max_vfs in the file $sriov_numvfs_path"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bacf61ea_bd7e65e1","line":31,"in_reply_to":"bacf61ea_591e2164","updated":"2016-08-02 08:55:58.000000000","message":"Thanks for the review. I\u0027ve uploaded another patch. I am a newbie to puppet and ruby. please advise if there could be a better approach.","commit_id":"713ac4878c2d2d0f81d6aa344c82eb68f9fd890d"}],"spec/classes/neutron_agents_ml2_sriov_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a05a8bd2593a519cfd5bf32cc6a3f70332c7ec32","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      is_expected.to contain_service(\u0027neutron-sriov-nic-agent-service\u0027).that_notifies(\u0027Anchor[neutron::service::end]\u0027)"},{"line_number":74,"context_line":"    end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    context \u0027when max_reserved_vfs is empty\u0027 do"},{"line_number":77,"context_line":"      before :each do"},{"line_number":78,"context_line":"        params.merge!(:max_reserved_vfs \u003d\u003e \"\")"},{"line_number":79,"context_line":"      end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"      it \u0027does not configure max_vfs \u0027 do"},{"line_number":82,"context_line":"        is_expected.not_to contain_neutron__agents__ml2__sriov__max_vfs(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":83,"context_line":"      end"},{"line_number":84,"context_line":"    end"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    context \u0027when max_reserved_vfs is configured\u0027 do"},{"line_number":87,"context_line":"      before :each do"},{"line_number":88,"context_line":"        params.merge!(:max_reserved_vfs \u003d\u003e [\u0027eth0:4\u0027,\u0027eth2:5\u0027])"},{"line_number":89,"context_line":"      end"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"      it \u0027configures max_vfs\u0027 do"},{"line_number":92,"context_line":"        is_expected.to contain_neutron__agents__ml2__sriov__max_vfs(\u0027eth0:4\u0027,\u0027eth2:5\u0027)"},{"line_number":93,"context_line":"        is_expected.to contain_exec(\u0027clear_eth0\u0027).with_command(\u0027echo 0 \u003e /sys/class/net/eth0/device/sriov_numvfs\u0027)"},{"line_number":94,"context_line":"        is_expected.to contain_exec(\u0027set_eth0\u0027).with_command(\u0027echo 4 \u003e /sys/class/net/eth0/device/sriov_numvfs\u0027)"},{"line_number":95,"context_line":"        is_expected.to contain_exec(\u0027clear_eth2\u0027).with_command(\u0027echo 0 \u003e /sys/class/net/eth2/device/sriov_numvfs\u0027)"},{"line_number":96,"context_line":"        is_expected.to contain_exec(\u0027set_eth2\u0027).with_command(\u0027echo 5 \u003e /sys/class/net/eth2/device/sriov_numvfs\u0027)"},{"line_number":97,"context_line":"      end"},{"line_number":98,"context_line":"    end"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    context \u0027with manage_service as false\u0027 do"},{"line_number":101,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"dada55a8_4f02010d","line":98,"range":{"start_line":76,"start_character":0,"end_line":98,"end_character":7},"updated":"2016-07-22 07:51:46.000000000","message":"this test should be moved for separate test file for define actually. As this define can be called out of ml2_sriov class.\n\nin this class you can check is define included or not.","commit_id":"1dddd730ad550b408eeda11ddffc066f0613676e"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"4f52cfe8d03fd522af0d247ece4374b3d5912523","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      is_expected.to contain_service(\u0027neutron-sriov-nic-agent-service\u0027).that_notifies(\u0027Anchor[neutron::service::end]\u0027)"},{"line_number":74,"context_line":"    end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    context \u0027when max_reserved_vfs is empty\u0027 do"},{"line_number":77,"context_line":"      before :each do"},{"line_number":78,"context_line":"        params.merge!(:max_reserved_vfs \u003d\u003e \"\")"},{"line_number":79,"context_line":"      end"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"      it \u0027does not configure max_vfs \u0027 do"},{"line_number":82,"context_line":"        is_expected.not_to contain_neutron__agents__ml2__sriov__max_vfs(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":83,"context_line":"      end"},{"line_number":84,"context_line":"    end"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    context \u0027when max_reserved_vfs is configured\u0027 do"},{"line_number":87,"context_line":"      before :each do"},{"line_number":88,"context_line":"        params.merge!(:max_reserved_vfs \u003d\u003e [\u0027eth0:4\u0027,\u0027eth2:5\u0027])"},{"line_number":89,"context_line":"      end"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"      it \u0027configures max_vfs\u0027 do"},{"line_number":92,"context_line":"        is_expected.to contain_neutron__agents__ml2__sriov__max_vfs(\u0027eth0:4\u0027,\u0027eth2:5\u0027)"},{"line_number":93,"context_line":"        is_expected.to contain_exec(\u0027clear_eth0\u0027).with_command(\u0027echo 0 \u003e /sys/class/net/eth0/device/sriov_numvfs\u0027)"},{"line_number":94,"context_line":"        is_expected.to contain_exec(\u0027set_eth0\u0027).with_command(\u0027echo 4 \u003e /sys/class/net/eth0/device/sriov_numvfs\u0027)"},{"line_number":95,"context_line":"        is_expected.to contain_exec(\u0027clear_eth2\u0027).with_command(\u0027echo 0 \u003e /sys/class/net/eth2/device/sriov_numvfs\u0027)"},{"line_number":96,"context_line":"        is_expected.to contain_exec(\u0027set_eth2\u0027).with_command(\u0027echo 5 \u003e /sys/class/net/eth2/device/sriov_numvfs\u0027)"},{"line_number":97,"context_line":"      end"},{"line_number":98,"context_line":"    end"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    context \u0027with manage_service as false\u0027 do"},{"line_number":101,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"dada55a8_0527e112","line":98,"range":{"start_line":76,"start_character":0,"end_line":98,"end_character":7},"in_reply_to":"dada55a8_4f02010d","updated":"2016-07-25 17:57:18.000000000","message":"Done","commit_id":"1dddd730ad550b408eeda11ddffc066f0613676e"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        is_expected.to contain_neutron_agent_sriov_numvfs(\u0027eth0:4\u0027).with( :ensure \u003d\u003e \u0027present\u0027 )"},{"line_number":91,"context_line":"        is_expected.to contain_neutron_agent_sriov_numvfs(\u0027eth1:5\u0027).with( :ensure \u003d\u003e \u0027present\u0027)"},{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    context \u0027with manage_service as false\u0027 do"},{"line_number":96,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_043fa787","line":93,"updated":"2016-08-17 16:35:00.000000000","message":"Good spot to add a test that tries to to blow things up with some improperly formatted inputs.","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        is_expected.to contain_neutron_agent_sriov_numvfs(\u0027eth0:4\u0027).with( :ensure \u003d\u003e \u0027present\u0027 )"},{"line_number":91,"context_line":"        is_expected.to contain_neutron_agent_sriov_numvfs(\u0027eth1:5\u0027).with( :ensure \u003d\u003e \u0027present\u0027)"},{"line_number":92,"context_line":"      end"},{"line_number":93,"context_line":"    end"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    context \u0027with manage_service as false\u0027 do"},{"line_number":96,"context_line":"      before :each do"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_95df00d5","line":93,"in_reply_to":"3ac371cc_043fa787","updated":"2016-08-18 14:05:38.000000000","message":"test cases are added @ https://review.openstack.org/#/c/344918/16/spec/unit/type/neutron_agent_sriov_numvfs_spec.rb@11","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"}],"spec/unit/provider/neutron_agent_sriov_numvfs/sriov_numvfs_spec.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a6ecf99524311e51238dc433d1d87520189dcca7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      :name            \u003d\u003e \u0027eth0:10\u0027,"},{"line_number":13,"context_line":"      :ensure          \u003d\u003e \u0027present\u0027,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  describe \u0027when setting the attributes\u0027 do"},{"line_number":18,"context_line":"    let :resource do"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_8ebc5807","line":15,"updated":"2016-08-17 16:35:00.000000000","message":"Where the provider has code paths that can/should fail, some negative tests are warranted somewhere. I think Ivan mentioned that in a review against an earlier patchset. Tbh, I\u0027m not sure where the preferred place is for that kind of thing is. Most of the tests that I\u0027ve seen that verify errors are raised are in tests on classes.","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"03daa448b22c15fc2cca134bcfb93fcb68285bd8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      :name            \u003d\u003e \u0027eth0:10\u0027,"},{"line_number":13,"context_line":"      :ensure          \u003d\u003e \u0027present\u0027,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  describe \u0027when setting the attributes\u0027 do"},{"line_number":18,"context_line":"    let :resource do"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_558748b4","line":15,"in_reply_to":"3ac371cc_7e71c375","updated":"2016-08-18 14:05:38.000000000","message":"Failure cases are added in \nhttps://review.openstack.org/#/c/344918/16/spec/unit/type/neutron_agent_sriov_numvfs_spec.rb@11","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"18838dcd1fe02d115cbc0974b85c42b8187c78f1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      :name            \u003d\u003e \u0027eth0:10\u0027,"},{"line_number":13,"context_line":"      :ensure          \u003d\u003e \u0027present\u0027,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  describe \u0027when setting the attributes\u0027 do"},{"line_number":18,"context_line":"    let :resource do"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"3ac371cc_7e71c375","line":15,"in_reply_to":"3ac371cc_8ebc5807","updated":"2016-08-17 17:28:25.000000000","message":"yep, I wanted to see some case when something can fail","commit_id":"5d72f6c0cc21766765875c38f968ad4b69d2145d"}]}
