)]}'
{"lib/puppet/parser/functions/get_router_id.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0473378dd8bcebbe3529f44c21e652f10fbae78f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"module Puppet::Parser::Functions"},{"line_number":17,"context_line":"  newfunction(:get_router_id, :type \u003d\u003e :rvalue) do |args|"},{"line_number":18,"context_line":"    router_name \u003d args[0]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    authenv \u003d {"},{"line_number":21,"context_line":"      :OS_AUTH_URL    \u003d\u003e args[1],"},{"line_number":22,"context_line":"      :OS_USERNAME    \u003d\u003e args[2],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dada55a8_032a8f7e","line":19,"updated":"2016-07-22 14:24:31.000000000","message":"I would avoid this approach and rather investigate using openstacklib / openstack provider for that.","commit_id":"3897c8b47e85b7c693182ac81f939299e19d2515"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7f63d5a28b12d693d5ea2a9e08c2ac201ab693a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"module Puppet::Parser::Functions"},{"line_number":17,"context_line":"  newfunction(:get_router_id, :type \u003d\u003e :rvalue) do |args|"},{"line_number":18,"context_line":"    router_name \u003d args[0]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    authenv \u003d {"},{"line_number":21,"context_line":"      :OS_AUTH_URL    \u003d\u003e args[1],"},{"line_number":22,"context_line":"      :OS_USERNAME    \u003d\u003e args[2],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"dada55a8_f2cf5e27","line":19,"updated":"2016-07-22 08:06:22.000000000","message":"well, that\u0027s good idea, but i have several doubts:\n\n1) i think it make sense to create one common function for all resources, which can return ID of resource (take a look on this https://review.openstack.org/#/c/330623) - i guess you can cooperate work on this;\n\n2) the problem for this current implementation, is that you read only OS_ENV vars, that not correct, in situation when we have openrc file.","commit_id":"3897c8b47e85b7c693182ac81f939299e19d2515"}]}
