)]}'
{"manifests/agents/ml2/vpp.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"464c034c8a73f27429f1bea4b86193a6d9adcea6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled          \u003d true,"},{"line_number":48,"context_line":"  $manage_service   \u003d true,"},{"line_number":49,"context_line":"  $physnets         \u003d $::os_service_default,"},{"line_number":50,"context_line":"  $etcd_host        \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $etcd_port        \u003d 4001,"},{"line_number":52,"context_line":"  $etcd_user        \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $etcd_pass        \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $purge_config     \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_c74690bf","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":27},"updated":"2016-12-09 20:12:00.000000000","message":"are those values set to defaults? why not $::os_service_default here as well?","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"},{"author":{"_account_id":20971,"name":"Feng Pan","email":"fpan@redhat.com","username":"fpan"},"change_message_id":"49f8c9ad96ba6c098cf336f27ef8dda956df5adc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled          \u003d true,"},{"line_number":48,"context_line":"  $manage_service   \u003d true,"},{"line_number":49,"context_line":"  $physnets         \u003d $::os_service_default,"},{"line_number":50,"context_line":"  $etcd_host        \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $etcd_port        \u003d 4001,"},{"line_number":52,"context_line":"  $etcd_user        \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $etcd_pass        \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $purge_config     \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_550ab626","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"1a6eadb0_455b23f6","updated":"2016-12-16 23:03:27.000000000","message":"Done. Also, networking-vpp agent as well as the ML2 plugin do have defaults for those values now, so we should be good.","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"fd6d688d250e09149dd31fb41369906e592d0d9a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled          \u003d true,"},{"line_number":48,"context_line":"  $manage_service   \u003d true,"},{"line_number":49,"context_line":"  $physnets         \u003d $::os_service_default,"},{"line_number":50,"context_line":"  $etcd_host        \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $etcd_port        \u003d 4001,"},{"line_number":52,"context_line":"  $etcd_user        \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $etcd_pass        \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $purge_config     \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_455b23f6","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"1a6eadb0_88947543","updated":"2016-12-15 18:23:21.000000000","message":"These should be $::os_service_default.  The defaults are set in the networking-vpp ml2 config code, but there is a bug Feng found where the networking-vpp agent code is not using the same defaults.","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7eb4bcee55418fbb038e37bfd14c54308d8ea776","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled          \u003d true,"},{"line_number":48,"context_line":"  $manage_service   \u003d true,"},{"line_number":49,"context_line":"  $physnets         \u003d $::os_service_default,"},{"line_number":50,"context_line":"  $etcd_host        \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $etcd_port        \u003d 4001,"},{"line_number":52,"context_line":"  $etcd_user        \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $etcd_pass        \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $purge_config     \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_88947543","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"3a71b18c_2461f739","updated":"2016-12-15 16:57:52.000000000","message":"I think the question is why the neutron vpp agent doesn\u0027t set the default values in the code directly, like it\u0027s done for other projects. What if we uncomment these parameters?","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"},{"author":{"_account_id":20971,"name":"Feng Pan","email":"fpan@redhat.com","username":"fpan"},"change_message_id":"ab7d40d282e19a7b9e6accaf76ea3e005dc6a628","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $enabled          \u003d true,"},{"line_number":48,"context_line":"  $manage_service   \u003d true,"},{"line_number":49,"context_line":"  $physnets         \u003d $::os_service_default,"},{"line_number":50,"context_line":"  $etcd_host        \u003d \u0027127.0.0.1\u0027,"},{"line_number":51,"context_line":"  $etcd_port        \u003d 4001,"},{"line_number":52,"context_line":"  $etcd_user        \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $etcd_pass        \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $purge_config     \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_2461f739","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"3a71b18c_c74690bf","updated":"2016-12-10 02:22:41.000000000","message":"Those values are set to the default settings for a local etcd installation so that it would work without being set. Things like username and passwords are optional features in etcd that may be disabled, so that\u0027s why I default them to service default so we don\u0027t set them.","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"}],"manifests/plugins/ml2/vpp.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"464c034c8a73f27429f1bea4b86193a6d9adcea6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Defaults to $::os_service_default."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class neutron::plugins::ml2::vpp ("},{"line_number":24,"context_line":"  $etcd_host       \u003d \u0027127.0.0.1\u0027,"},{"line_number":25,"context_line":"  $etcd_port       \u003d 4001,"},{"line_number":26,"context_line":"  $etcd_user       \u003d $::os_service_default,"},{"line_number":27,"context_line":"  $etcd_pass       \u003d $::os_service_default,"},{"line_number":28,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_874018a7","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":26},"updated":"2016-12-09 20:12:00.000000000","message":"same","commit_id":"c22df7b7a109b8036d9e1a5efbbee3edea01d2bf"}]}
