)]}'
{"manifests/plugins/midonet.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2001117f48a1ba9f2ee5ebb9448a7b39ad4393e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*midonet_api_ip*]"},{"line_number":11,"context_line":"#   (DEPRECATED) IP address of the MidoNet API service."},{"line_number":12,"context_line":"#   Defaults to undef"},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*midonet_api_port*]"},{"line_number":15,"context_line":"#   (DEPRECATED) Port on which the MidoNet API service listens."},{"line_number":16,"context_line":"#   Defaults to undef"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*midonet_cluster_ip*]"},{"line_number":19,"context_line":"#   IP address of the MidoNet Cluster service."},{"line_number":20,"context_line":"#   Defaults to \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa31d9ce_02317005","line":17,"range":{"start_line":10,"start_character":0,"end_line":17,"end_character":1},"updated":"2017-02-13 15:17:05.000000000","message":"usually when we deprecate stuff we\u0027ll move the docs into their own DEPRECATED section.  For example, https://github.com/openstack/puppet-nova/blob/29d44cdf26e18a14b64cad61ffe9725a25d0f0ca/manifests/keystone/auth.pp#L58","commit_id":"8bab4fec241ecd091d83ab9723d2fd96b97c29d2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2001117f48a1ba9f2ee5ebb9448a7b39ad4393e4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# limitations under the License."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"class neutron::plugins::midonet ("},{"line_number":95,"context_line":"  $midonet_api_ip        \u003d undef,"},{"line_number":96,"context_line":"  $midonet_api_port      \u003d undef,"},{"line_number":97,"context_line":"  $midonet_cluster_ip    \u003d \u0027127.0.0.1\u0027,"},{"line_number":98,"context_line":"  $midonet_cluster_port  \u003d \u00278181\u0027,"},{"line_number":99,"context_line":"  $keystone_username     \u003d \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa31d9ce_2203d410","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":33},"updated":"2017-02-13 15:17:05.000000000","message":"Additionally we\u0027ll move these to the bottom under a # DEPRECATED comment. Example, https://github.com/openstack/puppet-nova/blob/29d44cdf26e18a14b64cad61ffe9725a25d0f0ca/manifests/keystone/auth.pp#L102","commit_id":"8bab4fec241ecd091d83ab9723d2fd96b97c29d2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2001117f48a1ba9f2ee5ebb9448a7b39ad4393e4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    $cluster_port \u003d $midonet_cluster_port"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/midonet\u0027,"},{"line_number":127,"context_line":"    {"},{"line_number":128,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":129,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa31d9ce_a50d0e39","line":126,"updated":"2017-02-13 15:17:05.000000000","message":"This really should be handled by packaging if possible","commit_id":"8bab4fec241ecd091d83ab9723d2fd96b97c29d2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c8358db806f1a828a84da17381d6430f95372154","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    $cluster_port \u003d $midonet_cluster_port"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/midonet\u0027,"},{"line_number":127,"context_line":"    {"},{"line_number":128,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":129,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a1ff146_0f52bb67","line":126,"in_reply_to":"3a1ff146_07d55b42","updated":"2017-03-15 15:16:36.000000000","message":"It\u0027s a best practice that we usually try and enforce of relying on packaging to manage folders/permissions. For something like this, python-networking-midonet probably should ensure this folder creation rather than puppet because then it also ensures that people who aren\u0027t using puppet also get the same paths.","commit_id":"8bab4fec241ecd091d83ab9723d2fd96b97c29d2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b8ee9f33fdee30ed9cac69fc74106039379f4c13","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    $cluster_port \u003d $midonet_cluster_port"},{"line_number":124,"context_line":"  }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/midonet\u0027,"},{"line_number":127,"context_line":"    {"},{"line_number":128,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":129,"context_line":"      owner  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a1ff146_07d55b42","line":126,"in_reply_to":"fa31d9ce_a50d0e39","updated":"2017-03-15 04:59:35.000000000","message":"why?\n\npuppet-neutron seems to have a control of the path.\n($::neutron::params::midonet_config_file)","commit_id":"8bab4fec241ecd091d83ab9723d2fd96b97c29d2"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"443d010c48bba7b8f4332a57efad786f3ebf0f4c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  if $sync_db {"},{"line_number":178,"context_line":"    Package\u003c| title \u003d\u003d \u0027python-networking-midonet\u0027 |\u003e     ~\u003e Exec[\u0027midonet-db-sync\u0027]"},{"line_number":179,"context_line":"    exec { \u0027midonet-db-sync\u0027:"},{"line_number":180,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage --subproject networking-midonet upgrade head\u0027,"},{"line_number":181,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":182,"context_line":"      subscribe   \u003d\u003e ["},{"line_number":183,"context_line":"        Anchor[\u0027neutron::install::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"da36d5c6_e0867615","line":180,"updated":"2017-02-27 21:07:05.000000000","message":"Just a sidenote, we should file a bz to \"sync up\" all of the these types of commands, e.g. the main one does a \"upgrade heads\" instead.","commit_id":"d2aaa8e2684b5722c2428d5a9f74f6d8163aaae0"}],"spec/classes/neutron_plugins_midonet_spec.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"443d010c48bba7b8f4332a57efad786f3ebf0f4c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    :keystone_tenant   \u003d\u003e \u0027services\u0027,"},{"line_number":20,"context_line":"    :purge_config      \u003d\u003e false,"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  let :test_facts do"},{"line_number":25,"context_line":"    { :operatingsystem           \u003d\u003e \u0027default\u0027,"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"da36d5c6_4002e270","line":22,"updated":"2017-02-27 21:07:05.000000000","message":"Should we have a test that verifies that the old parameters are directed to the new ones?","commit_id":"d2aaa8e2684b5722c2428d5a9f74f6d8163aaae0"}]}