)]}'
{"lib/puppet/provider/neutron_bgpvpn_bagpipe_config/openstackconfig.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ea1c402b1d0d5fff9e99a4842ca856a3b0fe0027","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/bagpipe-bgp/bgp.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a1ced50_69ac468c","line":7,"updated":"2017-03-23 14:17:07.000000000","message":"should this be under \u0027/etc/neutron/bagpipe-bgp/bgp.conf\u0027 ?","commit_id":"39dbb20e12b6ca73bb959f8fb8e109e9adcc609d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"677bdd2f50bca3bc5396fbc96cf0dd988c6c8770","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/bagpipe-bgp/bgp.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_04c0a84f","line":7,"updated":"2017-03-27 14:51:50.000000000","message":"/etc/neutron/plugins/bagpipe-bpg/bgp.conf?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"64b44e280a251f30c25a7b93d2edd63dac4924ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/bagpipe-bgp/bgp.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_8d23bb05","line":7,"in_reply_to":"ffe62b97_04c0a84f","updated":"2017-03-27 21:39:03.000000000","message":"Well, bagpipe-bgp in this context is related to neutron, but it is not a neutron plugin per se.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8c9893d777b27c89729e57dda01e0a933180f5d1","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/bagpipe-bgp/bgp.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_81613408","line":7,"in_reply_to":"ffe62b97_8d23bb05","updated":"2017-03-27 22:08:37.000000000","message":"OK just checking","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"}],"manifests/agents/bagpipe-bgp.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"65cde4bf9706cd40c6773ee2b3d15e138993ccf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Ricardo Noriega \u003crnoriega@redhat.com\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_f21c0279","line":1,"updated":"2017-03-29 12:17:14.000000000","message":"please change this file back to bagpipe.pp as it must match the class name or it won\u0027t load correctly. Since this will probably include more than just the bgp configuration in the long run and it matches the ml2 file name.","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d679d4de4002daab883f9177caaf12099fe6e959","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Ricardo Noriega \u003crnoriega@redhat.com\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_660f0a88","line":1,"in_reply_to":"ffe62b97_f21c0279","updated":"2017-03-29 15:22:26.000000000","message":"(see my other comment on the respective role of bagpipe-bgp and the ML2 driver)\n\nI think it will be a good thing to actually separate bagpipe-bgp config, and bagpipe ML2 config, and naming the corresponding file in a way consistent with this separation.\n\nIf file and class name need to be consistent, then why not rename both to bagpipe-bgp ?\n\nAlex, maybe I\u0027m overthinking this indeed :)\nBut still, we need to choose, don\u0027t we ?\n\nI think the current name is fine, *if* we conclude that ML2 config for bagpipe (when used) has to be in the same file, but my feeling is that its not the best target.","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"4a1304e1cfac22a0c58db30d497d3fbc97e05bc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Author: Ricardo Noriega \u003crnoriega@redhat.com\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_582d0ca6","line":1,"in_reply_to":"ffe62b97_f21c0279","updated":"2017-03-29 13:49:50.000000000","message":"Done","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"65cde4bf9706cd40c6773ee2b3d15e138993ccf6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*api_port*]"},{"line_number":37,"context_line":"#   BGP component API port"},{"line_number":38,"context_line":"#   Defaults to 8082   "},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*local_address*]"},{"line_number":41,"context_line":"#   Local IP of the server to carry BGP traffic"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_327f0aac","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":23},"updated":"2017-03-29 12:17:14.000000000","message":"trailing space","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"4a1304e1cfac22a0c58db30d497d3fbc97e05bc0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*api_port*]"},{"line_number":37,"context_line":"#   BGP component API port"},{"line_number":38,"context_line":"#   Defaults to 8082   "},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*local_address*]"},{"line_number":41,"context_line":"#   Local IP of the server to carry BGP traffic"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_f8362003","line":38,"range":{"start_line":38,"start_character":20,"end_line":38,"end_character":23},"in_reply_to":"ffe62b97_327f0aac","updated":"2017-03-29 13:49:50.000000000","message":"Done","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"65cde4bf9706cd40c6773ee2b3d15e138993ccf6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $enabled                 \u003d true,"},{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_32aa6a18","line":82,"updated":"2017-03-29 12:17:14.000000000","message":"given that this appears to be required with no default, you shouldn\u0027t use $::os_service_default. https://github.com/openstack/networking-bagpipe/blob/0eaaf854a2177593aa3d5802721562f8d896c261/networking_bagpipe/bagpipe_bgp/common/config.py#L31\n\n\nWhat happens when you use $::os_service_default is that we remove the item from the config file itself which just falls back to the defined default in python.  Since this is marked as required and doesn\u0027t have a default in python, we can use $::ipaddress here instead.  I would also m ark this as required in the comments.","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"4a1304e1cfac22a0c58db30d497d3fbc97e05bc0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  $enabled                 \u003d true,"},{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_531bad71","line":82,"in_reply_to":"ffe62b97_32aa6a18","updated":"2017-03-29 13:49:50.000000000","message":"Done","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"65cde4bf9706cd40c6773ee2b3d15e138993ccf6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_b26b1aef","line":84,"updated":"2017-03-29 12:17:14.000000000","message":"This also appears to be required, so you should remove the default as it must be specified. https://github.com/openstack/networking-bagpipe/blob/0eaaf854a2177593aa3d5802721562f8d896c261/networking_bagpipe/bagpipe_bgp/common/config.py#L35","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"d679d4de4002daab883f9177caaf12099fe6e959","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_c9014907","line":84,"in_reply_to":"ffe62b97_733eb1b8","updated":"2017-03-29 15:22:26.000000000","message":"No, using 64512 makes no sense, this value has to be configured via the admin (via triple-o) to a value that will match what is used by other BGP peers.\n\nI think it should be empty by default, the service should not startup if not configured.","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"4a1304e1cfac22a0c58db30d497d3fbc97e05bc0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ffe62b97_733eb1b8","line":84,"in_reply_to":"ffe62b97_b26b1aef","updated":"2017-03-29 13:49:50.000000000","message":"Done","commit_id":"158720e500512ed3d48e8834b8186f18220f54d1"}],"manifests/agents/bagpipe.pp":[{"author":{"_account_id":21747,"name":"Peng Liu","email":"pliu@redhat.com","username":"pliu"},"change_message_id":"91c08069452a98c6c248946d4431a39521317e81","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    } else {"},{"line_number":112,"context_line":"      $service_ensure \u003d \u0027stopped\u0027"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    service { \u0027neutron-l2gw-agent\u0027:"},{"line_number":115,"context_line":"      ensure \u003d\u003e $service_ensure,"},{"line_number":116,"context_line":"      name   \u003d\u003e $::neutron::params::bgpvpn_bagpipe_service,"},{"line_number":117,"context_line":"      enable \u003d\u003e $enabled,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ffe62b97_f8470ebc","line":114,"range":{"start_line":114,"start_character":14,"end_line":114,"end_character":33},"updated":"2017-03-24 04:28:50.000000000","message":"should be modified to something like \u0027neutron-bgpvpn-bagpipe\u0027","commit_id":"39dbb20e12b6ca73bb959f8fb8e109e9adcc609d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_fd634bdb","updated":"2017-03-25 07:46:01.000000000","message":"bagpipe-bgp.pp would be a better name for this file","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_acfe2168","in_reply_to":"ffe62b97_599c4469","updated":"2017-03-29 11:31:50.000000000","message":"There is no problem on changing the file name. I\u0027ll update it. However, I\u0027m starting to think that more work needs to be done. Is then networking-bagpipe composed by several pieces like an ML2 plugin + agent?? If so, we have to split these manifest in two. One located in manifests/plugins/ml2/bagpipe.pp and one for the agent in manifests/agents/bagpipe-bgp.pp\n\nThomas, does it make sense?? In that case, the ML2 plugin configuration is located in the controller and the bagpipe-bgp config is in the compute nodes???","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"64b44e280a251f30c25a7b93d2edd63dac4924ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_6d775704","in_reply_to":"ffe62b97_641c1412","updated":"2017-03-27 21:39:03.000000000","message":"why not rename to the better name ?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5fdb637fa2244fe6181c7ae36ab573a836ac962f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_599c4469","in_reply_to":"ffe62b97_6c962796","updated":"2017-03-28 00:20:54.000000000","message":"You\u0027re really over thinking this.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8c9893d777b27c89729e57dda01e0a933180f5d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_8126d4cd","in_reply_to":"ffe62b97_6d775704","updated":"2017-03-27 22:08:37.000000000","message":"As someone who does not really deal with this in neutron, not sure why bagpipe-bgp is better than just bagpipe. It\u0027s not obvious to me.  Since the service is bagpipe-bgp I don\u0027t find bgp as necessary for the naming.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"2cb9b95952a0497b28963687b9f4b7a3e1e24dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_6c962796","in_reply_to":"ffe62b97_8126d4cd","updated":"2017-03-27 22:15:15.000000000","message":"This file controls precisely one component of networking-bagpipe, the component named \"bagpipe-bgp\", and does not control the bagpipe extensions that can be enabled in the neutron agent (ovs or linuxbridge), nor the drivers in neutron server.\n\nSo naming it bagpipe-bgp may help those who identify the role played by the component bagpipe-bgp, to understand that this file is precisely related to this component.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"18339bcd0e6ef962d11ac1d2d1a64a1a2001f9ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_0634bedc","in_reply_to":"ffe62b97_acfe2168","updated":"2017-03-29 15:22:35.000000000","message":"The work we are focusing on is the necessary pieces for bagpipe as a networking-bgpvpn driver (working with ovs ML2). bagpipe ML2 is *not* one of these necessary pieces.\n\nSo the work on bagpipe ML2 can happen later and quite independently ; having it in mind now can just perhaps help choose the right files/config layout.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"677bdd2f50bca3bc5396fbc96cf0dd988c6c8770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffe62b97_641c1412","in_reply_to":"ffe62b97_fd634bdb","updated":"2017-03-27 14:51:50.000000000","message":"it would have to be bagpipe_bgp.pp but this is fine the way it is","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   Defaults to $::os_service_default"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enable_rtc*]"},{"line_number":49,"context_line":"#   Enable Route Target Constrain"},{"line_number":50,"context_line":"#   Defaults to $::os_service_default"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*dataplane_driver_ipvpn*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_1d3cafbd","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":33},"updated":"2017-03-25 07:46:01.000000000","message":"Constraint","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#   Defaults to $::os_service_default"},{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*enable_rtc*]"},{"line_number":49,"context_line":"#   Enable Route Target Constrain"},{"line_number":50,"context_line":"#   Defaults to $::os_service_default"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*dataplane_driver_ipvpn*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_6125c208","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":33},"in_reply_to":"ffe62b97_1d3cafbd","updated":"2017-03-29 11:31:50.000000000","message":"Done","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_9a7c45ec","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"updated":"2017-03-25 07:46:01.000000000","message":"I\u0027m a puppet noob, so I can\u0027t tell whether this will do the right thing.\n\nWill this allow the local_address to have a  distinct value for differents computes nodes, and have this value derived automatically from the configuration of a network interface of the node ?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_610b8229","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"in_reply_to":"ffe62b97_6d81978f","updated":"2017-03-29 11:31:50.000000000","message":"So what should be the default value then? There is a puppet fact that gets the ip address from the host where it\u0027s located https://docs.puppet.com/facter/latest/core_facts.html#ipaddress\n@Alex: should it be something like $::ipaddress?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_a15d0a7a","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"in_reply_to":"ffe62b97_6d81978f","updated":"2017-03-29 11:31:50.000000000","message":"so what should be the default value then?? I\u0027m not a puppet exper","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"677bdd2f50bca3bc5396fbc96cf0dd988c6c8770","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_c473e0b0","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"in_reply_to":"ffe62b97_9a7c45ec","updated":"2017-03-27 14:51:50.000000000","message":"$::os_service_default falls back to whatever is in the python code as it basically removes the configuration value from the configuration file. It\u0027s an puppet openstack specific convention.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"18339bcd0e6ef962d11ac1d2d1a64a1a2001f9ae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_66cdcab5","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"in_reply_to":"ffe62b97_a15d0a7a","updated":"2017-03-29 15:22:35.000000000","message":"The thing is that a compute node will have different addresses on different networks (management, provisioning, external).\n\nSo the local_address to configure should be \"the compute node address on \u003cnetwork-foo\u003e\", \u003cnetwork-foo\u003e being one of these networks.\n\nI\u0027ve not done any research, but I believe that what is done for neutron agent to determine their address could apply here, or give inspiration.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"64b44e280a251f30c25a7b93d2edd63dac4924ba","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":71,"context_line":"  $enabled                 \u003d true,"},{"line_number":72,"context_line":"  $manage_service          \u003d true,"},{"line_number":73,"context_line":"  $local_address           \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_6d81978f","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":51},"in_reply_to":"ffe62b97_c473e0b0","updated":"2017-03-27 21:39:03.000000000","message":"thanks\n\nlocal_address has no default, so this is not what we want","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":78,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $proxy_arp               \u003d false,"},{"line_number":80,"context_line":"  $purge_config            \u003d false,"},{"line_number":81,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_ba62693d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":51},"updated":"2017-03-25 07:46:01.000000000","message":"If the names of the neutron bridges (br-int, br-tun, br-ex...) are similarly tunable, then making it tunable for bagpipe-bgp makes sense.\n\nBut if this is not the case (?), then it would not.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"18339bcd0e6ef962d11ac1d2d1a64a1a2001f9ae","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":78,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $proxy_arp               \u003d false,"},{"line_number":80,"context_line":"  $purge_config            \u003d false,"},{"line_number":81,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_2648e22a","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":51},"in_reply_to":"ffe62b97_4c39d5d4","updated":"2017-03-29 15:22:35.000000000","message":"Alex has just explained that $::os_service_defaults results in emptying this part of the config, so we don\u0027t need anything more (\u0027br-mpls\u0027 is already the default)","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $my_as                   \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":78,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"},{"line_number":79,"context_line":"  $proxy_arp               \u003d false,"},{"line_number":80,"context_line":"  $purge_config            \u003d false,"},{"line_number":81,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_4c39d5d4","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":51},"in_reply_to":"ffe62b97_ba62693d","updated":"2017-03-29 11:31:50.000000000","message":"Do you want me to put br-mpls as default???","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  neutron_bgpvpn_bagpipe_config {"},{"line_number":91,"context_line":"    \u0027bgp/local_address\u0027:                       value \u003d\u003e $local_address;"},{"line_number":92,"context_line":"    \u0027bgp/peers\u0027:                               value \u003d\u003e join(any2array($peers), \u0027,\u0027);"},{"line_number":93,"context_line":"    \u0027bgp/my_as\u0027:                               value \u003d\u003e $my_as;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_5df6b7fb","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":33},"updated":"2017-03-25 07:46:01.000000000","message":"to control bagpipe-bgp OVS bridge configuration, we will need to drive the value of \u0027dataplane_driver_ipvpn/mpls_interface\u0027 as well\n\nanother parameter that it would be nice to be able to control is \"api/port\"  (it defaults to 8082 that collides for instance with skydive\u0027s default port, and might collide with other services)","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  neutron_bgpvpn_bagpipe_config {"},{"line_number":91,"context_line":"    \u0027bgp/local_address\u0027:                       value \u003d\u003e $local_address;"},{"line_number":92,"context_line":"    \u0027bgp/peers\u0027:                               value \u003d\u003e join(any2array($peers), \u0027,\u0027);"},{"line_number":93,"context_line":"    \u0027bgp/my_as\u0027:                               value \u003d\u003e $my_as;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_8c423d0e","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":33},"in_reply_to":"ffe62b97_5df6b7fb","updated":"2017-03-29 11:31:50.000000000","message":"Done","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7113f1bee37a42b8185aa4d006c84febe15d3bdc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#"},{"line_number":48,"context_line":"# [*my_as*]"},{"line_number":49,"context_line":"#   (required) Private Autonomous System number"},{"line_number":50,"context_line":"#   Defaults to 64512"},{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*enable_rtc*]"},{"line_number":53,"context_line":"#   Enable Route Target Constraint"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_a6d87252","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":21},"updated":"2017-03-29 15:25:05.000000000","message":"see below","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7113f1bee37a42b8185aa4d006c84febe15d3bdc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":79,"context_line":"  $enabled                 \u003d true,"},{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_261fc208","line":81,"range":{"start_line":81,"start_character":28,"end_line":81,"end_character":34},"updated":"2017-03-29 15:25:05.000000000","message":"8082 is already the default, so using $::os_service_default should be what we need.","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7113f1bee37a42b8185aa4d006c84febe15d3bdc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_66102a01","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":51},"updated":"2017-03-29 15:25:05.000000000","message":"This should be controlled by triple-o.","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a8cfbeb517c752925f3fda2fb6fa51f11eb24444","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_637c9171","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":51},"in_reply_to":"ffe62b97_29c9d557","updated":"2017-03-29 18:43:33.000000000","message":"if this value can be overriden by triple-o, then fine: the default, which is an empty string, is ok","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e729dd91925c164166812faf40530eaba49bf2cb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  $manage_service          \u003d true,"},{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_29c9d557","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":51},"in_reply_to":"ffe62b97_66102a01","updated":"2017-03-29 15:34:13.000000000","message":"It will be, what tripleo does is not part of this. We are only concerned about configuring the defaults for folks outside of tripleo.","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7113f1bee37a42b8185aa4d006c84febe15d3bdc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_a60ab2ce","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":35},"updated":"2017-03-29 15:25:05.000000000","message":"This one should actually not default to anything and be controlled via triple-o.","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a8cfbeb517c752925f3fda2fb6fa51f11eb24444","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_437f4d65","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":35},"in_reply_to":"ffe62b97_69e8fdb1","updated":"2017-03-29 18:43:33.000000000","message":"yes","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e729dd91925c164166812faf40530eaba49bf2cb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $api_port                \u003d 8082,"},{"line_number":82,"context_line":"  $local_address           \u003d $::ipaddress,"},{"line_number":83,"context_line":"  $peers                   \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $my_as                   \u003d 64512,"},{"line_number":85,"context_line":"  $enable_rtc              \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $dataplane_driver_ipvpn  \u003d \u0027ovs\u0027,"},{"line_number":87,"context_line":"  $ovs_bridge              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ffe62b97_69e8fdb1","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":35},"in_reply_to":"ffe62b97_a60ab2ce","updated":"2017-03-29 15:34:13.000000000","message":"You can make it required here by not providing a default (and it\u0027s probably a wise idea)","commit_id":"cb69320ed4d2f25f17711ee547d1fa4525fb1101"}],"manifests/config.pp":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   (optional) Manage configuration of api-paste.ini"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*bgpvpn_bagpipe_config*]"},{"line_number":31,"context_line":"#   (optional) Manage configuration of bgp.conf"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*bgpvpn_service_config*]"},{"line_number":34,"context_line":"#   (optional) Manage configuration of networking_bgpvpn.conf"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_7ad181cd","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":47},"updated":"2017-03-25 07:46:01.000000000","message":"could we say \"of bagpipe-bgp bgp.conf\" ?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   (optional) Manage configuration of api-paste.ini"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*bgpvpn_bagpipe_config*]"},{"line_number":31,"context_line":"#   (optional) Manage configuration of bgp.conf"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*bgpvpn_service_config*]"},{"line_number":34,"context_line":"#   (optional) Manage configuration of networking_bgpvpn.conf"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ffe62b97_4c71d575","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":47},"in_reply_to":"ffe62b97_7ad181cd","updated":"2017-03-29 11:31:50.000000000","message":"Done","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"}],"releasenotes/notes/bgpvpn-support-73886489d10d6301.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"677bdd2f50bca3bc5396fbc96cf0dd988c6c8770","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    BGP-based IP VPNs networks are widely used in the industry especially for"},{"line_number":4,"context_line":"    enterprises. This project aims at supporting inter-connection between"},{"line_number":5,"context_line":"    L3VPNs and Neutron resources, i.e. Networks, Routers and Ports."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_84c15883","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2017-03-27 14:51:50.000000000","message":"actually don\u0027t use prelude because that gets added to the release notes prelude. This should just be part of the features","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    BGP-based IP VPNs networks are widely used in the industry especially for"},{"line_number":4,"context_line":"    enterprises. This project aims at supporting inter-connection between"},{"line_number":5,"context_line":"    L3VPNs and Neutron resources, i.e. Networks, Routers and Ports."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_ec0789c9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"ffe62b97_84c15883","updated":"2017-03-29 11:31:50.000000000","message":"Done","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    BGP-based IP VPNs networks are widely used in the industry especially for"},{"line_number":4,"context_line":"    enterprises. This project aims at supporting inter-connection between"},{"line_number":5,"context_line":"    L3VPNs and Neutron resources, i.e. Networks, Routers and Ports."},{"line_number":6,"context_line":"features:"},{"line_number":7,"context_line":"  - Add support for BGPVPN Neutron service plugin"},{"line_number":8,"context_line":"  - Add new type for BGPVPN Service config"},{"line_number":9,"context_line":"  - Add new provider for BGPVPN Service config"},{"line_number":10,"context_line":"  - Add Bagpipe agent as reference driver"},{"line_number":11,"context_line":"  - Add new type for Bagpipe driver"},{"line_number":12,"context_line":"  - Add new provider for Bagpipe driver"},{"line_number":13,"context_line":"  - Add spec and unit tests"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffe62b97_fafd913a","line":13,"range":{"start_line":1,"start_character":0,"end_line":13,"end_character":27},"updated":"2017-03-25 07:46:01.000000000","message":"not sure what the practice is in puppet-neutron, but I would have expected something perhaps simpler: only keeping the first paragraph, and perhaps not making it a prelude, but simply a feature among others","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"}],"spec/unit/type/neutron_bgpvpn_bagpipe_config_spec.rb":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0777a8484ce5f16b00855252ac1299f2e8651045","unresolved":false,"context_lines":[{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:neutron_bgpvpn_bagpipe_config)\u0027 do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  before :each do"},{"line_number":7,"context_line":"    @neutron_bgpvpn_bagpipe_config \u003d Puppet::Type.type(:neutron_bgpvpn_bagpipe_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  it \u0027should autorequire the package that install the file\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_9d2b1f81","line":7,"range":{"start_line":7,"start_character":91,"end_line":7,"end_character":131},"updated":"2017-03-25 07:46:01.000000000","message":"(Forgive my puppet ignorance: perhaps the question is dumb...)\n\nIs this work in progress/unfinished ?\nIf not, why \u0027foo\u0027/\u0027bar\u0027 ?","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"44ebe0bc5f964f0d10b6c761c46aa70eb8f8bf62","unresolved":false,"context_lines":[{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:neutron_bgpvpn_bagpipe_config)\u0027 do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  before :each do"},{"line_number":7,"context_line":"    @neutron_bgpvpn_bagpipe_config \u003d Puppet::Type.type(:neutron_bgpvpn_bagpipe_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  it \u0027should autorequire the package that install the file\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_4c1f9507","line":7,"range":{"start_line":7,"start_character":91,"end_line":7,"end_character":131},"in_reply_to":"ffe62b97_26295e9a","updated":"2017-03-29 11:31:50.000000000","message":"All the files located in the spec folder are kind of unit tests. For each new provider, type and manifest, an spec test must be included.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"18339bcd0e6ef962d11ac1d2d1a64a1a2001f9ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:neutron_bgpvpn_bagpipe_config)\u0027 do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  before :each do"},{"line_number":7,"context_line":"    @neutron_bgpvpn_bagpipe_config \u003d Puppet::Type.type(:neutron_bgpvpn_bagpipe_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  it \u0027should autorequire the package that install the file\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_26e4620c","line":7,"range":{"start_line":7,"start_character":91,"end_line":7,"end_character":131},"in_reply_to":"ffe62b97_4c1f9507","updated":"2017-03-29 15:22:35.000000000","message":"Ack.","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"677bdd2f50bca3bc5396fbc96cf0dd988c6c8770","unresolved":false,"context_lines":[{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:neutron_bgpvpn_bagpipe_config)\u0027 do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  before :each do"},{"line_number":7,"context_line":"    @neutron_bgpvpn_bagpipe_config \u003d Puppet::Type.type(:neutron_bgpvpn_bagpipe_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  it \u0027should autorequire the package that install the file\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_a4745c69","line":7,"range":{"start_line":7,"start_character":91,"end_line":7,"end_character":131},"in_reply_to":"ffe62b97_9d2b1f81","updated":"2017-03-27 14:51:50.000000000","message":"this is just test dummy data so it doesn\u0027t matter. It\u0027s to create a config file for the test","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"64b44e280a251f30c25a7b93d2edd63dac4924ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:neutron_bgpvpn_bagpipe_config)\u0027 do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  before :each do"},{"line_number":7,"context_line":"    @neutron_bgpvpn_bagpipe_config \u003d Puppet::Type.type(:neutron_bgpvpn_bagpipe_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  it \u0027should autorequire the package that install the file\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ffe62b97_26295e9a","line":7,"range":{"start_line":7,"start_character":91,"end_line":7,"end_character":131},"in_reply_to":"ffe62b97_a4745c69","updated":"2017-03-27 21:39:03.000000000","message":"Sorry, I hadn\u0027t seen this was a test..","commit_id":"fede9bfe695ad39a3607b903a6710212f07b039e"}]}
