)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11d2a06cfef7ad0ebc67441b707b4aced63299d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add class to support VMware nsx_v3 plugin."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The plaugin will make use of neutron.conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will have a section [nsx_v3]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_a27550cd","line":11,"updated":"2017-04-10 09:57:59.000000000","message":"plugin","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11d2a06cfef7ad0ebc67441b707b4aced63299d8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add class to support VMware nsx_v3 plugin."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The plaugin will make use of neutron.conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will have a section [nsx_v3]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2c378acdc6b11e431edea27bba00bb815b79623c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_424e8497","line":12,"updated":"2017-04-10 09:57:59.000000000","message":"also, it\u0027s the first time a plugin use neutron.conf, not sure that\u0027s the best idea...","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff5c286cf89ad1580f23501ad77ce86840377997","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add class to support VMware nsx_v3 plugin."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The plaugin will make use of neutron.conf."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will have a section [nsx_v3]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2c378acdc6b11e431edea27bba00bb815b79623c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"bff0334d_c8619507","line":12,"in_reply_to":"bff0334d_424e8497","updated":"2017-04-10 10:51:46.000000000","message":"Done","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"}],"manifests/plugins/nsx.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11d2a06cfef7ad0ebc67441b707b4aced63299d8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  neutron_plugin_nsx {"},{"line_number":86,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:   value \u003d\u003e $default_overlay_tz;"},{"line_number":87,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027: value \u003d\u003e $default_tier0_router;"},{"line_number":88,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:     value \u003d\u003e $nsx_api_managers;"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"bff0334d_223820ed","line":85,"updated":"2017-04-10 09:57:59.000000000","message":"you don\u0027t need neutron_plugin_nsx if you use neutron.conf, just use neutron_config provider","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff5c286cf89ad1580f23501ad77ce86840377997","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  neutron_plugin_nsx {"},{"line_number":86,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:   value \u003d\u003e $default_overlay_tz;"},{"line_number":87,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027: value \u003d\u003e $default_tier0_router;"},{"line_number":88,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:     value \u003d\u003e $nsx_api_managers;"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"bff0334d_e848d987","line":85,"in_reply_to":"bff0334d_223820ed","updated":"2017-04-10 10:51:46.000000000","message":"Done","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5ce4f2d210104feec36eb47e833cbfc3c450794b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    file_line { \u0027/etc/default/neutron-server:NEUTRON_PLUGIN_CONFIG\u0027:"},{"line_number":66,"context_line":"      path  \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":67,"context_line":"      match \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":68,"context_line":"      line  \u003d\u003e \"NEUTRON_PLUGIN_CONFIG\u003d${::neutron::params::vmware_config_file}\","},{"line_number":69,"context_line":"      tag   \u003d\u003e \u0027neutron-file-line\u0027,"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"bff0334d_e5856908","line":68,"range":{"start_line":68,"start_character":40,"end_line":68,"end_character":77},"updated":"2017-04-11 17:12:12.000000000","message":"btw this is ::neutron::params::nsx_config_file","commit_id":"3f1571b78568cb9a2f7ef6e2d1ac94eff4988b5b"}],"manifests/plugins/nsx_v3.pp":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e86f2129e51d218d66900f71925d0dfd1a68a330","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# [*native_dhcp_metadata*]"},{"line_number":32,"context_line":"#   Flag to enable native DHCP and Metadata."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*native_metadata_route*]"},{"line_number":35,"context_line":"#   Default Metadata route. This option is optional."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dfeb2761_bc95c5e6","line":34,"updated":"2017-04-02 05:51:13.000000000","message":"i do not think that we need this option","commit_id":"02bf0070419a82fe32e4d8e5fb0d98b949c92ef9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e86f2129e51d218d66900f71925d0dfd1a68a330","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $nsx_api_user,"},{"line_number":51,"context_line":"  $nsx_api_password,"},{"line_number":52,"context_line":"  $dhcp_profile_uuid,"},{"line_number":53,"context_line":"  $metadata_proxy_uuid,     "},{"line_number":54,"context_line":"  $native_dhcp_metadat,     \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $native_metadata_route    \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $package_ensure           \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dfeb2761_3c04154a","line":53,"updated":"2017-04-02 05:51:13.000000000","message":"whitespace","commit_id":"02bf0070419a82fe32e4d8e5fb0d98b949c92ef9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e86f2129e51d218d66900f71925d0dfd1a68a330","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \u0027nsx_v3/dhcp_profile_uuid\u0027:             value \u003d\u003e $dhcp_profile_uuid;"},{"line_number":95,"context_line":"    \u0027nsx_v3/metadata_proxy_uuid\u0027:           value \u003d\u003e $metadata_proxy_uuid;"},{"line_number":96,"context_line":"    \u0027nsx_v3/native_dhcp_metadata\u0027:          value \u003d\u003e $native_dhcp_metadata;"},{"line_number":97,"context_line":"    \u0027nsx_v3/native_metadata_route\u0027:         value \u003d\u003e $native_metadata_route;"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  if $::neutron::core_plugin !\u003d \u0027vmware_nsx.plugin.NsxV3Plugin\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dfeb2761_dcf8894a","line":97,"updated":"2017-04-02 05:51:13.000000000","message":"i do not think that we need this variable - this is only for very old guests","commit_id":"02bf0070419a82fe32e4d8e5fb0d98b949c92ef9"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"11570b98a0dc58642e60319358ed75afae33f713","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $nsx_api_password,"},{"line_number":49,"context_line":"  $dhcp_profile_uuid,"},{"line_number":50,"context_line":"  $metadata_proxy_uuid,"},{"line_number":51,"context_line":"  $native_dhcp_metadata     \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $package_ensure           \u003d \u0027present\u0027,"},{"line_number":53,"context_line":"  $purge_config             \u003d false,"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dfeb2761_71e75b14","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":36},"updated":"2017-04-03 07:48:38.000000000","message":"alignment, please align by 1 space from the longest parameter","commit_id":"4989cd3793ad9f28aa921bc165d5df796ae6cf80"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"26186256e6d26eada92132842d0b9386efd6c04f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  $nsx_api_password,"},{"line_number":49,"context_line":"  $dhcp_profile_uuid,"},{"line_number":50,"context_line":"  $metadata_proxy_uuid,"},{"line_number":51,"context_line":"  $native_dhcp_metadata     \u003d $::os_service_default,"},{"line_number":52,"context_line":"  $package_ensure           \u003d \u0027present\u0027,"},{"line_number":53,"context_line":"  $purge_config             \u003d false,"},{"line_number":54,"context_line":") {"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dfeb2761_b15cc37e","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":36},"in_reply_to":"dfeb2761_71e75b14","updated":"2017-04-03 07:55:50.000000000","message":"Done","commit_id":"4989cd3793ad9f28aa921bc165d5df796ae6cf80"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"11570b98a0dc58642e60319358ed75afae33f713","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  neutron_plugin_nsxv3 {"},{"line_number":93,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:            value \u003d\u003e $default_overlay_tz;"},{"line_number":94,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027:          value \u003d\u003e $default_tier0_router;"},{"line_number":95,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:              value \u003d\u003e $nsx_api_managers;"},{"line_number":96,"context_line":"    \u0027nsx_v3/nsx_api_user\u0027:                  value \u003d\u003e $nsx_api_user;"},{"line_number":97,"context_line":"    \u0027nsx_v3/nsx_api_password\u0027:              value \u003d\u003e $nsx_api_password;"},{"line_number":98,"context_line":"    \u0027nsx_v3/dhcp_profile_uuid\u0027:             value \u003d\u003e $dhcp_profile_uuid;"},{"line_number":99,"context_line":"    \u0027nsx_v3/metadata_proxy_uuid\u0027:           value \u003d\u003e $metadata_proxy_uuid;"},{"line_number":100,"context_line":"    \u0027nsx_v3/native_dhcp_metadata\u0027:          value \u003d\u003e $native_dhcp_metadata;"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if $::neutron::core_plugin !\u003d \u0027vmware_nsx.plugin.NsxV3Plugin\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dfeb2761_11ec8ff1","line":100,"range":{"start_line":93,"start_character":0,"end_line":100,"end_character":75},"updated":"2017-04-03 07:48:38.000000000","message":"alignment, same here","commit_id":"4989cd3793ad9f28aa921bc165d5df796ae6cf80"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"26186256e6d26eada92132842d0b9386efd6c04f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  neutron_plugin_nsxv3 {"},{"line_number":93,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:            value \u003d\u003e $default_overlay_tz;"},{"line_number":94,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027:          value \u003d\u003e $default_tier0_router;"},{"line_number":95,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:              value \u003d\u003e $nsx_api_managers;"},{"line_number":96,"context_line":"    \u0027nsx_v3/nsx_api_user\u0027:                  value \u003d\u003e $nsx_api_user;"},{"line_number":97,"context_line":"    \u0027nsx_v3/nsx_api_password\u0027:              value \u003d\u003e $nsx_api_password;"},{"line_number":98,"context_line":"    \u0027nsx_v3/dhcp_profile_uuid\u0027:             value \u003d\u003e $dhcp_profile_uuid;"},{"line_number":99,"context_line":"    \u0027nsx_v3/metadata_proxy_uuid\u0027:           value \u003d\u003e $metadata_proxy_uuid;"},{"line_number":100,"context_line":"    \u0027nsx_v3/native_dhcp_metadata\u0027:          value \u003d\u003e $native_dhcp_metadata;"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  if $::neutron::core_plugin !\u003d \u0027vmware_nsx.plugin.NsxV3Plugin\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dfeb2761_114b6fb0","line":100,"range":{"start_line":93,"start_character":0,"end_line":100,"end_character":75},"in_reply_to":"dfeb2761_11ec8ff1","updated":"2017-04-03 07:55:50.000000000","message":"Done","commit_id":"4989cd3793ad9f28aa921bc165d5df796ae6cf80"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ef4b9a91b5e9891ce45df2a5888d39e9b33da472","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  include ::neutron::deps"},{"line_number":57,"context_line":"  include ::neutron::params"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/vmware\u0027, {"},{"line_number":60,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":61,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":62,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dfeb2761_be8914cb","line":59,"updated":"2017-04-03 19:24:49.000000000","message":"this should be managed by packaging, not puppet.","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f86481cc492b9756daff14f199524e65a4a04ce8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  include ::neutron::deps"},{"line_number":57,"context_line":"  include ::neutron::params"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/vmware\u0027, {"},{"line_number":60,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":61,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":62,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_b6cec02a","line":59,"in_reply_to":"bff0334d_2dadfd30","updated":"2017-04-09 09:11:43.000000000","message":"thanks, addressing those.","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c27785fc7f44ac95534047453c5ed9ab98ffa755","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  include ::neutron::deps"},{"line_number":57,"context_line":"  include ::neutron::params"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/vmware\u0027, {"},{"line_number":60,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":61,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":62,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_2dadfd30","line":59,"in_reply_to":"dfeb2761_42f45986","updated":"2017-04-06 21:52:46.000000000","message":"Yea it is but if possible this should be managed via the packaging and not here.  The missing tests are the limiting factor on merging this as is.","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ba9c1ad2e779f83cfe475b99ee994304f833a02d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  include ::neutron::deps"},{"line_number":57,"context_line":"  include ::neutron::params"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  ensure_resource(\u0027file\u0027, \u0027/etc/neutron/plugins/vmware\u0027, {"},{"line_number":60,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":61,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":62,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dfeb2761_42f45986","line":59,"in_reply_to":"dfeb2761_be8914cb","updated":"2017-04-04 09:28:47.000000000","message":"this seems to be the same pattern with all of the other plugins. please advise\nPlease see - https://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/plumgrid.pp#L122\nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/midonet.pp#L129","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c27785fc7f44ac95534047453c5ed9ab98ffa755","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  neutron_plugin_nsxv3 {"},{"line_number":93,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:   value \u003d\u003e $default_overlay_tz;"},{"line_number":94,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027: value \u003d\u003e $default_tier0_router;"},{"line_number":95,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:     value \u003d\u003e $nsx_api_managers;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_2d729de4","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":22},"updated":"2017-04-06 21:52:46.000000000","message":"this provider does not exist and needs to be created","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f86481cc492b9756daff14f199524e65a4a04ce8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  neutron_plugin_nsxv3 {"},{"line_number":93,"context_line":"    \u0027nsx_v3/default_overlay_tz\u0027:   value \u003d\u003e $default_overlay_tz;"},{"line_number":94,"context_line":"    \u0027nsx_v3/default_tier0_router\u0027: value \u003d\u003e $default_tier0_router;"},{"line_number":95,"context_line":"    \u0027nsx_v3/nsx_api_managers\u0027:     value \u003d\u003e $nsx_api_managers;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_96d3bcd5","line":92,"range":{"start_line":92,"start_character":2,"end_line":92,"end_character":22},"in_reply_to":"bff0334d_2d729de4","updated":"2017-04-09 09:11:43.000000000","message":"Done (I hope that I have understood the change correctly)","commit_id":"d84368324c4103c21f943ca0c14e50b27f0d9768"}],"releasenotes/notes/nsx-support-1254839718d8df8c.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11d2a06cfef7ad0ebc67441b707b4aced63299d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Add support for the VMware NSX plugin. This is supported from the"},{"line_number":4,"context_line":"  Neutron verion Mitaka onwards."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Add support to deploy VMware NSX plugin."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bff0334d_452a0e7f","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":32},"updated":"2017-04-10 09:57:59.000000000","message":"remove the prelude, we don\u0027t want NSX in a release note prelude.","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff5c286cf89ad1580f23501ad77ce86840377997","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Add support for the VMware NSX plugin. This is supported from the"},{"line_number":4,"context_line":"  Neutron verion Mitaka onwards."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Add support to deploy VMware NSX plugin."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bff0334d_086bfdf0","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":32},"in_reply_to":"bff0334d_452a0e7f","updated":"2017-04-10 10:51:46.000000000","message":"Done","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"}],"spec/classes/neutron_plugins_nsx_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11d2a06cfef7ad0ebc67441b707b4aced63299d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      password \u003d\u003e \u0027passw0rd\u0027,"},{"line_number":8,"context_line":"     }"},{"line_number":9,"context_line":"     class { \u0027neutron::server\u0027: }"},{"line_number":10,"context_line":"     class { \u0027neutron\u0027: rabbit_password \u003d\u003e \u0027passw0rd\u0027 }\""},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  let :default_params do"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"bff0334d_4501ee04","line":10,"updated":"2017-04-10 09:57:59.000000000","message":"you didn\u0027t specify core_plugin     \u003d\u003e \u0027vmware_nsx.plugin.NsxV3Plugin\u0027","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff5c286cf89ad1580f23501ad77ce86840377997","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      password \u003d\u003e \u0027passw0rd\u0027,"},{"line_number":8,"context_line":"     }"},{"line_number":9,"context_line":"     class { \u0027neutron::server\u0027: }"},{"line_number":10,"context_line":"     class { \u0027neutron\u0027: rabbit_password \u003d\u003e \u0027passw0rd\u0027 }\""},{"line_number":11,"context_line":"  end"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  let :default_params do"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"bff0334d_68a60956","line":10,"in_reply_to":"bff0334d_4501ee04","updated":"2017-04-10 10:51:46.000000000","message":"Done","commit_id":"8b6f0c3cad22ae539095ef72aba7d3a13faf947f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"47a204cc7a09ccbc5cb0bff6ee5824ab9de209c1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      it_raises \u0027a Puppet::Error\u0027, /NSX plugin should be the core_plugin in neutron.conf/"},{"line_number":76,"context_line":"    end"},{"line_number":77,"context_line":"  end"},{"line_number":78,"context_line":"  begin"},{"line_number":79,"context_line":"    context \u0027on Debian platforms\u0027 do"},{"line_number":80,"context_line":"      let :facts do"},{"line_number":81,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":82,"context_line":"           :osfamily \u003d\u003e \u0027Debian\u0027"},{"line_number":83,"context_line":"        }))"},{"line_number":84,"context_line":"      end"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"      it_configures \u0027neutron plugin nsx\u0027"},{"line_number":87,"context_line":"    end"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    context \u0027on RedHat platforms\u0027 do"},{"line_number":90,"context_line":"      let :facts do"},{"line_number":91,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":92,"context_line":"           :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":93,"context_line":"           :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":94,"context_line":"        }))"},{"line_number":95,"context_line":"      end"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"      it_configures \u0027neutron plugin nsx\u0027"},{"line_number":98,"context_line":"    end"},{"line_number":99,"context_line":"  end"},{"line_number":100,"context_line":"  begin"},{"line_number":101,"context_line":"    context \u0027on Debian platforms\u0027 do"},{"line_number":102,"context_line":"      let :facts do"},{"line_number":103,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":104,"context_line":"           :osfamily \u003d\u003e \u0027Debian\u0027"},{"line_number":105,"context_line":"        }))"},{"line_number":106,"context_line":"      end"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"      it \u0027configures /etc/default/neutron-server\u0027 do"},{"line_number":109,"context_line":"        is_expected.to contain_file_line(\u0027/etc/default/neutron-server:NEUTRON_PLUGIN_CONFIG\u0027).with("},{"line_number":110,"context_line":"          :path    \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":111,"context_line":"          :match   \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":112,"context_line":"          :line    \u003d\u003e \u0027NEUTRON_PLUGIN_CONFIG\u003d/etc/neutron/plugins/vmware/nsx.ini\u0027,"},{"line_number":113,"context_line":"        )"},{"line_number":114,"context_line":"        is_expected.to contain_file_line(\u0027/etc/default/neutron-server:NEUTRON_PLUGIN_CONFIG\u0027).that_requires(\u0027Anchor[neutron::config::begin]\u0027)"},{"line_number":115,"context_line":"        is_expected.to contain_file_line(\u0027/etc/default/neutron-server:NEUTRON_PLUGIN_CONFIG\u0027).that_notifies(\u0027Anchor[neutron::config::end]\u0027)"},{"line_number":116,"context_line":"      end"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"      it_configures \u0027neutron plugin nsx\u0027"},{"line_number":119,"context_line":"    end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    context \u0027on RedHat platforms\u0027 do"},{"line_number":122,"context_line":"      let :facts do"},{"line_number":123,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":124,"context_line":"           :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":125,"context_line":"           :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":126,"context_line":"        }))"},{"line_number":127,"context_line":"      end"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"      it \u0027should create plugin symbolic link\u0027 do"},{"line_number":130,"context_line":"        is_expected.to contain_file(\u0027/etc/neutron/plugin.ini\u0027).with("},{"line_number":131,"context_line":"          :ensure  \u003d\u003e \u0027link\u0027,"},{"line_number":132,"context_line":"          :target  \u003d\u003e \u0027/etc/neutron/plugins/vmware/nsx.ini\u0027)"},{"line_number":133,"context_line":"      end"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      it_configures \u0027neutron plugin nsx\u0027"},{"line_number":136,"context_line":"    end"},{"line_number":137,"context_line":"  end"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"bff0334d_8e8f0a74","line":137,"range":{"start_line":78,"start_character":0,"end_line":137,"end_character":5},"updated":"2017-04-10 15:52:59.000000000","message":"Please switch to us on_supported_os(...). Additionally to do platform specific tests you should create a set of shared examples for this.  As an example take a look at the neutron_agents_ml2_ovs_spec.rb. https://github.com/openstack/puppet-neutron/blob/master/spec/classes/neutron_agents_ml2_ovs_spec.rb#L297-L350","commit_id":"979b8d16e941a451a0848696aebcd247aacf3d9c"}]}
