)]}'
{"manifests/server.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"908e0d8be009c25834fcb27e7ff6b96e7faf5206","unresolved":false,"context_lines":[{"line_number":417,"context_line":"  if $service_name \u003d\u003d $::neutron::params::server_service {"},{"line_number":418,"context_line":"    service { \u0027neutron-server\u0027:"},{"line_number":419,"context_line":"      ensure     \u003d\u003e $service_ensure,"},{"line_number":420,"context_line":"      name       \u003d\u003e $::neutron::params::server_service,"},{"line_number":421,"context_line":"      enable     \u003d\u003e $enabled,"},{"line_number":422,"context_line":"      hasstatus  \u003d\u003e true,"},{"line_number":423,"context_line":"      hasrestart \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f044301_5441e938","line":420,"range":{"start_line":420,"start_character":20,"end_line":420,"end_character":53},"updated":"2017-05-05 22:21:54.000000000","message":"Why can\u0027t we still support $service_name? It would just be an if $service_name \u003d\u003d \u0027httpd\u0027 { ... } else { ... } and we not fail for anything else.","commit_id":"4e99acf08bd87c6fabd01c85d6c33c7b05013780"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"541f9387f66e8964843700199f048f1d69e28d5c","unresolved":false,"context_lines":[{"line_number":417,"context_line":"  if $service_name \u003d\u003d $::neutron::params::server_service {"},{"line_number":418,"context_line":"    service { \u0027neutron-server\u0027:"},{"line_number":419,"context_line":"      ensure     \u003d\u003e $service_ensure,"},{"line_number":420,"context_line":"      name       \u003d\u003e $::neutron::params::server_service,"},{"line_number":421,"context_line":"      enable     \u003d\u003e $enabled,"},{"line_number":422,"context_line":"      hasstatus  \u003d\u003e true,"},{"line_number":423,"context_line":"      hasrestart \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f044301_c02e4ca4","line":420,"range":{"start_line":420,"start_character":20,"end_line":420,"end_character":53},"in_reply_to":"3f044301_0cdd956f","updated":"2017-05-07 19:23:29.000000000","message":"I guess it\u0027s a question for people not using the rdo/uca packaging.  Perhaps throw a warning and deprecate it correctly for Queens","commit_id":"4e99acf08bd87c6fabd01c85d6c33c7b05013780"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea0fb6c930e6ce42aa9c4f6f7791bd9e828a9b61","unresolved":false,"context_lines":[{"line_number":417,"context_line":"  if $service_name \u003d\u003d $::neutron::params::server_service {"},{"line_number":418,"context_line":"    service { \u0027neutron-server\u0027:"},{"line_number":419,"context_line":"      ensure     \u003d\u003e $service_ensure,"},{"line_number":420,"context_line":"      name       \u003d\u003e $::neutron::params::server_service,"},{"line_number":421,"context_line":"      enable     \u003d\u003e $enabled,"},{"line_number":422,"context_line":"      hasstatus  \u003d\u003e true,"},{"line_number":423,"context_line":"      hasrestart \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f044301_0cdd956f","line":420,"range":{"start_line":420,"start_character":20,"end_line":420,"end_character":53},"in_reply_to":"3f044301_5441e938","updated":"2017-05-07 03:08:22.000000000","message":"I could do that. This pattern followed what we do in other modules: https://github.com/openstack/puppet-nova/blob/master/manifests/api.pp#L412\n\nI\u0027m happy to follow your suggestion, it just won\u0027t be consistent with other modules. Let me know (I don\u0027t have strong opinion).","commit_id":"4e99acf08bd87c6fabd01c85d6c33c7b05013780"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4372baf40df35ef9fcb6b55480c82d9e3683bd7e","unresolved":false,"context_lines":[{"line_number":417,"context_line":"  if $service_name \u003d\u003d $::neutron::params::server_service {"},{"line_number":418,"context_line":"    service { \u0027neutron-server\u0027:"},{"line_number":419,"context_line":"      ensure     \u003d\u003e $service_ensure,"},{"line_number":420,"context_line":"      name       \u003d\u003e $::neutron::params::server_service,"},{"line_number":421,"context_line":"      enable     \u003d\u003e $enabled,"},{"line_number":422,"context_line":"      hasstatus  \u003d\u003e true,"},{"line_number":423,"context_line":"      hasrestart \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"ff0f0b1f_cf70480b","line":420,"range":{"start_line":420,"start_character":20,"end_line":420,"end_character":53},"in_reply_to":"3f044301_c02e4ca4","updated":"2017-05-23 20:13:52.000000000","message":"Done","commit_id":"4e99acf08bd87c6fabd01c85d6c33c7b05013780"}]}