)]}'
{"manifests/plugins/ovs/opendaylight.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5888b9c039c58f73e71b7713843d477a8d04ca33","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class neutron::plugins::ovs::opendaylight ("},{"line_number":45,"context_line":"  $tunnel_ip,"},{"line_number":46,"context_line":"  $odl_username       \u003d hiera(\u0027opendaylight::username\u0027),"},{"line_number":47,"context_line":"  $odl_password       \u003d hiera(\u0027opendaylight::password\u0027),"},{"line_number":48,"context_line":"  $odl_check_url      \u003d \u0027http://127.0.0.1:8080/restconf/operational/network-topology:network-topology/topology/netvirt:1\u0027,"},{"line_number":49,"context_line":"  $odl_ovsdb_iface    \u003d \u0027tcp:127.0.0.1:6640\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f1d235d_a52b0593","line":46,"updated":"2017-07-05 14:00:29.000000000","message":"I think usernames and passwords should be required parameters without default values, for security purpose.\n\nAlso, don\u0027t forget to update the doc in the headers to reflect this change, and also the unit tests.\nNote that we don\u0027t force our users to use Hiera, so we wouldn\u0027t have accepted this kind of change anyway.\n\nMake the params required without default value and we\u0027re good. Also add a release note and write tests.","commit_id":"f0e5eb0a1da53888ef079c169d232cfaf28bd8df"}]}