)]}'
{"lib/puppet/provider/neutron_sfc_service_config/openstackconfig.rb":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_sfc_service_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df3967d1_733aae34","line":1,"updated":"2017-08-02 10:23:22.000000000","message":"does that ensure /etc/neutron/networking_sfc.conf is added to the configuration files for neutron-server?","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c78e4c7cad0a508ef04daa99c175e83cf60daf2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_sfc_service_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df3967d1_e8b9bc14","line":1,"in_reply_to":"df3967d1_733aae34","updated":"2017-08-04 08:39:44.000000000","message":"Nope, starting the neutron server with the sfc config file must be done in the RPM spec file via a symlink:\n\nhttps://github.com/rdo-packages/networking-l2gw-distgit/blob/rpm-master/python-networking-l2gw.spec#L126","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c6d0f68473f7a61aefec425526d095627aa5d3fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_sfc_service_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df3967d1_68edc3b5","line":1,"in_reply_to":"df3967d1_e8b9bc14","updated":"2017-08-04 14:44:36.000000000","message":"Ack, let\u0027s see how this review goes:\nhttps://review.rdoproject.org/r/#/c/8189/","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e66ef5422307c72f0eadf8058ba99e45d6972bfa","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/networking_sfc.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9f436f4f_84988a6a","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":37},"updated":"2017-08-08 13:48:21.000000000","message":"Spec file review is still in progress, but this will most probably be \u0027/etc/neutron/conf.d/neutron-server/networking-sfc.conf\u0027","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"}],"manifests/config.pp":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   (optional) Manage configuration of l2gw_plugin.ini"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*sfc_service_config*]"},{"line_number":43,"context_line":"#   (optional) Manage configuration of networking_bgpvpn.conf"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*l3_agent_config*]"},{"line_number":46,"context_line":"#   (optional) Manage configuration of l3_agent.ini"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_33a8a675","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":56},"updated":"2017-08-02 10:23:22.000000000","message":"sfc :)","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c78e4c7cad0a508ef04daa99c175e83cf60daf2a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   (optional) Manage configuration of l2gw_plugin.ini"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*sfc_service_config*]"},{"line_number":43,"context_line":"#   (optional) Manage configuration of networking_bgpvpn.conf"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*l3_agent_config*]"},{"line_number":46,"context_line":"#   (optional) Manage configuration of l3_agent.ini"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_e8677cb6","line":43,"range":{"start_line":43,"start_character":50,"end_line":43,"end_character":56},"in_reply_to":"df3967d1_33a8a675","updated":"2017-08-04 08:39:44.000000000","message":"I\u0027m flattered by this! :-P","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  $bgpvpn_service_config         \u003d {},"},{"line_number":104,"context_line":"  $l2gw_agent_config             \u003d {},"},{"line_number":105,"context_line":"  $l2gw_service_config           \u003d {},"},{"line_number":106,"context_line":"  $sfc_service_config         \u003d {},"},{"line_number":107,"context_line":"  $l3_agent_config               \u003d {},"},{"line_number":108,"context_line":"  $dhcp_agent_config             \u003d {},"},{"line_number":109,"context_line":"  $lbaas_agent_config            \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_13b922cb","line":106,"updated":"2017-08-02 10:23:22.000000000","message":"indentation","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"}],"manifests/params.pp":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $bgpvpn_bagpipe_package      \u003d \u0027python-networking-bagpipe\u0027"},{"line_number":34,"context_line":"  $bgpvpn_bagpipe_service      \u003d \u0027bagpipe-bgp\u0027"},{"line_number":35,"context_line":"  $bgpvpn_plugin_package       \u003d \u0027python-networking-bgpvpn\u0027"},{"line_number":36,"context_line":"  $sfc_package          \u003d \u0027python-networking-sfc\u0027"},{"line_number":37,"context_line":"  $l2gw_agent_service          \u003d \u0027neutron-l2gw-agent\u0027"},{"line_number":38,"context_line":"  $nsx_plugin_package          \u003d \u0027vmware-nsx\u0027"},{"line_number":39,"context_line":"  $nsx_config_file             \u003d \u0027/etc/neutron/plugins/vmware/nsx.ini\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_f3bb3ec1","line":36,"updated":"2017-08-02 10:23:22.000000000","message":"indentation","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"}],"manifests/services/sfc.pp":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*package_ensure*]"},{"line_number":25,"context_line":"#   Whether to install the bgpvpn service package"},{"line_number":26,"context_line":"#   Default to \u0027present\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*sfc_driver*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_7323ce06","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":33},"updated":"2017-08-02 10:23:22.000000000","message":"sfc :)","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c78e4c7cad0a508ef04daa99c175e83cf60daf2a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*package_ensure*]"},{"line_number":25,"context_line":"#   Whether to install the bgpvpn service package"},{"line_number":26,"context_line":"#   Default to \u0027present\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*sfc_driver*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_8825905e","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":33},"in_reply_to":"df3967d1_7323ce06","updated":"2017-08-04 08:39:44.000000000","message":":-D","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  neutron_config {"},{"line_number":72,"context_line":"    \u0027sfc/drivers\u0027:            value \u003d\u003e $sfc_driver;"},{"line_number":73,"context_line":"    \u0027flowclassifier/drivers\u0027: value \u003d\u003e $fc_driver;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $sync_db {"},{"line_number":77,"context_line":"    Package\u003c| title \u003d\u003d $::neutron::params::sfc_package |\u003e ~\u003e Exec[\u0027sfc-db-sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_1315a29c","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":3},"updated":"2017-08-02 10:23:22.000000000","message":"if neutron-server also reads /etc/neutron/networking_sfc.conf, this probably should not be duplicated here","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e66ef5422307c72f0eadf8058ba99e45d6972bfa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  neutron_config {"},{"line_number":72,"context_line":"    \u0027sfc/drivers\u0027:            value \u003d\u003e $sfc_driver;"},{"line_number":73,"context_line":"    \u0027flowclassifier/drivers\u0027: value \u003d\u003e $fc_driver;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $sync_db {"},{"line_number":77,"context_line":"    Package\u003c| title \u003d\u003d $::neutron::params::sfc_package |\u003e ~\u003e Exec[\u0027sfc-db-sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_8483ea04","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":3},"in_reply_to":"df3967d1_1315a29c","updated":"2017-08-08 13:48:21.000000000","message":"Confirming, with the upcoming spec change neutron_sfc_service_config will be the one to keep","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  if $sync_db {"},{"line_number":77,"context_line":"    Package\u003c| title \u003d\u003d $::neutron::params::sfc_package |\u003e ~\u003e Exec[\u0027sfc-db-sync\u0027]"},{"line_number":78,"context_line":"    exec { \u0027sfc-db-sync\u0027:"},{"line_number":79,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage --config-file /etc/neutron/neutron.conf --subproject networking-sfc upgrade head\u0027,"},{"line_number":80,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":81,"context_line":"      subscribe   \u003d\u003e ["},{"line_number":82,"context_line":"        Anchor[\u0027neutron::install::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_932872e2","line":79,"updated":"2017-08-02 10:23:22.000000000","message":"need to pass --config-file /etc/neutron/networking_sfc.conf too?","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c78e4c7cad0a508ef04daa99c175e83cf60daf2a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  if $sync_db {"},{"line_number":77,"context_line":"    Package\u003c| title \u003d\u003d $::neutron::params::sfc_package |\u003e ~\u003e Exec[\u0027sfc-db-sync\u0027]"},{"line_number":78,"context_line":"    exec { \u0027sfc-db-sync\u0027:"},{"line_number":79,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage --config-file /etc/neutron/neutron.conf --subproject networking-sfc upgrade head\u0027,"},{"line_number":80,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":81,"context_line":"      subscribe   \u003d\u003e ["},{"line_number":82,"context_line":"        Anchor[\u0027neutron::install::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_a8a734bd","line":79,"in_reply_to":"df3967d1_932872e2","updated":"2017-08-04 08:39:44.000000000","message":"nope, this is fine. It\u0027s just the db update to include new tables.","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e66ef5422307c72f0eadf8058ba99e45d6972bfa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  if $sync_db {"},{"line_number":77,"context_line":"    Package\u003c| title \u003d\u003d $::neutron::params::sfc_package |\u003e ~\u003e Exec[\u0027sfc-db-sync\u0027]"},{"line_number":78,"context_line":"    exec { \u0027sfc-db-sync\u0027:"},{"line_number":79,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage --config-file /etc/neutron/neutron.conf --subproject networking-sfc upgrade head\u0027,"},{"line_number":80,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":81,"context_line":"      subscribe   \u003d\u003e ["},{"line_number":82,"context_line":"        Anchor[\u0027neutron::install::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_247afe23","line":79,"in_reply_to":"df3967d1_a8a734bd","updated":"2017-08-08 13:48:21.000000000","message":"Ack","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"}],"releasenotes/notes/add_sfc_support-dc48691618415e97.yaml":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"f647640a4d0954deb27e21d001583ebf58f5926c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds ability to configure networking-sfc neutron"},{"line_number":4,"context_line":"    service."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df3967d1_13dec210","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"updated":"2017-08-02 10:23:22.000000000","message":"extension/plugin, networking-sfc does not have any specific processes","commit_id":"c4951182f517c4cbd3885f7e846200f5c7e28415"}],"spec/classes/neutron_services_sfc_spec.rb":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"6ef386a81dfcddfbf0d25de9baa0e1461fe3b3d6","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"      it \u0027configures networking-sfc.conf\u0027 do"},{"line_number":67,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":68,"context_line":"          \u0027DEFAULT/sfc_driver\u0027"},{"line_number":69,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":71,"context_line":"          \u0027DEFAULT/fc_driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_9cd2de5b","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":29},"updated":"2017-09-13 01:38:24.000000000","message":"should be \u0027sfc/drivers\u0027","commit_id":"7e468c80c009877df8ca8b880a5ae639a5f67a5d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"85962b6d3a38bb2cb61aef86b6500dab3f6e5b06","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"      it \u0027configures networking-sfc.conf\u0027 do"},{"line_number":67,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":68,"context_line":"          \u0027DEFAULT/sfc_driver\u0027"},{"line_number":69,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":71,"context_line":"          \u0027DEFAULT/fc_driver\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_0be7be14","line":68,"range":{"start_line":68,"start_character":11,"end_line":68,"end_character":29},"in_reply_to":"5f2577a7_9cd2de5b","updated":"2017-09-13 08:16:31.000000000","message":"Done","commit_id":"7e468c80c009877df8ca8b880a5ae639a5f67a5d"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"6ef386a81dfcddfbf0d25de9baa0e1461fe3b3d6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          \u0027DEFAULT/sfc_driver\u0027"},{"line_number":69,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":71,"context_line":"          \u0027DEFAULT/fc_driver\u0027"},{"line_number":72,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_fcc0c27e","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":28},"updated":"2017-09-13 01:38:24.000000000","message":"should be \u0027flowclassifier/drivers\u0027","commit_id":"7e468c80c009877df8ca8b880a5ae639a5f67a5d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"85962b6d3a38bb2cb61aef86b6500dab3f6e5b06","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          \u0027DEFAULT/sfc_driver\u0027"},{"line_number":69,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_neutron_sfc_service_config("},{"line_number":71,"context_line":"          \u0027DEFAULT/fc_driver\u0027"},{"line_number":72,"context_line":"        ).with_value(\u0027odl_v2\u0027)"},{"line_number":73,"context_line":"      end"},{"line_number":74,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_cbf096cc","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":28},"in_reply_to":"5f2577a7_fcc0c27e","updated":"2017-09-13 08:16:31.000000000","message":"Done","commit_id":"7e468c80c009877df8ca8b880a5ae639a5f67a5d"}]}
