)]}'
{"manifests/plugins/nsx_v3.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c11cd1d7042c74cb5f5633bffb5658d38d15013f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   in the nvp config."},{"line_number":44,"context_line":"#   Defaults to false."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class neutron::plugins::nsx_v3 ("},{"line_number":47,"context_line":"  $default_overlay_tz      \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $default_tier0_router    \u003d $::os_service_default,"},{"line_number":49,"context_line":"  $nsx_api_managers        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_3a247a5d","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":30},"updated":"2017-08-30 22:49:46.000000000","message":"Do we have to rename this? Can\u0027t you just refer to this as ::neutron::plugins::nsx instead? I\u0027m not sure why we should rename this as it is techincally correct.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57bfe32e4911658f881b7cd88ab7a8a310b4be22","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   in the nvp config."},{"line_number":44,"context_line":"#   Defaults to false."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class neutron::plugins::nsx_v3 ("},{"line_number":47,"context_line":"  $default_overlay_tz      \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $default_tier0_router    \u003d $::os_service_default,"},{"line_number":49,"context_line":"  $nsx_api_managers        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_173cf72c","line":46,"updated":"2017-08-30 22:13:05.000000000","message":"you\u0027ll need to rename unit tests and update unit tests code as well to test the right class.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"147729a9606d01b376cc6db65a05fa6cb3334cb7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   in the nvp config."},{"line_number":44,"context_line":"#   Defaults to false."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class neutron::plugins::nsx_v3 ("},{"line_number":47,"context_line":"  $default_overlay_tz      \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $default_tier0_router    \u003d $::os_service_default,"},{"line_number":49,"context_line":"  $nsx_api_managers        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_37ddb3df","line":46,"in_reply_to":"7f287b81_173cf72c","updated":"2017-08-30 22:17:11.000000000","message":"Sure, I will add unit test in next patch.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"042d26c6fa9efa9b0238397f4ec5e175d1a94a01","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   in the nvp config."},{"line_number":44,"context_line":"#   Defaults to false."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class neutron::plugins::nsx_v3 ("},{"line_number":47,"context_line":"  $default_overlay_tz      \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $default_tier0_router    \u003d $::os_service_default,"},{"line_number":49,"context_line":"  $nsx_api_managers        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_9ad80e53","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":30},"in_reply_to":"7f287b81_3a247a5d","updated":"2017-08-30 22:50:29.000000000","message":"It should be noted, fixing the heat template is way less work than renaming this class. Also since techincally the previous class when out with the Pike release we shouldn\u0027t be renaming this.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"a2fa20da4641a16c5218b1b918c1520e119026e5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#   in the nvp config."},{"line_number":44,"context_line":"#   Defaults to false."},{"line_number":45,"context_line":"#"},{"line_number":46,"context_line":"class neutron::plugins::nsx_v3 ("},{"line_number":47,"context_line":"  $default_overlay_tz      \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $default_tier0_router    \u003d $::os_service_default,"},{"line_number":49,"context_line":"  $nsx_api_managers        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_ba918a49","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":30},"in_reply_to":"7f287b81_9ad80e53","updated":"2017-08-30 22:54:57.000000000","message":"We prefer to use nsx_v3 and nsx has three totally different product nvp, nsx_v and nsx_v3. This is for nsx_v3 only and that\u0027s why we want to rename it to nsx_v3. \n\nThere are two ways to fix this. Either fix in THT or here. Let\u0027s discuss with Gary how to proceed.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"57bfe32e4911658f881b7cd88ab7a8a310b4be22","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $dhcp_profile_uuid       \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $metadata_proxy_uuid     \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $native_dhcp_metadata    \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $dhcp_agent_notification \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $purge_config            \u003d false,"},{"line_number":58,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_977ea7e1","line":55,"updated":"2017-08-30 22:13:05.000000000","message":"this change isn\u0027t backward compatible, you introduced this change in parameter in Ocata and we usually maintain a stable interface with a deprecation period. See https://docs.openstack.org/puppet-openstack-guide/latest/contributor/coding-style.html\n\nSee other examples in this module or elsewhere where deprecation has been done.\n\nOtherwise, ping us on #þuppet-openstack.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"147729a9606d01b376cc6db65a05fa6cb3334cb7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $dhcp_profile_uuid       \u003d $::os_service_default,"},{"line_number":53,"context_line":"  $metadata_proxy_uuid     \u003d $::os_service_default,"},{"line_number":54,"context_line":"  $native_dhcp_metadata    \u003d $::os_service_default,"},{"line_number":55,"context_line":"  $dhcp_agent_notification \u003d $::os_service_default,"},{"line_number":56,"context_line":"  $package_ensure          \u003d \u0027present\u0027,"},{"line_number":57,"context_line":"  $purge_config            \u003d false,"},{"line_number":58,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f287b81_b7c9a326","line":55,"in_reply_to":"7f287b81_977ea7e1","updated":"2017-08-30 22:17:11.000000000","message":"Got it.","commit_id":"8c2f394dc2f20b040bf21c0a773a4336d8bbd179"}]}
