)]}'
{"manifests/agents/vpnaas.pp":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"36ddbd7b808918e960e18040288d45adf92308d2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*manage_service*]"},{"line_number":31,"context_line":"#   (optional) Whether to start/stop the service"},{"line_number":32,"context_line":"#   Defaults to true"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*vpn_device_driver*]"},{"line_number":35,"context_line":"#   (optional) Defaults to \u0027neutron.services.vpn.device_drivers.ipsec.OpenSwanDriver\u0027."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_edf9e8c7","side":"PARENT","line":32,"updated":"2017-11-02 17:29:44.000000000","message":"Can you add those to a list of deprecated parameters and set them to undef (you can look at other changes as an example).","commit_id":"0a2b0141a88e0c06edab63b0b7a1ce19bfc31af0"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"36ddbd7b808918e960e18040288d45adf92308d2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class neutron::agents::vpnaas ("},{"line_number":49,"context_line":"  $package_ensure              \u003d present,"},{"line_number":50,"context_line":"  $enabled                     \u003d true,"},{"line_number":51,"context_line":"  $manage_service              \u003d true,"},{"line_number":52,"context_line":"  $vpn_device_driver           \u003d \u0027neutron.services.vpn.device_drivers.ipsec.OpenSwanDriver\u0027,"},{"line_number":53,"context_line":"  $interface_driver            \u003d \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027,"},{"line_number":54,"context_line":"  $ipsec_status_check_interval \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_cdf62cd8","side":"PARENT","line":51,"updated":"2017-11-02 17:29:44.000000000","message":"Same for this.  The reason is we will break Puppet manifests if we drop it like this.","commit_id":"0a2b0141a88e0c06edab63b0b7a1ce19bfc31af0"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"36ddbd7b808918e960e18040288d45adf92308d2","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  include ::neutron::deps"},{"line_number":59,"context_line":"  include ::neutron::params"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  case $vpn_device_driver {"},{"line_number":62,"context_line":"    /\\.OpenSwan/: {"},{"line_number":63,"context_line":"      Package[\u0027openswan\u0027] -\u003e Package\u003c| title \u003d\u003d \u0027neutron-vpnaas-agent\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4b6375_adff70a9","side":"PARENT","line":60,"updated":"2017-11-02 17:29:44.000000000","message":"I suggest adding a warning that enabled and manage_service has been deprecated.","commit_id":"0a2b0141a88e0c06edab63b0b7a1ce19bfc31af0"}]}