)]}'
{"manifests/plugins/ovs/opendaylight.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"896e8ef8f0321d8a9e03e965cf96823b535b2998","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    }"},{"line_number":172,"context_line":"    $curl_post \u003d \"curl -k -X POST -o /dev/null --fail --silent -H \u0027Content-Type: application/json\u0027 -H \u0027Cache-Control: no-cache\u0027\""},{"line_number":173,"context_line":"    $cert_rest_url \u003d \"${odl_url_prefix}/restconf/operations/aaa-cert-rpc:setNodeCertifcate\""},{"line_number":174,"context_line":"    exec { \"Add trusted cert: ${tls_cert_file}\":"},{"line_number":175,"context_line":"      command   \u003d\u003e \"${curl_post} -u ${odl_username}:${odl_password} -d \u0027${rest_data}\u0027 ${cert_rest_url}\","},{"line_number":176,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":177,"context_line":"      try_sleep \u003d\u003e 30,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7f96bb07_66388dee","line":174,"updated":"2018-01-16 16:16:19.000000000","message":"the Exec isn\u0027t idempotent, you need to add \"unless\" or \"onlyif\" statements to the resource.","commit_id":"bc3c3bf189b52780b707821c175b668c9919badf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c6e2789f28395effbc151f8a145b3af113f3e1a2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    }"},{"line_number":172,"context_line":"    $curl_post \u003d \"curl -k -X POST -o /dev/null --fail --silent -H \u0027Content-Type: application/json\u0027 -H \u0027Cache-Control: no-cache\u0027\""},{"line_number":173,"context_line":"    $cert_rest_url \u003d \"${odl_url_prefix}/restconf/operations/aaa-cert-rpc:setNodeCertifcate\""},{"line_number":174,"context_line":"    exec { \"Add trusted cert: ${tls_cert_file}\":"},{"line_number":175,"context_line":"      command   \u003d\u003e \"${curl_post} -u ${odl_username}:${odl_password} -d \u0027${rest_data}\u0027 ${cert_rest_url}\","},{"line_number":176,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":177,"context_line":"      try_sleep \u003d\u003e 30,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7f96bb07_5c53e43f","line":174,"in_reply_to":"7f96bb07_5906961f","updated":"2018-01-16 17:13:43.000000000","message":"Yeah we can always override with new cert but it makes Puppet runs not idempotent and that\u0027s not what we need.\nWhat we want is to update the cert when it\u0027s needed, otherwise do nothing.","commit_id":"bc3c3bf189b52780b707821c175b668c9919badf"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"60362da18b609587953e8ee1412501e35787480d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    }"},{"line_number":172,"context_line":"    $curl_post \u003d \"curl -k -X POST -o /dev/null --fail --silent -H \u0027Content-Type: application/json\u0027 -H \u0027Cache-Control: no-cache\u0027\""},{"line_number":173,"context_line":"    $cert_rest_url \u003d \"${odl_url_prefix}/restconf/operations/aaa-cert-rpc:setNodeCertifcate\""},{"line_number":174,"context_line":"    exec { \"Add trusted cert: ${tls_cert_file}\":"},{"line_number":175,"context_line":"      command   \u003d\u003e \"${curl_post} -u ${odl_username}:${odl_password} -d \u0027${rest_data}\u0027 ${cert_rest_url}\","},{"line_number":176,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":177,"context_line":"      try_sleep \u003d\u003e 30,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7f96bb07_0d44441a","line":174,"in_reply_to":"7f96bb07_5c53e43f","updated":"2018-01-16 18:26:22.000000000","message":"OK will fix in next patch set.","commit_id":"bc3c3bf189b52780b707821c175b668c9919badf"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"548d6cf2167d09ba29da710936ac34d2208fa9bf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    }"},{"line_number":172,"context_line":"    $curl_post \u003d \"curl -k -X POST -o /dev/null --fail --silent -H \u0027Content-Type: application/json\u0027 -H \u0027Cache-Control: no-cache\u0027\""},{"line_number":173,"context_line":"    $cert_rest_url \u003d \"${odl_url_prefix}/restconf/operations/aaa-cert-rpc:setNodeCertifcate\""},{"line_number":174,"context_line":"    exec { \"Add trusted cert: ${tls_cert_file}\":"},{"line_number":175,"context_line":"      command   \u003d\u003e \"${curl_post} -u ${odl_username}:${odl_password} -d \u0027${rest_data}\u0027 ${cert_rest_url}\","},{"line_number":176,"context_line":"      tries     \u003d\u003e 5,"},{"line_number":177,"context_line":"      try_sleep \u003d\u003e 30,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7f96bb07_5906961f","line":174,"in_reply_to":"7f96bb07_66388dee","updated":"2018-01-16 16:20:30.000000000","message":"Right.  In this case we always upload the new certificate.  It will overwrite the previously uploaded one for this host.  The alternative would be add another curl to get the current certificate via curl, parse out the certificate string and compare it to cert_data.  I thought that was unnecessary since we can always override with new cert.  Thoughts?","commit_id":"bc3c3bf189b52780b707821c175b668c9919badf"}]}