)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"4657859eeac7d98c1bcd854fc82a66cf6ae46c19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allowing Non-IP Traffic in L2 and L3 domains"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Non-IP traffic is allowed in L2 and L3 Domains with RHEL OSP 10.0"},{"line_number":10,"context_line":"The default_allow_non_ip setting determines if non-ip traffic is allowed in L2 and L3 domains."},{"line_number":11,"context_line":"Change-Id: I8fb0f86c8d8ae19700cf5803fea9eb7aaa73040a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_3030db07","line":10,"updated":"2018-01-22 15:40:13.000000000","message":"Few things on the commit message:\n* Might want to mention this is nuage specific in your commit message. * Where this patch isn\u0027t going towards OSP 10.0, I\u0027m not sure mentioning it here is relevant.\n* Mind your line lengths. Shouldn\u0027t exceed 72 chars (see https://wiki.openstack.org/wiki/GitCommitMessages).","commit_id":"57838c534fa9586af73d88589758b8150ea7b9af"}],"manifests/plugins/ml2/nuage.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"4657859eeac7d98c1bcd854fc82a66cf6ae46c19","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#   Defaults to false."},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# [*nuage_default_allow_non_ip*]"},{"line_number":43,"context_line":"#   (BoolOpt) Set to True to allow non-IP traffic by default"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"class neutron::plugins::ml2::nuage ("},{"line_number":46,"context_line":"  $nuage_net_partition_name,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_f0e8337d","line":43,"updated":"2018-01-22 15:40:13.000000000","message":"Add \"Defaults to false\" or similar?","commit_id":"57838c534fa9586af73d88589758b8150ea7b9af"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"4657859eeac7d98c1bcd854fc82a66cf6ae46c19","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  $nuage_auth_resource    \u003d \u0027/me\u0027,"},{"line_number":54,"context_line":"  $nuage_server_ssl       \u003d true,"},{"line_number":55,"context_line":"  $purge_config           \u003d false,"},{"line_number":56,"context_line":"  $nuage_default_allow_non_ip \u003d false,"},{"line_number":57,"context_line":") {"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f96bb07_f06b53ee","line":56,"updated":"2018-01-22 15:40:13.000000000","message":"I didn\u0027t realize our linter didn\u0027t trigger on non-aligned indentation of the equals sign here.","commit_id":"57838c534fa9586af73d88589758b8150ea7b9af"}]}
