)]}'
{"manifests/params.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a1fc7ae479b6c94f94d6e3cf33f6fde3217804db","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    $fwaas_package              \u003d \u0027openstack-neutron-fwaas\u0027"},{"line_number":78,"context_line":"    $neutron_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/neutron\u0027"},{"line_number":79,"context_line":"    $neutron_wsgi_script_source \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":80,"context_line":"    $networking_baremetal_package \u003d \u0027python2-networking-baremetal\u0027"},{"line_number":81,"context_line":"  } elsif($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":82,"context_line":"    $nobody_user_group          \u003d \u0027nogroup\u0027"},{"line_number":83,"context_line":"    $package_name               \u003d \u0027neutron-common\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f93b717_aa6c8a08","line":80,"updated":"2018-01-25 16:57:44.000000000","message":"nit: all equal signs have to be indented to match this one","commit_id":"82796f344a494d34092f70b798b6afb7858e39b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d964a9e869fcc15cf361a402d4b54938b85998af","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    $fwaas_package              \u003d \u0027openstack-neutron-fwaas\u0027"},{"line_number":78,"context_line":"    $neutron_wsgi_script_path   \u003d \u0027/var/www/cgi-bin/neutron\u0027"},{"line_number":79,"context_line":"    $neutron_wsgi_script_source \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":80,"context_line":"    $networking_baremetal_package \u003d \u0027python2-networking-baremetal\u0027"},{"line_number":81,"context_line":"  } elsif($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":82,"context_line":"    $nobody_user_group          \u003d \u0027nogroup\u0027"},{"line_number":83,"context_line":"    $package_name               \u003d \u0027neutron-common\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f93b717_0389e973","line":80,"in_reply_to":"5f93b717_aa6c8a08","updated":"2018-01-25 18:45:34.000000000","message":"Done","commit_id":"82796f344a494d34092f70b798b6afb7858e39b7"}],"manifests/plugins/ml2/networking_baremetal.pp":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a1fc7ae479b6c94f94d6e3cf33f6fde3217804db","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::plugins::ml2::networking_baremetal("},{"line_number":14,"context_line":"  $package_ensure           \u003d \u0027present\u0027,"},{"line_number":15,"context_line":"  ) {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f93b717_8a73cee7","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":26},"updated":"2018-01-25 16:57:44.000000000","message":"nit: too many spaces","commit_id":"82796f344a494d34092f70b798b6afb7858e39b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d964a9e869fcc15cf361a402d4b54938b85998af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::plugins::ml2::networking_baremetal("},{"line_number":14,"context_line":"  $package_ensure           \u003d \u0027present\u0027,"},{"line_number":15,"context_line":"  ) {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f93b717_a37d956f","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":26},"in_reply_to":"5f93b717_8a73cee7","updated":"2018-01-25 18:45:34.000000000","message":"Done","commit_id":"82796f344a494d34092f70b798b6afb7858e39b7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e62c8e6ce83f821a7d501a26957bcb7280035f67","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":23,"context_line":"    name   \u003d\u003e $::neutron::params::networking_baremetal_package,"},{"line_number":24,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa0c359_6651e6d8","line":25,"updated":"2018-02-05 22:46:14.000000000","message":"Might also be beneficial to throw a failure if not available (e.g. on ubuntu)","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"daf4afd5bce1ac2b13da8772dc54251779b018b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":23,"context_line":"    name   \u003d\u003e $::neutron::params::networking_baremetal_package,"},{"line_number":24,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3fa0c359_b6d071cb","line":25,"in_reply_to":"3fa0c359_6651e6d8","updated":"2018-02-06 09:18:51.000000000","message":"Done","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"969ae0898955de2c5c3954f4e1354c419f014383","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  include ::neutron::params"},{"line_number":19,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  if($::osfamily !\u003d \u0027Redhat\u0027) {"},{"line_number":22,"context_line":"    # Drivers are only packaged for RedHat at this time"},{"line_number":23,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":24,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3fa0c359_8f7c17ec","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":27},"updated":"2018-02-07 14:34:43.000000000","message":"RedHat","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"116a28e302e869a31f0a2e67d5e9e0b9c929b55b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  include ::neutron::params"},{"line_number":19,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  if($::osfamily !\u003d \u0027Redhat\u0027) {"},{"line_number":22,"context_line":"    # Drivers are only packaged for RedHat at this time"},{"line_number":23,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":24,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3fa0c359_4f704fdd","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":27},"in_reply_to":"3fa0c359_8f7c17ec","updated":"2018-02-07 14:43:19.000000000","message":"I copied that line from cisco.pp.\n\nDone.","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"}],"spec/classes/neutron_plugins_ml2_networking_baremetal.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a6ad30a204fd9fec25cf8c6b8b29fcf3a87aaae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027neutron::plugins::ml2::networking_baremetal\u0027 do"},{"line_number":4,"context_line":"  let :default_params do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3fa0c359_66e32635","line":1,"updated":"2018-02-05 22:44:22.000000000","message":"This file is not named correctly so the tests aren\u0027t actually being executed. You\u0027d see that there is a parse error in this file (missing an end). Please fix the name of the file to end in _spec.rb","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"daf4afd5bce1ac2b13da8772dc54251779b018b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027neutron::plugins::ml2::networking_baremetal\u0027 do"},{"line_number":4,"context_line":"  let :default_params do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3fa0c359_1694c536","line":1,"in_reply_to":"3fa0c359_66e32635","updated":"2018-02-06 09:18:51.000000000","message":"ooops. \n\nDone.","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3a6ad30a204fd9fec25cf8c6b8b29fcf3a87aaae","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      is_expected.to contain_package(\u0027python2-networking-baremetal\u0027).that_notifies(\u0027Anchor[neutron::install::end]\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":37,"context_line":"    let :facts do"},{"line_number":38,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":39,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":40,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":41,"context_line":"      }))"},{"line_number":42,"context_line":"    end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    let :platform_params do"},{"line_number":45,"context_line":"      { :networking_baremetal_package \u003d\u003e \u0027python2-networking-baremetal\u0027}"},{"line_number":46,"context_line":"    end"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    it_configures \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":49,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3fa0c359_c67d5a6f","line":48,"range":{"start_line":36,"start_character":0,"end_line":48,"end_character":51},"updated":"2018-02-05 22:44:22.000000000","message":"This should use on_supported_os instead. See https://github.com/openstack/puppet-ironic/blob/master/spec/classes/ironic_cinder_spec.rb#L72-L82","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"daf4afd5bce1ac2b13da8772dc54251779b018b8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      is_expected.to contain_package(\u0027python2-networking-baremetal\u0027).that_notifies(\u0027Anchor[neutron::install::end]\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":37,"context_line":"    let :facts do"},{"line_number":38,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":39,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":40,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":41,"context_line":"      }))"},{"line_number":42,"context_line":"    end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    let :platform_params do"},{"line_number":45,"context_line":"      { :networking_baremetal_package \u003d\u003e \u0027python2-networking-baremetal\u0027}"},{"line_number":46,"context_line":"    end"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    it_configures \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":49,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3fa0c359_76d0a9f8","line":48,"range":{"start_line":36,"start_character":0,"end_line":48,"end_character":51},"in_reply_to":"3fa0c359_c67d5a6f","updated":"2018-02-06 09:18:51.000000000","message":"Done","commit_id":"aed725c8b8bd07ac4a79b1f2bc10a86e569ab911"}],"spec/classes/neutron_plugins_ml2_networking_baremetal_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"969ae0898955de2c5c3954f4e1354c419f014383","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        end"},{"line_number":49,"context_line":"      end"},{"line_number":50,"context_line":"      case facts[:osfamily]"},{"line_number":51,"context_line":"      when \u0027Red Hat\u0027"},{"line_number":52,"context_line":"        it_behaves_like \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":53,"context_line":"      when facts[:osfamily] !\u003d \u0027Red Hat\u0027"},{"line_number":54,"context_line":"        it \u0027fails with unsupported osfamily\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3fa0c359_2f8383ce","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":19},"updated":"2018-02-07 14:34:43.000000000","message":"RedHat","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"116a28e302e869a31f0a2e67d5e9e0b9c929b55b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        end"},{"line_number":49,"context_line":"      end"},{"line_number":50,"context_line":"      case facts[:osfamily]"},{"line_number":51,"context_line":"      when \u0027Red Hat\u0027"},{"line_number":52,"context_line":"        it_behaves_like \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":53,"context_line":"      when facts[:osfamily] !\u003d \u0027Red Hat\u0027"},{"line_number":54,"context_line":"        it \u0027fails with unsupported osfamily\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3fa0c359_0f7247e4","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":19},"in_reply_to":"3fa0c359_2f8383ce","updated":"2018-02-07 14:43:19.000000000","message":"Done","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"969ae0898955de2c5c3954f4e1354c419f014383","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      case facts[:osfamily]"},{"line_number":51,"context_line":"      when \u0027Red Hat\u0027"},{"line_number":52,"context_line":"        it_behaves_like \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":53,"context_line":"      when facts[:osfamily] !\u003d \u0027Red Hat\u0027"},{"line_number":54,"context_line":"        it \u0027fails with unsupported osfamily\u0027 do"},{"line_number":55,"context_line":"          is_expected.to raise_error(Puppet::Error, /Unsupported osfamily.*/)"},{"line_number":56,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3fa0c359_af76b305","line":53,"range":{"start_line":53,"start_character":32,"end_line":53,"end_character":39},"updated":"2018-02-07 14:34:43.000000000","message":"RedHat","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"116a28e302e869a31f0a2e67d5e9e0b9c929b55b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      case facts[:osfamily]"},{"line_number":51,"context_line":"      when \u0027Red Hat\u0027"},{"line_number":52,"context_line":"        it_behaves_like \u0027networking-baremetal ml2 plugin\u0027"},{"line_number":53,"context_line":"      when facts[:osfamily] !\u003d \u0027Red Hat\u0027"},{"line_number":54,"context_line":"        it \u0027fails with unsupported osfamily\u0027 do"},{"line_number":55,"context_line":"          is_expected.to raise_error(Puppet::Error, /Unsupported osfamily.*/)"},{"line_number":56,"context_line":"        end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3fa0c359_af80f38c","line":53,"range":{"start_line":53,"start_character":32,"end_line":53,"end_character":39},"in_reply_to":"3fa0c359_af76b305","updated":"2018-02-07 14:43:19.000000000","message":"Done","commit_id":"d665978a024e8c26b4987741da3a4804f89b6403"}]}
