)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4aaf55e1848a8f5c63bf3905c8bd3966f0d099c1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-02-12 13:39:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix dependency cycle issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1748435"},{"line_number":10,"context_line":"Change-Id: Ie7bb7d00c606a928b58cdc45e04c4fce45208fe5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_e79a3460","line":8,"updated":"2018-02-12 14:51:53.000000000","message":"no commit message?","commit_id":"b5ed17e2213f716cda9dabfbcbd9db8fd7b462fa"}],"manifests/plugins/ml2/networking_baremetal.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4aaf55e1848a8f5c63bf3905c8bd3966f0d099c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::deps"},{"line_number":18,"context_line":"  include ::neutron::params"},{"line_number":19,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  if($::osfamily !\u003d \u0027RedHat\u0027) {"},{"line_number":22,"context_line":"    # Drivers are only packaged for RedHat at this time"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa0c359_a7f74c8b","side":"PARENT","line":19,"updated":"2018-02-12 14:51:53.000000000","message":"I think we need this class to be loaded to configure basic ml2 parameters, not sure how removing this class will help.","commit_id":"1a59f72dfc157b49b189d55228d7d49a58a5319d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7ca2625c68bf1445be2b4192b071fd2d696af692","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::deps"},{"line_number":18,"context_line":"  include ::neutron::params"},{"line_number":19,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  if($::osfamily !\u003d \u0027RedHat\u0027) {"},{"line_number":22,"context_line":"    # Drivers are only packaged for RedHat at this time"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa0c359_47aa0819","side":"PARENT","line":19,"in_reply_to":"3fa0c359_a7f74c8b","updated":"2018-02-12 14:57:33.000000000","message":"We do. ::neutron::plugins::ml2:mechanism_drivers: must be set to enable the mechanism driver.\n\nThis class installs the package only.","commit_id":"1a59f72dfc157b49b189d55228d7d49a58a5319d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8b9a9a2437758ab4994aaa43df8aa8b7781d3d7c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    package { \u0027python2-networking-baremetal\u0027:"},{"line_number":25,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":26,"context_line":"      name   \u003d\u003e $::neutron::params::networking_baremetal_package,"},{"line_number":27,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa0c359_32cef159","line":27,"range":{"start_line":27,"start_character":30,"end_line":27,"end_character":48},"updated":"2018-02-13 19:27:05.000000000","message":"So just for the record, the issue is actually caused by this tag. That being said for this we don\u0027t need ::neutron::plugins::ml2 because we\u0027re not using the neutron_plugins_ml2 provider.","commit_id":"dbe75c29ee3ce2255c8d9018f17162ce6c8aa1b3"}]}