)]}'
{"manifests/plugins/ml2/mellanox.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  include ::neutron::params"},{"line_number":20,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if($::osfamily !\u003d \u0027Redhat\u0027) {"},{"line_number":23,"context_line":"    # Drivers are only packaged for RedHat at this time"},{"line_number":24,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":25,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_45406d08","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":27},"updated":"2018-03-07 09:08:38.000000000","message":"RedHat","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"54dbc9263aa7392b4991ea3eca9915ab888e59c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  include ::neutron::params"},{"line_number":20,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if($::osfamily !\u003d \u0027Redhat\u0027) {"},{"line_number":23,"context_line":"    # Drivers are only packaged for RedHat at this time"},{"line_number":24,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":25,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_4a3b9137","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":27},"in_reply_to":"df7087c5_3166dbef","updated":"2018-03-07 14:42:31.000000000","message":"I meant to say:\nactually it can be Redhat as well","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2d8c1aaa96ba5c93bfc254fefc9857326a817cd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  include ::neutron::params"},{"line_number":20,"context_line":"  require ::neutron::plugins::ml2"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if($::osfamily !\u003d \u0027Redhat\u0027) {"},{"line_number":23,"context_line":"    # Drivers are only packaged for RedHat at this time"},{"line_number":24,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":25,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_3166dbef","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":27},"in_reply_to":"df7087c5_45406d08","updated":"2018-03-07 14:40:11.000000000","message":"actually it\u0027s Redhat,\nref: https://git.openstack.org/cgit/openstack/puppet-neutron/tree/manifests/plugins/ml2/cisco.pp?id\u003dd6c460f1e920ae8aad70e77408e29e01f475da33#n22","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-networking-mlnx\u0027,"},{"line_number":28,"context_line":"    {"},{"line_number":29,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":30,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_e5c5015d","line":27,"range":{"start_line":27,"start_character":2,"end_line":27,"end_character":17},"updated":"2018-03-07 09:08:38.000000000","message":"maybe ensure_package but this is fine","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"588d54973c77e4f7f4ed2a1ee7badad213b5a519","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-networking-mlnx\u0027,"},{"line_number":28,"context_line":"    {"},{"line_number":29,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":30,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  )"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_d513b80c","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":28},"updated":"2018-03-08 02:03:15.000000000","message":"[\u0027openstack\u0027, \u0027neutron-package\u0027] is better,","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"7f6531a6588c066ed54e9f4a1983e0614317ec06","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-networking-mlnx\u0027,"},{"line_number":28,"context_line":"    {"},{"line_number":29,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":30,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  )"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_69c6916a","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":28},"in_reply_to":"df7087c5_d513b80c","updated":"2018-03-08 08:30:40.000000000","message":"Done","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"}],"manifests/plugins/ml2/mellanox/mlnx_sdn_assist.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Example: \u0027cloudx\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("},{"line_number":28,"context_line":"  $sdn_username              \u003d $::os_service_default,"},{"line_number":29,"context_line":"  $sdn_password              \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $sdn_url                   \u003d $::os_service_default,"},{"line_number":31,"context_line":"  $sdn_domain                \u003d $::os_service_default,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_c5531de2","line":31,"range":{"start_line":28,"start_character":2,"end_line":31,"end_character":53},"updated":"2018-03-07 09:08:38.000000000","message":"alignment of \u003d","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2d8c1aaa96ba5c93bfc254fefc9857326a817cd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Example: \u0027cloudx\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("},{"line_number":28,"context_line":"  $sdn_username              \u003d $::os_service_default,"},{"line_number":29,"context_line":"  $sdn_password              \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $sdn_url                   \u003d $::os_service_default,"},{"line_number":31,"context_line":"  $sdn_domain                \u003d $::os_service_default,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"df7087c5_f15f030c","line":31,"range":{"start_line":28,"start_character":2,"end_line":31,"end_character":53},"in_reply_to":"df7087c5_c5531de2","updated":"2018-03-07 14:40:11.000000000","message":"Done","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"588d54973c77e4f7f4ed2a1ee7badad213b5a519","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# [*sdn_url*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":19,"context_line":"# Defaults to $::os_service_default"},{"line_number":20,"context_line":"# Example: \u0027http://127.0.0.1:8080/neo\u0027"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_75f8acc3","line":20,"range":{"start_line":20,"start_character":11,"end_line":20,"end_character":38},"updated":"2018-03-08 02:03:15.000000000","message":"should be $::os_service_default","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"7f6531a6588c066ed54e9f4a1983e0614317ec06","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# [*sdn_url*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":19,"context_line":"# Defaults to $::os_service_default"},{"line_number":20,"context_line":"# Example: \u0027http://127.0.0.1:8080/neo\u0027"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_8903e542","line":20,"range":{"start_line":20,"start_character":11,"end_line":20,"end_character":38},"in_reply_to":"df7087c5_75f8acc3","updated":"2018-03-08 08:30:40.000000000","message":"this is an example not default.","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"588d54973c77e4f7f4ed2a1ee7badad213b5a519","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"},{"line_number":24,"context_line":"# Defaults to cloudx"},{"line_number":25,"context_line":"# Example: \u0027cloudx\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_350234b6","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":20},"updated":"2018-03-08 02:03:15.000000000","message":"should be $::os_service_default","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"7f6531a6588c066ed54e9f4a1983e0614317ec06","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"},{"line_number":24,"context_line":"# Defaults to cloudx"},{"line_number":25,"context_line":"# Example: \u0027cloudx\u0027"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df7087c5_c4cb04a3","line":24,"range":{"start_line":24,"start_character":14,"end_line":24,"end_character":20},"in_reply_to":"df7087c5_350234b6","updated":"2018-03-08 08:30:40.000000000","message":"Done","commit_id":"51ae7aca0004332ef6d93d64edfbd1de0d564f64"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"7c9ce4d3ef495316c5ea61e352e68608f582d0bb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# [*sdn_url*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":19,"context_line":"# Defaults to $::os_service_default"},{"line_number":20,"context_line":"# Example: \u0027http://127.0.0.1:8080/neo\u0027"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df7087c5_9e5b1886","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":33},"updated":"2018-03-08 11:01:15.000000000","message":"remove the port","commit_id":"d45de7672cea3bfa7df46ef92cd9607916889df5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"5470f818c466b4f0d5a2828e365d591877c81f59","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# [*sdn_url*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":19,"context_line":"# Defaults to $::os_service_default"},{"line_number":20,"context_line":"# Example: \u0027http://127.0.0.1:8080/neo\u0027"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*sdn_domain*]"},{"line_number":23,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df7087c5_14bfe9fb","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":33},"in_reply_to":"df7087c5_9e5b1886","updated":"2018-03-08 11:57:07.000000000","message":"Done","commit_id":"d45de7672cea3bfa7df46ef92cd9607916889df5"}],"spec/classes/neutron_plugins_ml2_mellanox_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  begin"},{"line_number":49,"context_line":"    context \u0027on RedHat platforms\u0027 do"},{"line_number":50,"context_line":"      let :facts do"},{"line_number":51,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":52,"context_line":"           :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":53,"context_line":"           :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":54,"context_line":"        }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_25e3f907","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":22},"updated":"2018-03-07 09:08:38.000000000","message":"default_facts should not be used, use spec_helper OSDefaults.get_facts [1], see [2]\n\n[1] https://github.com/openstack/puppet-openstack_spec_helper/blob/master/lib/puppet-openstack_spec_helper/facts.rb#L6\n[2] https://github.com/openstack/puppet-gnocchi/blob/master/spec/classes/gnocchi_api_spec.rb#L146","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2d8c1aaa96ba5c93bfc254fefc9857326a817cd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  begin"},{"line_number":49,"context_line":"    context \u0027on RedHat platforms\u0027 do"},{"line_number":50,"context_line":"      let :facts do"},{"line_number":51,"context_line":"        @default_facts.merge(test_facts.merge({"},{"line_number":52,"context_line":"           :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":53,"context_line":"           :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":54,"context_line":"        }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_0a74b934","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":22},"in_reply_to":"df7087c5_25e3f907","updated":"2018-03-07 14:40:11.000000000","message":"Done","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"}],"spec/classes/neutron_plugins_ml2_mlnx_sdn_assist_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":51,"context_line":"    let :facts do"},{"line_number":52,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":53,"context_line":"          :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":54,"context_line":"          :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":55,"context_line":"      }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_e5ec21f5","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":20},"updated":"2018-03-07 09:08:38.000000000","message":"same here","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2d8c1aaa96ba5c93bfc254fefc9857326a817cd","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":51,"context_line":"    let :facts do"},{"line_number":52,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":53,"context_line":"          :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":54,"context_line":"          :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":55,"context_line":"      }))"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_6a98d569","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":20},"in_reply_to":"df7087c5_e5ec21f5","updated":"2018-03-07 14:40:11.000000000","message":"Done","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"784afc715de48f90d9edc0f5a477e7db5ec4c0c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":62,"context_line":"    let :facts do"},{"line_number":63,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":64,"context_line":"          :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":65,"context_line":"      }))"},{"line_number":66,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_c5ef9de7","line":63,"range":{"start_line":63,"start_character":6,"end_line":63,"end_character":20},"updated":"2018-03-07 09:08:38.000000000","message":"same here","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2d8c1aaa96ba5c93bfc254fefc9857326a817cd","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":62,"context_line":"    let :facts do"},{"line_number":63,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":64,"context_line":"          :osfamily               \u003d\u003e \u0027Debian\u0027,"},{"line_number":65,"context_line":"      }))"},{"line_number":66,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"df7087c5_8a9d295b","line":63,"range":{"start_line":63,"start_character":6,"end_line":63,"end_character":20},"in_reply_to":"df7087c5_c5ef9de7","updated":"2018-03-07 14:40:11.000000000","message":"Done","commit_id":"d6c460f1e920ae8aad70e77408e29e01f475da33"}]}
