)]}'
{"manifests/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f33907a7cb346f17c6e0d425ef6b0fc6fa0a1082","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    $sfc_package                 \u003d \u0027python3-networking-sfc\u0027"},{"line_number":64,"context_line":"  } else {"},{"line_number":65,"context_line":"    $sfc_package                 \u003d \u0027python-networking-sfc\u0027"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":"  $group                       \u003d \u0027neutron\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if($::osfamily \u003d\u003d \u0027Redhat\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_a2bb7fc2","line":66,"updated":"2018-04-04 21:34:50.000000000","message":"I would recommend just grouping all of these changes for debian specific into a single if block rather than using a bunch of these blocks","commit_id":"d0f9b0d5f3734affd743ad5949eb70a60d3646f7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"737fdbb575a45f916fbe6eaf87d91a45f4d5a829","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    $sfc_package                 \u003d \u0027python3-networking-sfc\u0027"},{"line_number":64,"context_line":"  } else {"},{"line_number":65,"context_line":"    $sfc_package                 \u003d \u0027python-networking-sfc\u0027"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":"  $group                       \u003d \u0027neutron\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if($::osfamily \u003d\u003d \u0027Redhat\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_0254ab53","line":66,"in_reply_to":"bf659307_a2bb7fc2","updated":"2018-04-04 21:43:12.000000000","message":"Will do.","commit_id":"d0f9b0d5f3734affd743ad5949eb70a60d3646f7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f33907a7cb346f17c6e0d425ef6b0fc6fa0a1082","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    $fwaas_package                      \u003d \u0027openstack-neutron-fwaas\u0027"},{"line_number":104,"context_line":"    $neutron_wsgi_script_path           \u003d \u0027/var/www/cgi-bin/neutron\u0027"},{"line_number":105,"context_line":"    $neutron_wsgi_script_source         \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":106,"context_line":"    if $::os_package_type \u003d\u003d\u0027debian\u0027 {"},{"line_number":107,"context_line":"      $networking_baremetal_package       \u003d \u0027python3-networking-baremetal\u0027"},{"line_number":108,"context_line":"    } else {"},{"line_number":109,"context_line":"      $networking_baremetal_package       \u003d \u0027python2-networking-baremetal\u0027"},{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":"    $networking_baremetal_agent_package \u003d \u0027python2-ironic-neutron-agent\u0027"},{"line_number":112,"context_line":"    $networking_baremetal_agent_service \u003d \u0027ironic-neutron-agent\u0027"},{"line_number":113,"context_line":"  } elsif($::osfamily \u003d\u003d \u0027Debian\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_828d1b2c","line":110,"range":{"start_line":106,"start_character":0,"end_line":110,"end_character":5},"updated":"2018-04-04 21:34:50.000000000","message":"this is under rhel, so you shouldn\u0027t fix this one","commit_id":"d0f9b0d5f3734affd743ad5949eb70a60d3646f7"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"737fdbb575a45f916fbe6eaf87d91a45f4d5a829","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    $fwaas_package                      \u003d \u0027openstack-neutron-fwaas\u0027"},{"line_number":104,"context_line":"    $neutron_wsgi_script_path           \u003d \u0027/var/www/cgi-bin/neutron\u0027"},{"line_number":105,"context_line":"    $neutron_wsgi_script_source         \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":106,"context_line":"    if $::os_package_type \u003d\u003d\u0027debian\u0027 {"},{"line_number":107,"context_line":"      $networking_baremetal_package       \u003d \u0027python3-networking-baremetal\u0027"},{"line_number":108,"context_line":"    } else {"},{"line_number":109,"context_line":"      $networking_baremetal_package       \u003d \u0027python2-networking-baremetal\u0027"},{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":"    $networking_baremetal_agent_package \u003d \u0027python2-ironic-neutron-agent\u0027"},{"line_number":112,"context_line":"    $networking_baremetal_agent_service \u003d \u0027ironic-neutron-agent\u0027"},{"line_number":113,"context_line":"  } elsif($::osfamily \u003d\u003d \u0027Debian\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_8260bb37","line":110,"range":{"start_line":106,"start_character":0,"end_line":110,"end_character":5},"in_reply_to":"bf659307_828d1b2c","updated":"2018-04-04 21:43:12.000000000","message":"I believe the Debian package python3-networking-baremetal should work, because it is really is available in Debian (but not in Ubuntu) and I tried it last week. It looked \"ok-ish\" even though I couldn\u0027t finish my tests. See there:\nhttp://stretch-queens.infomaniak.ch/debian/pool/stretch-queens-backports/main/n/networking-baremetal/","commit_id":"d0f9b0d5f3734affd743ad5949eb70a60d3646f7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f33907a7cb346f17c6e0d425ef6b0fc6fa0a1082","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    $libreswan_package          \u003d false"},{"line_number":139,"context_line":"    $metadata_agent_package     \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":140,"context_line":"    $l3_agent_package           \u003d \u0027neutron-l3-agent\u0027"},{"line_number":141,"context_line":"    if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":142,"context_line":"      $fwaas_package              \u003d \u0027python3-neutron-fwaas\u0027"},{"line_number":143,"context_line":"    } else {"},{"line_number":144,"context_line":"      $fwaas_package              \u003d \u0027python-neutron-fwaas\u0027"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":"    $l2gw_agent_package         \u003d \u0027neutron-l2gateway-agent\u0027"},{"line_number":147,"context_line":"    if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":148,"context_line":"      $l2gw_package               \u003d \u0027python3-networking-l2gw\u0027"},{"line_number":149,"context_line":"    } else {"},{"line_number":150,"context_line":"      $l2gw_package               \u003d \u0027python-networking-l2gw\u0027"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"    $neutron_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/neutron\u0027"},{"line_number":153,"context_line":"    $neutron_wsgi_script_source \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":154,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bf659307_02ca6b4e","line":151,"range":{"start_line":141,"start_character":0,"end_line":151,"end_character":5},"updated":"2018-04-04 21:34:50.000000000","message":"Should also combine these with the ml2_server_package up around 117-121","commit_id":"d0f9b0d5f3734affd743ad5949eb70a60d3646f7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5bab4617fdc0ad9d263ae51159228c4d03592fb2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"class neutron::params {"},{"line_number":6,"context_line":"  include ::openstacklib::defaults"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":9,"context_line":"    $client_package              \u003d \u0027python3-neutronclient\u0027"},{"line_number":10,"context_line":"  } else {"},{"line_number":11,"context_line":"    $client_package              \u003d \u0027python-neutronclient\u0027"},{"line_number":12,"context_line":"  }"},{"line_number":13,"context_line":"  $server_service              \u003d \u0027neutron-server\u0027"},{"line_number":14,"context_line":"  $ovs_agent_service           \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":15,"context_line":"  $destroy_patch_ports_service \u003d \u0027neutron-destroy-patch-ports\u0027"},{"line_number":16,"context_line":"  $linuxbridge_agent_service   \u003d \u0027neutron-linuxbridge-agent\u0027"},{"line_number":17,"context_line":"  $cisco_config_file           \u003d \u0027/etc/neutron/plugins/cisco/cisco_plugins.ini\u0027"},{"line_number":18,"context_line":"  $opencontrail_plugin_package \u003d \u0027neutron-plugin-contrail\u0027"},{"line_number":19,"context_line":"  $opencontrail_config_file    \u003d \u0027/etc/neutron/plugins/opencontrail/ContrailPlugin.ini\u0027"},{"line_number":20,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":21,"context_line":"    $midonet_server_package      \u003d \u0027python3-networking-midonet\u0027"},{"line_number":22,"context_line":"    $midonet_server_package_ext  \u003d \u0027python3-networking-midonet-ext\u0027"},{"line_number":23,"context_line":"  } else {"},{"line_number":24,"context_line":"    $midonet_server_package      \u003d \u0027python-networking-midonet\u0027"},{"line_number":25,"context_line":"    $midonet_server_package_ext  \u003d \u0027python-networking-midonet-ext\u0027"},{"line_number":26,"context_line":"  }"},{"line_number":27,"context_line":"    $midonet_config_file         \u003d \u0027/etc/neutron/plugins/midonet/midonet.ini\u0027"},{"line_number":28,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":29,"context_line":"    $ovn_plugin_package          \u003d \u0027python3-networking-ovn\u0027"},{"line_number":30,"context_line":"    $vpp_plugin_package          \u003d \u0027python3-networking-vpp\u0027"},{"line_number":31,"context_line":"  } else {"},{"line_number":32,"context_line":"    $ovn_plugin_package          \u003d \u0027python-networking-ovn\u0027"},{"line_number":33,"context_line":"    $vpp_plugin_package          \u003d \u0027python-networking-vpp\u0027"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":"  $vpp_agent_service           \u003d \u0027neutron-vpp-agent\u0027"},{"line_number":36,"context_line":"  $plumgrid_plugin_package     \u003d \u0027networking-plumgrid\u0027"},{"line_number":37,"context_line":"  $plumgrid_pythonlib_package  \u003d \u0027plumgrid-pythonlib\u0027"},{"line_number":38,"context_line":"  $plumgrid_config_file        \u003d \u0027/etc/neutron/plugins/plumgrid/plumgrid.ini\u0027"},{"line_number":39,"context_line":"  $nuage_config_file           \u003d \u0027/etc/neutron/plugins/nuage/plugin.ini\u0027"},{"line_number":40,"context_line":"  $dhcp_agent_service          \u003d \u0027neutron-dhcp-agent\u0027"},{"line_number":41,"context_line":"  $lbaasv2_agent_service       \u003d \u0027neutron-lbaasv2-agent\u0027"},{"line_number":42,"context_line":"  $haproxy_package             \u003d \u0027haproxy\u0027"},{"line_number":43,"context_line":"  $metering_agent_service      \u003d \u0027neutron-metering-agent\u0027"},{"line_number":44,"context_line":"  $l3_agent_service            \u003d \u0027neutron-l3-agent\u0027"},{"line_number":45,"context_line":"  $metadata_agent_service      \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":46,"context_line":"  $ovn_metadata_agent_service  \u003d \u0027networking-ovn-metadata-agent\u0027"},{"line_number":47,"context_line":"  $bagpipe_bgp_package         \u003d \u0027openstack-bagpipe-bgp\u0027"},{"line_number":48,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":49,"context_line":"    $bgpvpn_bagpipe_package      \u003d \u0027python3-networking-bagpipe\u0027"},{"line_number":50,"context_line":"  } else {"},{"line_number":51,"context_line":"    $bgpvpn_bagpipe_package      \u003d \u0027python-networking-bagpipe\u0027"},{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":"  $bgpvpn_bagpipe_service      \u003d \u0027bagpipe-bgp\u0027"},{"line_number":54,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":55,"context_line":"    $bgpvpn_plugin_package       \u003d \u0027python3-networking-bgpvpn\u0027"},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $bgpvpn_plugin_package       \u003d \u0027python-networking-bgpvpn\u0027"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"  $l2gw_agent_service          \u003d \u0027neutron-l2gw-agent\u0027"},{"line_number":60,"context_line":"  $nsx_plugin_package          \u003d \u0027vmware-nsx\u0027"},{"line_number":61,"context_line":"  $nsx_config_file             \u003d \u0027/etc/neutron/plugins/vmware/nsx.ini\u0027"},{"line_number":62,"context_line":"  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":63,"context_line":"    $sfc_package                 \u003d \u0027python3-networking-sfc\u0027"},{"line_number":64,"context_line":"  } else {"},{"line_number":65,"context_line":"    $sfc_package                 \u003d \u0027python-networking-sfc\u0027"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":"  $group                       \u003d \u0027neutron\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  if($::osfamily \u003d\u003d \u0027Redhat\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bf659307_020cab40","line":66,"range":{"start_line":8,"start_character":0,"end_line":66,"end_character":3},"updated":"2018-04-04 21:57:34.000000000","message":"Just group all the if blocks into a single one.\n\n\n\n  if ($::os_package_type \u003d\u003d \u0027debian\u0027) {\n    $client_package              \u003d \u0027python3-neutronclient\u0027\n    $midonet_server_package      \u003d \u0027python3-networking-midonet\u0027\n    $midonet_server_package_ext  \u003d \u0027python3-networking-midonet-ext\u0027\n    $ovn_plugin_package          \u003d \u0027python3-networking-ovn\u0027\n    $vpp_plugin_package          \u003d \u0027python3-networking-vpp\u0027\n    $bgpvpn_bagpipe_package      \u003d \u0027python3-networking-bagpipe\u0027\n    $bgpvpn_plugin_package       \u003d \u0027python3-networking-bgpvpn\u0027\n    $sfc_package                 \u003d \u0027python3-networking-sfc\u0027\n  } else {\n    $client_package              \u003d \u0027python-neutronclient\u0027\n    $midonet_server_package      \u003d \u0027python-networking-midonet\u0027\n    $midonet_server_package_ext  \u003d \u0027python-networking-midonet-ext\u0027\n    $ovn_plugin_package          \u003d \u0027python-networking-ovn\u0027\n    $vpp_plugin_package          \u003d \u0027python-networking-vpp\u0027\n    $bgpvpn_bagpipe_package      \u003d \u0027python-networking-bagpipe\u0027\n    $bgpvpn_plugin_package       \u003d \u0027python-networking-bgpvpn\u0027\n    $sfc_package                 \u003d \u0027python-networking-sfc\u0027\n  }\n\n\n\nNow an alternative would be to create a python version modifier for the appropriate package names so something like...\n\nif ($::os_package_type \u003d\u003d \u0027debian\u0027) {\n  $ver_mod \u003d \u00273\u0027\n} else {\n  $ver_mod \u003d \u0027\u0027\n}\n\n\nAnd then for the package names you could just do something like....\n\n$client_package \u003d \"python${ver_mod}-neutronclient\"\n$midonet_server_package      \u003d \"python${ver_mod}-networking-midonet\"\netc...","commit_id":"73651479e9dd83a3e12e248c78606f96c00902c8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5bab4617fdc0ad9d263ae51159228c4d03592fb2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    $fwaas_package                      \u003d \u0027openstack-neutron-fwaas\u0027"},{"line_number":104,"context_line":"    $neutron_wsgi_script_path           \u003d \u0027/var/www/cgi-bin/neutron\u0027"},{"line_number":105,"context_line":"    $neutron_wsgi_script_source         \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":106,"context_line":"    if $::os_package_type \u003d\u003d\u0027debian\u0027 {"},{"line_number":107,"context_line":"      $networking_baremetal_package       \u003d \u0027python3-networking-baremetal\u0027"},{"line_number":108,"context_line":"    } else {"},{"line_number":109,"context_line":"      $networking_baremetal_package       \u003d \u0027python2-networking-baremetal\u0027"},{"line_number":110,"context_line":"    }"},{"line_number":111,"context_line":"    $networking_baremetal_agent_package \u003d \u0027python2-ironic-neutron-agent\u0027"},{"line_number":112,"context_line":"    $networking_baremetal_agent_service \u003d \u0027ironic-neutron-agent\u0027"},{"line_number":113,"context_line":"  } elsif($::osfamily \u003d\u003d \u0027Debian\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bf659307_c2579326","line":110,"range":{"start_line":106,"start_character":0,"end_line":110,"end_character":5},"updated":"2018-04-04 21:57:34.000000000","message":"This should just be:\n\n  $networking_baremetal_package       \u003d \u0027python2-networking-baremetal\u0027\n\nBecause this is in an $::osfamily \u003d\u003d \u0027Redhat\u0027 block. We wouldn\u0027t support os_package_type \u003d\u003d \u0027debian\u0027 with redhat at this time.","commit_id":"73651479e9dd83a3e12e248c78606f96c00902c8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5bab4617fdc0ad9d263ae51159228c4d03592fb2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    $libreswan_package          \u003d false"},{"line_number":139,"context_line":"    $metadata_agent_package     \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":140,"context_line":"    $l3_agent_package           \u003d \u0027neutron-l3-agent\u0027"},{"line_number":141,"context_line":"    if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":142,"context_line":"      $fwaas_package              \u003d \u0027python3-neutron-fwaas\u0027"},{"line_number":143,"context_line":"    } else {"},{"line_number":144,"context_line":"      $fwaas_package              \u003d \u0027python-neutron-fwaas\u0027"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":"    $l2gw_agent_package         \u003d \u0027neutron-l2gateway-agent\u0027"},{"line_number":147,"context_line":"    if ($::os_package_type \u003d\u003d \u0027debian\u0027) {"},{"line_number":148,"context_line":"      $l2gw_package               \u003d \u0027python3-networking-l2gw\u0027"},{"line_number":149,"context_line":"    } else {"},{"line_number":150,"context_line":"      $l2gw_package               \u003d \u0027python-networking-l2gw\u0027"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"    $neutron_wsgi_script_path   \u003d \u0027/usr/lib/cgi-bin/neutron\u0027"},{"line_number":153,"context_line":"    $neutron_wsgi_script_source \u003d \u0027/usr/bin/neutron-api\u0027"},{"line_number":154,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bf659307_a234dffc","line":151,"range":{"start_line":141,"start_character":0,"end_line":151,"end_character":5},"updated":"2018-04-04 21:57:34.000000000","message":"Just simplify this to...\n    if ($::os_package_type \u003d\u003d \u0027debian\u0027) {\n      $fwaas_package              \u003d \u0027python3-neutron-fwaas\u0027     \n      $l2gw_package               \u003d \u0027python3-networking-l2gw\u0027\n    } else {\n      $fwaas_package              \u003d \u0027python-neutron-fwaas\u0027\n      $l2gw_package               \u003d \u0027python-networking-l2gw\u0027\n    }\n    $l2gw_agent_package         \u003d \u0027neutron-l2gateway-agent\u0027\n\n\nNo need to have multiple if conditions","commit_id":"73651479e9dd83a3e12e248c78606f96c00902c8"}],"spec/classes/neutron_client_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e8eb6bcd8d7d93e592e938271ff0d9e000abf07b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      let :platform_params do"},{"line_number":28,"context_line":"        case fact[:osfamily]"},{"line_number":29,"context_line":"        when \u0027Debian\u0027"},{"line_number":30,"context_line":"          if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":31,"context_line":"            { :client_package \u003d\u003e \u0027python3-neutronclient\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bf659307_6202dc0d","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":17},"updated":"2018-04-10 14:46:40.000000000","message":"is facts not fact","commit_id":"884e6bd18ea4ed7d5b5d9b64d7b578fe7ff9225e"}]}
