)]}'
{"manifests/server.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b388dcb92cbe52fde7815e126a676760389c1a36","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*validate*]"},{"line_number":29,"context_line":"#   (optional) Whether to validate the service is working after any service refreshes"},{"line_number":30,"context_line":"#   Defaults to true"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*log_file*]"},{"line_number":33,"context_line":"#   REMOVED: Use log_file of neutron class instead."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_3966022c","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":20},"updated":"2018-05-14 18:12:12.000000000","message":"I think this should default to false, we should not force this behavior since it hasn\u0027t been there earlier, if Debian needs it we can enable it for Debian only unless this is needed for the other operating systems.","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"805d50a28d4f24dd053be5517557384cabc1ae28","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*validate*]"},{"line_number":29,"context_line":"#   (optional) Whether to validate the service is working after any service refreshes"},{"line_number":30,"context_line":"#   Defaults to true"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*log_file*]"},{"line_number":33,"context_line":"#   REMOVED: Use log_file of neutron class instead."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_caddaae0","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":20},"in_reply_to":"5f7c97a3_3966022c","updated":"2018-05-14 20:03:34.000000000","message":"Sure, will do that in a later patch, right now I\u0027m just testing it.","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b388dcb92cbe52fde7815e126a676760389c1a36","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $enabled                          \u003d true,"},{"line_number":236,"context_line":"  $manage_service                   \u003d true,"},{"line_number":237,"context_line":"  $service_name                     \u003d $::neutron::params::server_service,"},{"line_number":238,"context_line":"  $validate                         \u003d true,"},{"line_number":239,"context_line":"  $database_connection              \u003d undef,"},{"line_number":240,"context_line":"  $database_max_retries             \u003d undef,"},{"line_number":241,"context_line":"  $database_idle_timeout            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_39c122e6","line":238,"range":{"start_line":238,"start_character":38,"end_line":238,"end_character":42},"updated":"2018-05-14 18:12:12.000000000","message":"Same as above","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"805d50a28d4f24dd053be5517557384cabc1ae28","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $enabled                          \u003d true,"},{"line_number":236,"context_line":"  $manage_service                   \u003d true,"},{"line_number":237,"context_line":"  $service_name                     \u003d $::neutron::params::server_service,"},{"line_number":238,"context_line":"  $validate                         \u003d true,"},{"line_number":239,"context_line":"  $database_connection              \u003d undef,"},{"line_number":240,"context_line":"  $database_max_retries             \u003d undef,"},{"line_number":241,"context_line":"  $database_idle_timeout            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_8ae332a4","line":238,"range":{"start_line":238,"start_character":38,"end_line":238,"end_character":42},"in_reply_to":"5f7c97a3_39c122e6","updated":"2018-05-14 20:03:34.000000000","message":"Sure, will do that in a later patch, right now I\u0027m just testing it locally on my laptop.","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b388dcb92cbe52fde7815e126a676760389c1a36","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    $validation_cmd \u003d {"},{"line_number":459,"context_line":"      \u0027neutron-server\u0027 \u003d\u003e {"},{"line_number":460,"context_line":"        # lint:ignore:140chars"},{"line_number":461,"context_line":"        \u0027command\u0027 \u003d\u003e \"openstack --os-auth-url ${::cinder::keystone::authtoken::www_authenticate_uri} --os-project-name ${keystone_project_name} --os-username ${keystone_username} --os-password ${keystone_password} network list\","},{"line_number":462,"context_line":"        # lint:endignore"},{"line_number":463,"context_line":"      }"},{"line_number":464,"context_line":"    }"},{"line_number":465,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_b92772ca","line":462,"range":{"start_line":461,"start_character":8,"end_line":462,"end_character":8},"updated":"2018-05-14 18:12:12.000000000","message":"::cinder is wrong here, also this will output sensitive information in the logs if debug is enabled and show in /proc file system during executing, the same bug that you reported for keystone","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"805d50a28d4f24dd053be5517557384cabc1ae28","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    $validation_cmd \u003d {"},{"line_number":459,"context_line":"      \u0027neutron-server\u0027 \u003d\u003e {"},{"line_number":460,"context_line":"        # lint:ignore:140chars"},{"line_number":461,"context_line":"        \u0027command\u0027 \u003d\u003e \"openstack --os-auth-url ${::cinder::keystone::authtoken::www_authenticate_uri} --os-project-name ${keystone_project_name} --os-username ${keystone_username} --os-password ${keystone_password} network list\","},{"line_number":462,"context_line":"        # lint:endignore"},{"line_number":463,"context_line":"      }"},{"line_number":464,"context_line":"    }"},{"line_number":465,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_ca8b6ac0","line":462,"range":{"start_line":461,"start_character":8,"end_line":462,"end_character":8},"in_reply_to":"5f7c97a3_b92772ca","updated":"2018-05-14 20:03:34.000000000","message":"Yup, saw it, it should be ::neutron. How can I export the password then? Simply OS_PASSWORD\u003d${foo} openstack ... ? I\u0027ll try that if this patch fixes my problem.","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b388dcb92cbe52fde7815e126a676760389c1a36","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        # lint:endignore"},{"line_number":463,"context_line":"      }"},{"line_number":464,"context_line":"    }"},{"line_number":465,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"},{"line_number":466,"context_line":"  }"},{"line_number":467,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_7991daf0","line":465,"range":{"start_line":465,"start_character":4,"end_line":465,"end_character":117},"updated":"2018-05-14 18:12:12.000000000","message":"IMO we should not use create_resources, I don\u0027t like this in the other modules either","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"805d50a28d4f24dd053be5517557384cabc1ae28","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        # lint:endignore"},{"line_number":463,"context_line":"      }"},{"line_number":464,"context_line":"    }"},{"line_number":465,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"},{"line_number":466,"context_line":"  }"},{"line_number":467,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f7c97a3_8aaa5216","line":465,"range":{"start_line":465,"start_character":4,"end_line":465,"end_character":117},"in_reply_to":"5f7c97a3_7991daf0","updated":"2018-05-14 20:03:34.000000000","message":"What should I use if not create_resources?","commit_id":"a25ffe33fedc127b5b79f870236730644fc8aa3c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b9d9c4d916a758e4d30d3cf04f3cc4a5eef0f5b6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $enabled                          \u003d true,"},{"line_number":236,"context_line":"  $manage_service                   \u003d true,"},{"line_number":237,"context_line":"  $service_name                     \u003d $::neutron::params::server_service,"},{"line_number":238,"context_line":"  $validate                         \u003d true,"},{"line_number":239,"context_line":"  $database_connection              \u003d undef,"},{"line_number":240,"context_line":"  $database_max_retries             \u003d undef,"},{"line_number":241,"context_line":"  $database_idle_timeout            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_41a63311","line":238,"updated":"2018-05-16 14:42:21.000000000","message":"So i\u0027m not sure this should be true by default. We use this as false everywhere else.","commit_id":"a000d605e8e29e0b0c3ffed0b17b6b7ca2ecce58"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2b3ea319c09f913b6b0e3a368c6827127be5c536","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  $enabled                          \u003d true,"},{"line_number":236,"context_line":"  $manage_service                   \u003d true,"},{"line_number":237,"context_line":"  $service_name                     \u003d $::neutron::params::server_service,"},{"line_number":238,"context_line":"  $validate                         \u003d true,"},{"line_number":239,"context_line":"  $database_connection              \u003d undef,"},{"line_number":240,"context_line":"  $database_max_retries             \u003d undef,"},{"line_number":241,"context_line":"  $database_idle_timeout            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_21e537dc","line":238,"in_reply_to":"5f7c97a3_41a63311","updated":"2018-05-16 14:55:17.000000000","message":"Done","commit_id":"a000d605e8e29e0b0c3ffed0b17b6b7ca2ecce58"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b9d9c4d916a758e4d30d3cf04f3cc4a5eef0f5b6","unresolved":false,"context_lines":[{"line_number":469,"context_line":"      }"},{"line_number":470,"context_line":"    }"},{"line_number":471,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"},{"line_number":472,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027|\u003e -\u003e Openstacklib::Service_validation\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Neutron_network\u003c||\u003e"},{"line_number":473,"context_line":"  }"},{"line_number":474,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_e1997fc3","line":472,"range":{"start_line":472,"start_character":4,"end_line":472,"end_character":131},"updated":"2018-05-16 14:42:21.000000000","message":"So this should live external to this as this is your workaround for Debian/Ubuntu issues.  Something like this should live in p-o-i where you specifically set $validate to true and throw this in that logic so we only run this for debian. This is a workaround that shouldn\u0027t live in this class","commit_id":"a000d605e8e29e0b0c3ffed0b17b6b7ca2ecce58"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2b3ea319c09f913b6b0e3a368c6827127be5c536","unresolved":false,"context_lines":[{"line_number":469,"context_line":"      }"},{"line_number":470,"context_line":"    }"},{"line_number":471,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $validation_cmd, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[neutron-server]\u0027})"},{"line_number":472,"context_line":"    Service\u003c| title \u003d\u003d \u0027neutron-server\u0027|\u003e -\u003e Openstacklib::Service_validation\u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e -\u003e Neutron_network\u003c||\u003e"},{"line_number":473,"context_line":"  }"},{"line_number":474,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"5f7c97a3_41e873b1","line":472,"range":{"start_line":472,"start_character":4,"end_line":472,"end_character":131},"in_reply_to":"5f7c97a3_e1997fc3","updated":"2018-05-16 14:55:17.000000000","message":"Done","commit_id":"a000d605e8e29e0b0c3ffed0b17b6b7ca2ecce58"}]}
