)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"02381696c11c3cd00fe89ddb020433c777584273","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate of_interface for ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The parameter of_interface was use for OpenFlow"},{"line_number":10,"context_line":"interfaces. This parameter is deprecated in neutron"},{"line_number":11,"context_line":"project so it can be deprecated also in puppet."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f7c97a3_b9d2e5fc","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":34},"updated":"2018-08-02 05:53:32.000000000","message":"used","commit_id":"e29dad89694534106973e9f2cbdf625c593a5ee7"}],"manifests/agents/ml2/ovs.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f41291706fd8910ddec52a0287ae69dedf5c5b6a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      fail(\u0027L2 population must be enabled when DVR and tunneling are enabled\u0027)"},{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":"  }"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if ! (is_service_default($ovsdb_interface)) and ! ($ovsdb_interface \u003d~ /^(vsctl|native)$/) {"},{"line_number":223,"context_line":"    fail(\u0027A value of $ovsdb_interface is incorrect. The allowed values are vsctl and native\u0027)"},{"line_number":224,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f7c97a3_4bcea08f","line":221,"updated":"2018-07-30 13:35:52.000000000","message":"Please add a deprecation warning here if the option is defined.\n\nif ! (is_service_default($of_interface)) { warning(\u0027of_interface is deprecated and will be removed in the future\u0027) }","commit_id":"a30efe1f14a09c7b8ddd3af4a96e5dd25c5685ef"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8ccc155cc50ceed6d88de541251a024d8c63028b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    }"},{"line_number":220,"context_line":"  }"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if ! (is_service_default($of_interface)) {"},{"line_number":223,"context_line":"    warning(\u0027of_interface is deprecated and will be removed in the future\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f7c97a3_963cc52d","line":222,"updated":"2018-07-31 14:08:52.000000000","message":"sorry I think you need to do \"if $of_interface { }\" otherwise the warning will appear all the times.\nThanks","commit_id":"40356ff87a82c162fa5001ae1b8988c0876bc25e"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"48269b3a1ad570b7f396eeb59a975f17a809f3c1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"#   (optional) The vhost-user socket directory for OVS"},{"line_number":122,"context_line":"#   Defaults to $::os_service_default"},{"line_number":123,"context_line":"#"},{"line_number":124,"context_line":"# [*of_interface*]"},{"line_number":125,"context_line":"#   (optional) This option is deprecated an has no effect"},{"line_number":126,"context_line":"#"},{"line_number":127,"context_line":"# [*ovsdb_interface*]"},{"line_number":128,"context_line":"#   (optional) The interface for interacting with the OVSDB"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_a1df3009","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":57},"updated":"2018-07-31 20:03:06.000000000","message":"Move this down, see below.","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fca593e945a153c6e5f4b70c495de64946e7fcf0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"#   (optional) The vhost-user socket directory for OVS"},{"line_number":122,"context_line":"#   Defaults to $::os_service_default"},{"line_number":123,"context_line":"#"},{"line_number":124,"context_line":"# [*of_interface*]"},{"line_number":125,"context_line":"#   (optional) This option is deprecated an has no effect"},{"line_number":126,"context_line":"#"},{"line_number":127,"context_line":"# [*ovsdb_interface*]"},{"line_number":128,"context_line":"#   (optional) The interface for interacting with the OVSDB"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_9da93026","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":57},"in_reply_to":"5f7c97a3_a1df3009","updated":"2018-08-01 06:32:50.000000000","message":"Done","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"48269b3a1ad570b7f396eeb59a975f17a809f3c1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"#  (optional) Minimize polling by monitoring ovsdb for interface"},{"line_number":148,"context_line":"#  changes. (boolean value)"},{"line_number":149,"context_line":"#  Defaults to $::os_service_default"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":152,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":153,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_e1d9a827","line":150,"updated":"2018-07-31 20:03:06.000000000","message":"# DEPRECATED\n#\n# [*of_interface*]\n#   (optional) This option is deprecated an has no effect\n#","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fca593e945a153c6e5f4b70c495de64946e7fcf0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"#  (optional) Minimize polling by monitoring ovsdb for interface"},{"line_number":148,"context_line":"#  changes. (boolean value)"},{"line_number":149,"context_line":"#  Defaults to $::os_service_default"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":152,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":153,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_3da49c4b","line":150,"in_reply_to":"5f7c97a3_e1d9a827","updated":"2018-08-01 06:32:50.000000000","message":"Done","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"48269b3a1ad570b7f396eeb59a975f17a809f3c1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  $tun_peer_patch_port        \u003d $::os_service_default,"},{"line_number":172,"context_line":"  $datapath_type              \u003d $::os_service_default,"},{"line_number":173,"context_line":"  $vhostuser_socket_dir       \u003d $::os_service_default,"},{"line_number":174,"context_line":"  $of_interface               \u003d undef,"},{"line_number":175,"context_line":"  $ovsdb_interface            \u003d $::os_service_default,"},{"line_number":176,"context_line":"  $purge_config               \u003d false,"},{"line_number":177,"context_line":"  $enable_dpdk                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_c1e26cd3","line":174,"range":{"start_line":174,"start_character":2,"end_line":174,"end_character":38},"updated":"2018-07-31 20:03:06.000000000","message":"Same here, see below.","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fca593e945a153c6e5f4b70c495de64946e7fcf0","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  $tun_peer_patch_port        \u003d $::os_service_default,"},{"line_number":172,"context_line":"  $datapath_type              \u003d $::os_service_default,"},{"line_number":173,"context_line":"  $vhostuser_socket_dir       \u003d $::os_service_default,"},{"line_number":174,"context_line":"  $of_interface               \u003d undef,"},{"line_number":175,"context_line":"  $ovsdb_interface            \u003d $::os_service_default,"},{"line_number":176,"context_line":"  $purge_config               \u003d false,"},{"line_number":177,"context_line":"  $enable_dpdk                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_bd3e6ce0","line":174,"range":{"start_line":174,"start_character":2,"end_line":174,"end_character":38},"in_reply_to":"5f7c97a3_c1e26cd3","updated":"2018-08-01 06:32:50.000000000","message":"Done","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"48269b3a1ad570b7f396eeb59a975f17a809f3c1","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  $enable_dpdk                \u003d false,"},{"line_number":178,"context_line":"  $enable_security_group      \u003d $::os_service_default,"},{"line_number":179,"context_line":"  $minimize_polling           \u003d $::os_service_default,"},{"line_number":180,"context_line":") {"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  include ::neutron::deps"},{"line_number":183,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_41ce5c58","line":180,"updated":"2018-07-31 20:03:06.000000000","message":"# DEPRECATED\n  $of_interface               \u003d undef,","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fca593e945a153c6e5f4b70c495de64946e7fcf0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  $enable_dpdk                \u003d false,"},{"line_number":178,"context_line":"  $enable_security_group      \u003d $::os_service_default,"},{"line_number":179,"context_line":"  $minimize_polling           \u003d $::os_service_default,"},{"line_number":180,"context_line":") {"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"  include ::neutron::deps"},{"line_number":183,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5f7c97a3_1d4c409b","line":180,"in_reply_to":"5f7c97a3_41ce5c58","updated":"2018-08-01 06:32:50.000000000","message":"Done","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"02381696c11c3cd00fe89ddb020433c777584273","unresolved":false,"context_lines":[{"line_number":148,"context_line":"# DEPRECATED"},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"# [*of_interface*]"},{"line_number":151,"context_line":"#   (optional) This option is deprecated an has no effect"},{"line_number":152,"context_line":"#"},{"line_number":153,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":154,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5f7c97a3_f99e1d53","line":151,"range":{"start_line":151,"start_character":41,"end_line":151,"end_character":43},"updated":"2018-08-02 05:53:32.000000000","message":"and","commit_id":"e29dad89694534106973e9f2cbdf625c593a5ee7"}],"releasenotes/notes/bug-1734241-a20421a6e3edcc17.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"48269b3a1ad570b7f396eeb59a975f17a809f3c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecate of_interface for ovs. Option not needed anymore"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_61f6f892","line":3,"range":{"start_line":3,"start_character":14,"end_line":3,"end_character":26},"updated":"2018-07-31 20:03:06.000000000","message":"Please add in which class this is so that it\u0027s clear for deployers.","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"},{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"fca593e945a153c6e5f4b70c495de64946e7fcf0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecate of_interface for ovs. Option not needed anymore"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_1828ce82","line":3,"range":{"start_line":3,"start_character":14,"end_line":3,"end_character":26},"in_reply_to":"5f7c97a3_61f6f892","updated":"2018-08-01 06:32:50.000000000","message":"Done","commit_id":"cf051e292d5d913de54e32bfbf95f1d3c06eadae"}]}
