)]}'
{"metadata.json":[{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"0c37d48ad91314e44ff707653d171420fd6232d8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"project_page\": \"https://launchpad.net/puppet-neutron\","},{"line_number":69,"context_line":"    \"requirements\": ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \"name\": \"pe\","},{"line_number":72,"context_line":"            \"version_requirement\": \"4.x\""},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        {"}],"source_content_type":"application/json","patch_set":4,"id":"3f79a3b5_d1452345","side":"PARENT","line":71,"updated":"2018-08-16 21:25:44.000000000","message":"Why is this file being modified as part of this change?","commit_id":"fee69de01ae5ddac3ee7ee0b37b33124c8aa874b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d13728e2341c9646000ae5cb4770899dc665fa83","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"project_page\": \"https://launchpad.net/puppet-neutron\","},{"line_number":69,"context_line":"    \"requirements\": ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \"name\": \"pe\","},{"line_number":72,"context_line":"            \"version_requirement\": \"4.x\""},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        {"}],"source_content_type":"application/json","patch_set":4,"id":"3f79a3b5_91980b1c","side":"PARENT","line":71,"in_reply_to":"3f79a3b5_31b017de","updated":"2018-08-16 21:56:40.000000000","message":"Ok, I\u0027ll remove it and push a separate one.","commit_id":"fee69de01ae5ddac3ee7ee0b37b33124c8aa874b"},{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"0681b8a5f7798a342f563d55c1dcecd12d628cad","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"project_page\": \"https://launchpad.net/puppet-neutron\","},{"line_number":69,"context_line":"    \"requirements\": ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \"name\": \"pe\","},{"line_number":72,"context_line":"            \"version_requirement\": \"4.x\""},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        {"}],"source_content_type":"application/json","patch_set":4,"id":"3f79a3b5_d4a67154","side":"PARENT","line":71,"in_reply_to":"3f79a3b5_91980b1c","updated":"2018-08-16 23:07:38.000000000","message":"Thank you","commit_id":"fee69de01ae5ddac3ee7ee0b37b33124c8aa874b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ebe18db946591f5ab96b9079c65598df1849280d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"project_page\": \"https://launchpad.net/puppet-neutron\","},{"line_number":69,"context_line":"    \"requirements\": ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \"name\": \"pe\","},{"line_number":72,"context_line":"            \"version_requirement\": \"4.x\""},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        {"}],"source_content_type":"application/json","patch_set":4,"id":"3f79a3b5_f11fff06","side":"PARENT","line":71,"in_reply_to":"3f79a3b5_d1452345","updated":"2018-08-16 21:33:51.000000000","message":"http://logs.openstack.org/99/591899/3/check/puppet-openstack-lint/f10faf1/job-output.txt.gz#_2018-08-16_18_53_27_153851\n\nPushed fixes for all modules, but added in this change so it passes without having to rebase on another commit.","commit_id":"fee69de01ae5ddac3ee7ee0b37b33124c8aa874b"},{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"0380e68faac0ec24f6659449db7c522895807fad","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    \"project_page\": \"https://launchpad.net/puppet-neutron\","},{"line_number":69,"context_line":"    \"requirements\": ["},{"line_number":70,"context_line":"        {"},{"line_number":71,"context_line":"            \"name\": \"pe\","},{"line_number":72,"context_line":"            \"version_requirement\": \"4.x\""},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"        {"}],"source_content_type":"application/json","patch_set":4,"id":"3f79a3b5_31b017de","side":"PARENT","line":71,"in_reply_to":"3f79a3b5_f11fff06","updated":"2018-08-16 21:43:51.000000000","message":"I really appreciate your help, but there is one issue. This change will be backported to all other branches and this modification might not be applicable to the other branches.","commit_id":"fee69de01ae5ddac3ee7ee0b37b33124c8aa874b"}],"releasenotes/notes/add-vlan_transparent-config-74028f32b6041daa.yaml":[{"author":{"_account_id":18343,"name":"Lokesh Jain","email":"lokesh.jain@gmail.com","username":"lokesh-jain"},"change_message_id":"fc8e555dee208b0d9449c10a8954ce02777f571b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Allow plugins that support it to create VLAN transparent networks"},{"line_number":4,"context_line":"    The vlan_transparent determines if plugins that support it to"},{"line_number":5,"context_line":"    create VLAN transparent networks or not"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_be6156d6","line":4,"updated":"2018-08-16 20:54:09.000000000","message":"This line sounds repetitive. Could you change it to \"This change allows setting the vlan_transparent value in neutron.conf file\"","commit_id":"e62132cdc039d8114835cf44f3f6f0c0a30f494c"}],"spec/classes/neutron_init_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"3b3469cf301713a9068b4b33ce12c9af1c1768f3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    it_configures \u0027with transport_url defined\u0027"},{"line_number":54,"context_line":"    it_configures \u0027with rootwrap daemon\u0027"},{"line_number":55,"context_line":"    it_configures \u0027with max_allowed_address_pair defined\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    context \u0027with amqp messaging\u0027 do"},{"line_number":58,"context_line":"      it_configures \u0027amqp support\u0027"},{"line_number":59,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_dbd252d1","line":56,"updated":"2018-08-15 07:22:13.000000000","message":"Add them here.","commit_id":"07442ed160e9b8ee5987183b8de7afcb7694cf00"},{"author":{"_account_id":27069,"name":"Sai Ram Peesapati","email":"peesapatisairam@gmail.com","username":"sairamp"},"change_message_id":"8147ed80490173fab7655fab18c3d02c2c873872","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    it_configures \u0027with transport_url defined\u0027"},{"line_number":54,"context_line":"    it_configures \u0027with rootwrap daemon\u0027"},{"line_number":55,"context_line":"    it_configures \u0027with max_allowed_address_pair defined\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    context \u0027with amqp messaging\u0027 do"},{"line_number":58,"context_line":"      it_configures \u0027amqp support\u0027"},{"line_number":59,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_593e43b8","line":56,"in_reply_to":"3f79a3b5_dbd252d1","updated":"2018-08-15 14:27:08.000000000","message":"Thanks for adding them","commit_id":"07442ed160e9b8ee5987183b8de7afcb7694cf00"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"3b3469cf301713a9068b4b33ce12c9af1c1768f3","unresolved":false,"context_lines":[{"line_number":335,"context_line":"    }"},{"line_number":336,"context_line":"  end"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  shared_examples_for  \u0027when disabling vlan_transparent\u0027 do"},{"line_number":339,"context_line":"    before do"},{"line_number":340,"context_line":"      params.merge!("},{"line_number":341,"context_line":"        :vlan_transparent \u003d\u003e false"},{"line_number":342,"context_line":"      )"},{"line_number":343,"context_line":"    end"},{"line_number":344,"context_line":"    it do"},{"line_number":345,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/vlan_transparent\u0027).with_value(false)"},{"line_number":346,"context_line":"    end"},{"line_number":347,"context_line":"  end"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"  shared_examples_for \u0027when enabling vlan_transparent\u0027 do"},{"line_number":350,"context_line":"    before do"},{"line_number":351,"context_line":"      params.merge!("},{"line_number":352,"context_line":"        :vlan_transparent \u003d\u003e true"},{"line_number":353,"context_line":"      )"},{"line_number":354,"context_line":"    end"},{"line_number":355,"context_line":"    it do"},{"line_number":356,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/vlan_transparent\u0027).with_value(true)"},{"line_number":357,"context_line":"    end"},{"line_number":358,"context_line":"  end"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"  shared_examples_for \u0027without service_plugins\u0027 do"},{"line_number":361,"context_line":"    it { is_expected.not_to contain_neutron_config(\u0027DEFAULT/service_plugins\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f79a3b5_fbc94e25","line":358,"range":{"start_line":338,"start_character":2,"end_line":358,"end_character":5},"updated":"2018-08-15 07:22:13.000000000","message":"These are not executed, you need to add these with it_configures in the \u0027neutron\u0027 shared_examples.","commit_id":"07442ed160e9b8ee5987183b8de7afcb7694cf00"}]}
