)]}'
{"manifests/db.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1ccb6c638172a9e8f05bc9fa4cb7fbc8b09a18b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   Url used to connect to database."},{"line_number":9,"context_line":"#   (Optional) Defaults to \u0027sqlite:////var/lib/neutron/ovs.sqlite\u0027."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*slave_connection*]"},{"line_number":12,"context_line":"#   (optional) Connection url to connect to neutron slave database (read-only)."},{"line_number":13,"context_line":"#   Defaults to undef"},{"line_number":14,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fce034c_18765bda","line":11,"updated":"2019-04-11 19:39:29.000000000","message":"Yea let\u0027s do database_slave_connection for consistency","commit_id":"3a3bab9e055cba268e08d3e307810d9a40ad102b"},{"author":{"_account_id":28627,"name":"Julien","email":"julien.cosmao@ovhcloud.com","username":"jcosmao"},"change_message_id":"10a9f8aefe57ad3ef84192151910d1578b02925a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   Url used to connect to database."},{"line_number":9,"context_line":"#   (Optional) Defaults to \u0027sqlite:////var/lib/neutron/ovs.sqlite\u0027."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*slave_connection*]"},{"line_number":12,"context_line":"#   (optional) Connection url to connect to neutron slave database (read-only)."},{"line_number":13,"context_line":"#   Defaults to undef"},{"line_number":14,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fce034c_acfcb83e","line":11,"updated":"2019-04-11 10:12:13.000000000","message":"maybe prefix param with database_ as it will go in [database section]","commit_id":"3a3bab9e055cba268e08d3e307810d9a40ad102b"},{"author":{"_account_id":27442,"name":"Quentin GROLLEAU","email":"quentin.grolleau@corp.ovh.com","username":"QG"},"change_message_id":"3b0eabba636aa6d504f7b99b379aedca3c388e5f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   Url used to connect to database."},{"line_number":9,"context_line":"#   (Optional) Defaults to \u0027sqlite:////var/lib/neutron/ovs.sqlite\u0027."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*slave_connection*]"},{"line_number":12,"context_line":"#   (optional) Connection url to connect to neutron slave database (read-only)."},{"line_number":13,"context_line":"#   Defaults to undef"},{"line_number":14,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fce034c_6f455070","line":11,"in_reply_to":"3fce034c_18765bda","updated":"2019-04-12 07:49:02.000000000","message":"To keep a consistency with the puppet-nova module that already implements this feature I kept the name\n\nhttps://git.openstack.org/cgit/openstack/puppet-nova/tree/manifests/db.pp#n33","commit_id":"3a3bab9e055cba268e08d3e307810d9a40ad102b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e1ccb6c638172a9e8f05bc9fa4cb7fbc8b09a18b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":65,"context_line":"  # to use neutron::\u003cmyparam\u003e if neutron::db::\u003cmyparam\u003e isn\u0027t specified."},{"line_number":66,"context_line":"  $database_connection_real \u003d pick($::neutron::server::database_connection, $database_connection)"},{"line_number":67,"context_line":"  $slave_connection_real \u003d pick($::neutron::server::slave_connection, $slave_connection)"},{"line_number":68,"context_line":"  $database_idle_timeout_real \u003d pick($::neutron::server::database_idle_timeout, $database_idle_timeout)"},{"line_number":69,"context_line":"  $database_min_pool_size_real \u003d pick($::neutron::server::database_min_pool_size, $database_min_pool_size)"},{"line_number":70,"context_line":"  $database_max_pool_size_real \u003d pick($::neutron::server::database_max_pool_size, $database_max_pool_size)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fce034c_387317ea","line":67,"updated":"2019-04-11 19:39:29.000000000","message":"We don\u0027t need this pick because there is no backwards compatibility required for this new param","commit_id":"3a3bab9e055cba268e08d3e307810d9a40ad102b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"647a6bc09de7d4a7eaa3b06981c3d9cffc6686d3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  $database_max_pool_size_real \u003d pick($::neutron::server::database_max_pool_size, $database_max_pool_size)"},{"line_number":70,"context_line":"  $database_max_retries_real \u003d pick($::neutron::server::database_max_retries, $database_max_retries)"},{"line_number":71,"context_line":"  $database_retry_interval_real \u003d pick($::neutron::server::database_retry_interval, $database_retry_interval)"},{"line_number":72,"context_line":"  $database_max_overflow_real \u003d pick($::neutron::server::database_max_overflow, $database_max_overflow)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  validate_legacy(Oslo::Dbconn, \u0027validate_re\u0027, $database_connection_real,"},{"line_number":75,"context_line":"    [\u0027^(sqlite|mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027])"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fce034c_eaf7e7f4","line":72,"updated":"2019-04-12 14:06:54.000000000","message":"Sorry since you added it to neutron::server it needs to have a pick here.  Though we really shouldn\u0027t continue with the neutron::server versions of these variables. I though we deprecated them but i guess not","commit_id":"ede44f2feba95b42e7d365ae740be174bd8e9902"}]}
