)]}'
{"manifests/agents/ml2/mlnx.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fc5bf51b527dd20e74e2e28d0f95e2782a22d1bf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":46,"context_line":"  $eswitchd_service            \u003d $::neutron::params::eswitchd_service"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx\u0027:"},{"line_number":49,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027:"},{"line_number":53,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":56,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/mlnx\u0027],"},{"line_number":57,"context_line":"    mode    \u003d\u003e \u00270640\u0027,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  neutron_mlnx_agent_config {"},{"line_number":61,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027: value \u003d\u003e pick(join(any2array($physical_interface_mappings), \u0027,\u0027), $::os_service_default);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_cc0ccaed","line":58,"range":{"start_line":48,"start_character":0,"end_line":58,"end_character":3},"updated":"2019-08-05 13:43:20.000000000","message":"This would be better handled in packaging. Is there a reason why this can\u0027t be addressed via packaging?","commit_id":"c4855e151689e163caba8bf0e574245de72769e3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2d4f5ed11fd9851ab2fd779a0f54ccd508f054c2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":46,"context_line":"  $eswitchd_service            \u003d $::neutron::params::eswitchd_service"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx\u0027:"},{"line_number":49,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027:"},{"line_number":53,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":56,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/mlnx\u0027],"},{"line_number":57,"context_line":"    mode    \u003d\u003e \u00270640\u0027,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  neutron_mlnx_agent_config {"},{"line_number":61,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027: value \u003d\u003e pick(join(any2array($physical_interface_mappings), \u0027,\u0027), $::os_service_default);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_e7f3df07","line":58,"range":{"start_line":48,"start_character":0,"end_line":58,"end_character":3},"in_reply_to":"7faddb67_672e0f8d","updated":"2019-08-05 14:22:39.000000000","message":"That seems to be an issue with the container rather than being solved here in puppet-neutron.  The container should contain the expected software.  If this is a tripleo specific thing, it might make more sense to put this in puppet-tripleo rather than puppet-neutron.","commit_id":"c4855e151689e163caba8bf0e574245de72769e3"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"74d1d53a133f7306a41643b241c9702f86ef845a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":46,"context_line":"  $eswitchd_service            \u003d $::neutron::params::eswitchd_service"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx\u0027:"},{"line_number":49,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027:"},{"line_number":53,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":56,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/mlnx\u0027],"},{"line_number":57,"context_line":"    mode    \u003d\u003e \u00270640\u0027,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  neutron_mlnx_agent_config {"},{"line_number":61,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027: value \u003d\u003e pick(join(any2array($physical_interface_mappings), \u0027,\u0027), $::os_service_default);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_672e0f8d","line":58,"range":{"start_line":48,"start_character":0,"end_line":58,"end_character":3},"in_reply_to":"7faddb67_cc0ccaed","updated":"2019-08-05 14:16:10.000000000","message":"We run this puppet code in step 3 to create/configure the agent, we do this in a special container \"ContainerNeutronConfigImage\" that doesn\u0027t contain the package.","commit_id":"c4855e151689e163caba8bf0e574245de72769e3"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"fc6a72de913a1372e0e70b568467e26f6c9b98f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":46,"context_line":"  $eswitchd_service            \u003d $::neutron::params::eswitchd_service"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx\u0027:"},{"line_number":49,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  file { \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027:"},{"line_number":53,"context_line":"    ensure  \u003d\u003e file,"},{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":56,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/mlnx\u0027],"},{"line_number":57,"context_line":"    mode    \u003d\u003e \u00270640\u0027,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  neutron_mlnx_agent_config {"},{"line_number":61,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027: value \u003d\u003e pick(join(any2array($physical_interface_mappings), \u0027,\u0027), $::os_service_default);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7faddb67_c7fd836e","line":58,"range":{"start_line":48,"start_character":0,"end_line":58,"end_character":3},"in_reply_to":"7faddb67_e7f3df07","updated":"2019-08-06 07:58:52.000000000","message":"I agree, it would make more sense to move file creation to puppet-tripleo.","commit_id":"c4855e151689e163caba8bf0e574245de72769e3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dc96dea104ffa0012ce5dc76d036f4b9245999fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   (optional) Whether to start/stop the service"},{"line_number":18,"context_line":"#   Defaults to true"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*physical_interface_mappings*]"},{"line_number":21,"context_line":"#   (optional) Array of \u003cphysical_network\u003e:\u003cphysical device\u003e"},{"line_number":22,"context_line":"#   All physical networks listed in network_vlan_ranges"},{"line_number":23,"context_line":"#   on the server should have mappings to appropriate"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_56b3720a","line":20,"updated":"2019-08-06 15:11:31.000000000","message":"this change isn\u0027t backward compatible, you\u0027ll break deployments using that parameter, you should deprecate it properly like:\n\nif !is_service_default($physical_device_mappings) {\n  $physical_interface_mappings_real \u003d $physical_device_mappings\n  warning(\u0027physical_device_mapping is deprecated and replaced by physical_interface_mapping\u0027)\n} else {\n  $physical_interface_mappings_real \u003d $physical_interface_mapping\n}","commit_id":"28d9cf41075775d4aa4b668f1c94472908d23f35"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e4b4e94969b09736d437b8ca97ffa70ec7eac074","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   (optional) Whether to start/stop the service"},{"line_number":18,"context_line":"#   Defaults to true"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*physical_interface_mappings*]"},{"line_number":21,"context_line":"#   (optional) Array of \u003cphysical_network\u003e:\u003cphysical device\u003e"},{"line_number":22,"context_line":"#   All physical networks listed in network_vlan_ranges"},{"line_number":23,"context_line":"#   on the server should have mappings to appropriate"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_7729c587","line":20,"in_reply_to":"7faddb67_56b3720a","updated":"2019-08-06 18:59:47.000000000","message":"I don\u0027t this there backward compatible issue here as this first commit was merged a month ago see [1] \n\n[1] https://review.opendev.org/#/c/668922/","commit_id":"28d9cf41075775d4aa4b668f1c94472908d23f35"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6ecb6f2d43acef2d7b98c033bf9ce2649fb46579","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   polling for local device changes."},{"line_number":30,"context_line":"#   Defaults to \u00272\""},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class neutron::agents::ml2::mlnx ("},{"line_number":34,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":35,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_550c7338","line":32,"updated":"2019-08-11 23:09:21.000000000","message":"nit: remove empty line","commit_id":"28d9cf41075775d4aa4b668f1c94472908d23f35"}]}