)]}'
{"manifests/agents/l3.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d866eb5c7a57c68201bf6d07412bd35a54bd6d77","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $purge_config                     \u003d false,"},{"line_number":115,"context_line":"  $availability_zone                \u003d $::os_service_default,"},{"line_number":116,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $radvd_user                       \u003d \u0027root\u0027,"},{"line_number":118,"context_line":") {"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_24412364","line":117,"updated":"2019-10-29 19:29:17.000000000","message":"In puppet we traditionally use $::os_service_default as to not mask the normal default with our config. The default in the code appears to be \u0027\u0027, so lets use $::os_service_default.","commit_id":"836268e1ad98dd8092e58f37f94ce8a44fe33bff"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"39ae095173b246f7ca09a3f637196c8ffd5b5d12","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $purge_config                     \u003d false,"},{"line_number":115,"context_line":"  $availability_zone                \u003d $::os_service_default,"},{"line_number":116,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $radvd_user                       \u003d \u0027root\u0027,"},{"line_number":118,"context_line":") {"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_67795380","line":117,"in_reply_to":"3fa7e38b_24412364","updated":"2019-10-30 11:20:49.000000000","message":"But this is exactly the problem described in [1][2]. We need this parameter to be \"root\" to allow radvd to run without the problems described when spawned inside a container.\n\n\n[1] https://bugs.launchpad.net/neutron/+bug/1844688\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1751622","commit_id":"836268e1ad98dd8092e58f37f94ce8a44fe33bff"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e0796015190217daed4fc431e5c7c4fc4e447a5c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $purge_config                     \u003d false,"},{"line_number":115,"context_line":"  $availability_zone                \u003d $::os_service_default,"},{"line_number":116,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $radvd_user                       \u003d \u0027root\u0027,"},{"line_number":118,"context_line":") {"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_2a8802c4","line":117,"updated":"2019-10-30 13:09:12.000000000","message":"Since puppet-neutron is used elsewhere and not just in containers, we go with the neutron defaults. Please use $::os_server_default here. If you want to always specify root, do so in tripleo and not in here.  If this is really a bug then it would be a neutron bug to change the default value and not something we would handle in puppet-neutron.","commit_id":"c024718f4d9e6603afe37759f62d8c1068824135"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"453441b02400557c2ab29a0cd63ac53f1555be94","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  $purge_config                     \u003d false,"},{"line_number":115,"context_line":"  $availability_zone                \u003d $::os_service_default,"},{"line_number":116,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":117,"context_line":"  $radvd_user                       \u003d \u0027root\u0027,"},{"line_number":118,"context_line":") {"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_25da73e8","line":117,"in_reply_to":"3fa7e38b_2a8802c4","updated":"2019-10-30 14:00:27.000000000","message":"Done","commit_id":"c024718f4d9e6603afe37759f62d8c1068824135"}]}