)]}'
{"manifests/agents/ml2/ovs.pp":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"05d79cc768c9b2b605bbb6818a0cf64b8669c48f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"#   (optional) The interface for interacting with the OVSDB"},{"line_number":175,"context_line":"#   Allowed values: vsctl, native"},{"line_number":176,"context_line":"#   Defaults to undef"},{"line_number":177,"context_line":"#"},{"line_number":178,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":179,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":180,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_ded52cb9","side":"PARENT","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":1},"updated":"2020-02-17 09:25:48.000000000","message":"nit: You removed this line by accident I assume","commit_id":"46cd24bf1a3eeaf789d890d274d250746ea18f74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd23cb430df1ecc9aa3f0ee6cf8b78af5b3f6803","unresolved":false,"context_lines":[{"line_number":174,"context_line":"#   (optional) The interface for interacting with the OVSDB"},{"line_number":175,"context_line":"#   Allowed values: vsctl, native"},{"line_number":176,"context_line":"#   Defaults to undef"},{"line_number":177,"context_line":"#"},{"line_number":178,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":179,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":180,"context_line":"  $enabled                    \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_2fdacd47","side":"PARENT","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":1},"in_reply_to":"3fa7e38b_ded52cb9","updated":"2020-02-20 10:52:23.000000000","message":"Done","commit_id":"46cd24bf1a3eeaf789d890d274d250746ea18f74"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"47c226bb9a24f769bd1d16d91bff580be4bdb924","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  $tunnel_csum                \u003d $::os_service_default,"},{"line_number":221,"context_line":"  # DEPRECATED"},{"line_number":222,"context_line":"  $ovsdb_interface            \u003d undef,"},{"line_number":223,"context_line":"  $igmp_snooping_enable       \u003d false,"},{"line_number":224,"context_line":") {"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_a4fe1705","line":223,"updated":"2020-02-17 20:31:55.000000000","message":"Is this deprecated? If not it should get moved up. Also this likely should be $::os_service_default","commit_id":"0fd20f6f09faee7d0e1f1be97316d0349d76bb93"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd23cb430df1ecc9aa3f0ee6cf8b78af5b3f6803","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  $tunnel_csum                \u003d $::os_service_default,"},{"line_number":221,"context_line":"  # DEPRECATED"},{"line_number":222,"context_line":"  $ovsdb_interface            \u003d undef,"},{"line_number":223,"context_line":"  $igmp_snooping_enable       \u003d false,"},{"line_number":224,"context_line":") {"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_4fd5c919","line":223,"in_reply_to":"3fa7e38b_a4fe1705","updated":"2020-02-20 10:52:23.000000000","message":"Ops... sorry it\u0027s not. My bad","commit_id":"0fd20f6f09faee7d0e1f1be97316d0349d76bb93"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"#   Allowed values: vsctl, native"},{"line_number":176,"context_line":"#   Defaults to undef"},{"line_number":177,"context_line":"#"},{"line_number":178,"context_line":"# [*igmp_snooping_enable*]"},{"line_number":179,"context_line":"#   (Optional) Enable IGMP snooping for integration bridge. If this"},{"line_number":180,"context_line":"#   option is set to True, support for Internet Group Management"},{"line_number":181,"context_line":"#   Protocol (IGMP) is enabled in integration bridge."},{"line_number":182,"context_line":"#   Setting this option to True will also enable Open vSwitch"},{"line_number":183,"context_line":"#   mcast-snooping-disable-flood-unregistered flag. This option will"},{"line_number":184,"context_line":"#   disable flooding of unregistered multicast packets to all ports."},{"line_number":185,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":186,"context_line":"#   connected to multicast routers."},{"line_number":187,"context_line":"#   Defaults to false."},{"line_number":188,"context_line":"#"},{"line_number":189,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":190,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_58f7bb29","line":187,"range":{"start_line":178,"start_character":0,"end_line":187,"end_character":22},"updated":"2020-02-21 12:33:15.000000000","message":"This comment should be placed before L171 (DEPRECATED).\n\nAlso, does it make sense to add a note saying this is valid for ml2-ovs deployment ?","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":175,"context_line":"#   Allowed values: vsctl, native"},{"line_number":176,"context_line":"#   Defaults to undef"},{"line_number":177,"context_line":"#"},{"line_number":178,"context_line":"# [*igmp_snooping_enable*]"},{"line_number":179,"context_line":"#   (Optional) Enable IGMP snooping for integration bridge. If this"},{"line_number":180,"context_line":"#   option is set to True, support for Internet Group Management"},{"line_number":181,"context_line":"#   Protocol (IGMP) is enabled in integration bridge."},{"line_number":182,"context_line":"#   Setting this option to True will also enable Open vSwitch"},{"line_number":183,"context_line":"#   mcast-snooping-disable-flood-unregistered flag. This option will"},{"line_number":184,"context_line":"#   disable flooding of unregistered multicast packets to all ports."},{"line_number":185,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":186,"context_line":"#   connected to multicast routers."},{"line_number":187,"context_line":"#   Defaults to false."},{"line_number":188,"context_line":"#"},{"line_number":189,"context_line":"class neutron::agents::ml2::ovs ("},{"line_number":190,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1fa4df85_02c524f1","line":187,"range":{"start_line":178,"start_character":0,"end_line":187,"end_character":22},"in_reply_to":"3fa7e38b_58f7bb29","updated":"2020-03-03 09:52:29.000000000","message":"Ops... Will move it.\n\nSure I\u0027ll add a note about ml2-ovs.","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $permitted_ethertypes       \u003d $::os_service_default,"},{"line_number":220,"context_line":"  $minimize_polling           \u003d $::os_service_default,"},{"line_number":221,"context_line":"  $tunnel_csum                \u003d $::os_service_default,"},{"line_number":222,"context_line":"  $igmp_snooping_enable       \u003d false,"},{"line_number":223,"context_line":"  # DEPRECATED"},{"line_number":224,"context_line":"  $ovsdb_interface            \u003d undef,"},{"line_number":225,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_38043f13","line":222,"range":{"start_line":222,"start_character":32,"end_line":222,"end_character":38},"updated":"2020-02-21 12:33:15.000000000","message":"It would be better to replace this by $::os_service_default, as Alex suggested.","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":219,"context_line":"  $permitted_ethertypes       \u003d $::os_service_default,"},{"line_number":220,"context_line":"  $minimize_polling           \u003d $::os_service_default,"},{"line_number":221,"context_line":"  $tunnel_csum                \u003d $::os_service_default,"},{"line_number":222,"context_line":"  $igmp_snooping_enable       \u003d false,"},{"line_number":223,"context_line":"  # DEPRECATED"},{"line_number":224,"context_line":"  $ovsdb_interface            \u003d undef,"},{"line_number":225,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1fa4df85_c2baac6c","line":222,"range":{"start_line":222,"start_character":32,"end_line":222,"end_character":38},"in_reply_to":"3fa7e38b_38043f13","updated":"2020-03-03 09:52:29.000000000","message":"OK, I will change it. Thanks","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f344fc72bdb96bda1d1741a4ee428cfcf546b307","unresolved":false,"context_lines":[{"line_number":178,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":179,"context_line":"#   connected to multicast routers. This option is used by the ML2/OVS"},{"line_number":180,"context_line":"#   mechanism driver for Neutron."},{"line_number":181,"context_line":"#   Defaults to false."},{"line_number":182,"context_line":"#"},{"line_number":183,"context_line":"# DEPRECATED"},{"line_number":184,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_08d9c37d","line":181,"range":{"start_line":181,"start_character":16,"end_line":181,"end_character":21},"updated":"2020-03-03 11:25:49.000000000","message":"$::os_service_default","commit_id":"c41cd972ea9731cac7a8e2d95f569f59b81d6c0f"}],"manifests/server.pp":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"05d79cc768c9b2b605bbb6818a0cf64b8669c48f","unresolved":false,"context_lines":[{"line_number":246,"context_line":"# [*ovs_integration_bridge*]"},{"line_number":247,"context_line":"#   (Optional) Name of Open vSwitch bridge to use"},{"line_number":248,"context_line":"#   Defaults to $::os_service_default"},{"line_number":249,"context_line":"#"},{"line_number":250,"context_line":"class neutron::server ("},{"line_number":251,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"},{"line_number":252,"context_line":"  $enabled                          \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_fed028c8","side":"PARENT","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":1},"updated":"2020-02-17 09:25:48.000000000","message":"ditto","commit_id":"46cd24bf1a3eeaf789d890d274d250746ea18f74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd23cb430df1ecc9aa3f0ee6cf8b78af5b3f6803","unresolved":false,"context_lines":[{"line_number":246,"context_line":"# [*ovs_integration_bridge*]"},{"line_number":247,"context_line":"#   (Optional) Name of Open vSwitch bridge to use"},{"line_number":248,"context_line":"#   Defaults to $::os_service_default"},{"line_number":249,"context_line":"#"},{"line_number":250,"context_line":"class neutron::server ("},{"line_number":251,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"},{"line_number":252,"context_line":"  $enabled                          \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_6fd8c550","side":"PARENT","line":249,"range":{"start_line":249,"start_character":0,"end_line":249,"end_character":1},"in_reply_to":"3fa7e38b_fed028c8","updated":"2020-02-20 10:52:23.000000000","message":"Done","commit_id":"46cd24bf1a3eeaf789d890d274d250746ea18f74"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":247,"context_line":"#   (Optional) Name of Open vSwitch bridge to use"},{"line_number":248,"context_line":"#   Defaults to $::os_service_default"},{"line_number":249,"context_line":"#"},{"line_number":250,"context_line":"# [*igmp_snooping_enable*]"},{"line_number":251,"context_line":"#   (Optional) Enable IGMP snooping for integration bridge. If this"},{"line_number":252,"context_line":"#   option is set to True, support for Internet Group Management"},{"line_number":253,"context_line":"#   Protocol (IGMP) is enabled in integration bridge."},{"line_number":254,"context_line":"#   Setting this option to True will also enable Open vSwitch"},{"line_number":255,"context_line":"#   mcast-snooping-disable-flood-unregistered flag. This option will"},{"line_number":256,"context_line":"#   disable flooding of unregistered multicast packets to all ports."},{"line_number":257,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":258,"context_line":"#   connected to multicast routers."},{"line_number":259,"context_line":"#   Defaults to false."},{"line_number":260,"context_line":"#"},{"line_number":261,"context_line":"class neutron::server ("},{"line_number":262,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"},{"line_number":263,"context_line":"  $enabled                          \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_78487760","line":260,"range":{"start_line":250,"start_character":0,"end_line":260,"end_character":1},"updated":"2020-02-21 12:33:15.000000000","message":"does it make sense to add a note saying this is valid for ml2-ovn deployment ?","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":247,"context_line":"#   (Optional) Name of Open vSwitch bridge to use"},{"line_number":248,"context_line":"#   Defaults to $::os_service_default"},{"line_number":249,"context_line":"#"},{"line_number":250,"context_line":"# [*igmp_snooping_enable*]"},{"line_number":251,"context_line":"#   (Optional) Enable IGMP snooping for integration bridge. If this"},{"line_number":252,"context_line":"#   option is set to True, support for Internet Group Management"},{"line_number":253,"context_line":"#   Protocol (IGMP) is enabled in integration bridge."},{"line_number":254,"context_line":"#   Setting this option to True will also enable Open vSwitch"},{"line_number":255,"context_line":"#   mcast-snooping-disable-flood-unregistered flag. This option will"},{"line_number":256,"context_line":"#   disable flooding of unregistered multicast packets to all ports."},{"line_number":257,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":258,"context_line":"#   connected to multicast routers."},{"line_number":259,"context_line":"#   Defaults to false."},{"line_number":260,"context_line":"#"},{"line_number":261,"context_line":"class neutron::server ("},{"line_number":262,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"},{"line_number":263,"context_line":"  $enabled                          \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1fa4df85_62b3b899","line":260,"range":{"start_line":250,"start_character":0,"end_line":260,"end_character":1},"in_reply_to":"3fa7e38b_78487760","updated":"2020-03-03 09:52:29.000000000","message":"Sure, I will add a note about ml2-ovn","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  $enable_proxy_headers_parsing     \u003d $::os_service_default,"},{"line_number":304,"context_line":"  $max_request_body_size            \u003d $::os_service_default,"},{"line_number":305,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":306,"context_line":"  $igmp_snooping_enable             \u003d false,"},{"line_number":307,"context_line":") inherits ::neutron::params {"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_d80acb1d","line":306,"range":{"start_line":306,"start_character":38,"end_line":306,"end_character":44},"updated":"2020-02-21 12:33:15.000000000","message":"ditto. replace this by $::os:service_default so that we unset the parameter and use the default value defined in neutron itself.","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  $enable_proxy_headers_parsing     \u003d $::os_service_default,"},{"line_number":304,"context_line":"  $max_request_body_size            \u003d $::os_service_default,"},{"line_number":305,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":306,"context_line":"  $igmp_snooping_enable             \u003d false,"},{"line_number":307,"context_line":") inherits ::neutron::params {"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1fa4df85_22a94023","line":306,"range":{"start_line":306,"start_character":38,"end_line":306,"end_character":44},"in_reply_to":"3fa7e38b_d80acb1d","updated":"2020-03-03 09:52:29.000000000","message":"done","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f344fc72bdb96bda1d1741a4ee428cfcf546b307","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#   The switch will send unregistered multicast packets only to ports"},{"line_number":258,"context_line":"#   connected to multicast routers. This option is used by the ML2/OVN"},{"line_number":259,"context_line":"#   mechanism driver for Neutron."},{"line_number":260,"context_line":"#   Defaults to false."},{"line_number":261,"context_line":"#"},{"line_number":262,"context_line":"class neutron::server ("},{"line_number":263,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1fa4df85_c8ce4bb3","line":260,"range":{"start_line":260,"start_character":16,"end_line":260,"end_character":21},"updated":"2020-03-03 11:25:49.000000000","message":"$::os_service_default","commit_id":"c41cd972ea9731cac7a8e2d95f569f59b81d6c0f"}],"spec/classes/neutron_agents_ml2_ovs_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      })"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    it \u0027configures plugins/ml2/openvswitch_agent.ini\u0027 do"},{"line_number":44,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/polling_interval\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":45,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/l2_population\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":46,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/arp_responder\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_f82ea78c","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":56},"updated":"2020-02-21 12:33:15.000000000","message":"it would be better to add a test case to ensure that the default value is set.","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      })"},{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    it \u0027configures plugins/ml2/openvswitch_agent.ini\u0027 do"},{"line_number":44,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/polling_interval\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":45,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/l2_population\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":46,"context_line":"      should contain_neutron_agent_ovs(\u0027agent/arp_responder\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1fa4df85_42a6bc55","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":56},"in_reply_to":"3fa7e38b_f82ea78c","updated":"2020-03-03 09:52:29.000000000","message":"++","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"}],"spec/classes/neutron_server_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3dfc6d8b427c0ac992537a7b39c91d81e50db6f3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      end"},{"line_number":57,"context_line":"    end"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    it \u0027configures neutron server service\u0027 do"},{"line_number":60,"context_line":"      should contain_service(\u0027neutron-server\u0027).with("},{"line_number":61,"context_line":"        :name    \u003d\u003e platform_params[:server_service],"},{"line_number":62,"context_line":"        :enable  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3fa7e38b_b8282f7f","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":45},"updated":"2020-02-21 12:33:15.000000000","message":"it would be better to add a test case to ensure that the default value is set.","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6d2f972afed0eb992ad318f028b3cbdacede7dee","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      end"},{"line_number":57,"context_line":"    end"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    it \u0027configures neutron server service\u0027 do"},{"line_number":60,"context_line":"      should contain_service(\u0027neutron-server\u0027).with("},{"line_number":61,"context_line":"        :name    \u003d\u003e platform_params[:server_service],"},{"line_number":62,"context_line":"        :enable  \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1fa4df85_026a04ed","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":45},"in_reply_to":"3fa7e38b_b8282f7f","updated":"2020-03-03 09:52:29.000000000","message":"++","commit_id":"c5119192474c159daa829535e8f477cafc6b2a73"}]}