)]}'
{"manifests/agents/ml2/ovs.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ae8b7528efb19578a45efd9ca97b528758ff878b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    }"},{"line_number":311,"context_line":"  }"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  if ($resource_provider_bandwidths !\u003d []) {"},{"line_number":314,"context_line":"    $res_prov_bw_map_str \u003d join(any2array($resource_provider_bandwidths), \u0027,\u0027)"},{"line_number":315,"context_line":"    neutron_agent_ovs {"},{"line_number":316,"context_line":"      \u0027ovs/resource_provider_bandwidths\u0027: value \u003d\u003e $res_prov_bw_map_str;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f4c43b2_accae16a","line":313,"range":{"start_line":313,"start_character":1,"end_line":313,"end_character":44},"updated":"2020-04-16 08:30:23.000000000","message":"Just a note for the future, IMO the most proper way would be to do \"if (length($resource_provider_bandwidths) \u003e 0)\" here but since we don\u0027t enforce strict data types for parameters yet and is_array() in stdlib is deprecated this is probably fine. The statement would be true if somebody passed strings etc etc.","commit_id":"55f263853efae72bb0096c8509e311cc38b8bde4"}],"manifests/agents/ml2/sriov.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0dfcbb649fcb0bc16fd5518df627068246d97ff5","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  if ($resource_provider_bandwidths !\u003d []) {"},{"line_number":132,"context_line":"    $res_prov_bw_map_str \u003d join(any2array($resource_provider_bandwidths), \u0027,\u0027)"},{"line_number":133,"context_line":"    neutron_agent_ovs {"},{"line_number":134,"context_line":"      \u0027sriov_nic/resource_provider_bandwidths\u0027: value \u003d\u003e $res_prov_bw_map_str;"},{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f423b7e_6d2661ba","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":21},"updated":"2020-04-11 04:27:29.000000000","message":"According to the mentioned patch it seems that this should be neutron_sriov_agent_config. My I ask your double-check about that ?","commit_id":"354fef2c1a6acd77ed19368b36faa111d9ccb9f7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"42aa228b3af2d16f9ba509cacac341539cbb5986","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  if ($resource_provider_bandwidths !\u003d []) {"},{"line_number":132,"context_line":"    $res_prov_bw_map_str \u003d join(any2array($resource_provider_bandwidths), \u0027,\u0027)"},{"line_number":133,"context_line":"    neutron_agent_ovs {"},{"line_number":134,"context_line":"      \u0027sriov_nic/resource_provider_bandwidths\u0027: value \u003d\u003e $res_prov_bw_map_str;"},{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f4c43b2_147cccb3","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":21},"in_reply_to":"7f423b7e_6d2661ba","updated":"2020-04-15 15:46:43.000000000","message":"That\u0027s right. Wrong copy-paste :)","commit_id":"354fef2c1a6acd77ed19368b36faa111d9ccb9f7"}],"manifests/plugins/ml2/mech_driver.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"eec5e68de5fa1c39d938cfd592c0c689ce8e2ce1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (required) Supported PCI vendor devices, defined by vendor_id:product_id according"},{"line_number":24,"context_line":"#   to the PCI ID Repository. Default enables support for Intel and Mellanox SR-IOV capable NICs"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*ovs_vnic_type_blacklist*]"},{"line_number":27,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":28,"context_line":"#  administratively prohibited by the OVS mechanism driver"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*sriov_vnic_type_blacklist*]"},{"line_number":31,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":32,"context_line":"#  administratively prohibited by the SR-IOV mechanism driver"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":35,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":36,"context_line":"  $ovs_vnic_type_blacklist      \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f4c43b2_589ae962","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"updated":"2020-04-16 21:21:47.000000000","message":"I\u0027m just curious but why we need these parameters related to resource_provider_bandwidth ?","commit_id":"9c8dce525526e6154d65525964fbb16932be3262"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d8fafee2def9eccb0a066a95e70cba0bb2efc447","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (required) Supported PCI vendor devices, defined by vendor_id:product_id according"},{"line_number":24,"context_line":"#   to the PCI ID Repository. Default enables support for Intel and Mellanox SR-IOV capable NICs"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*ovs_vnic_type_blacklist*]"},{"line_number":27,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":28,"context_line":"#  administratively prohibited by the OVS mechanism driver"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*sriov_vnic_type_blacklist*]"},{"line_number":31,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":32,"context_line":"#  administratively prohibited by the SR-IOV mechanism driver"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":35,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":36,"context_line":"  $ovs_vnic_type_blacklist      \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f4c43b2_d52b577f","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"3f4c43b2_589ae962","updated":"2020-04-17 11:20:57.000000000","message":"it is needed in neutron to to allow (or not) certain types of vnic types for some drivers, for example, when you have vnic direct in sriov or ovs, and you want to block this vnic for one of them","commit_id":"9c8dce525526e6154d65525964fbb16932be3262"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92ba66683fd8e25aa766d30edbb2e629a2df55c6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#   (required) Supported PCI vendor devices, defined by vendor_id:product_id according"},{"line_number":24,"context_line":"#   to the PCI ID Repository. Default enables support for Intel and Mellanox SR-IOV capable NICs"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*ovs_vnic_type_blacklist*]"},{"line_number":27,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":28,"context_line":"#  administratively prohibited by the OVS mechanism driver"},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*sriov_vnic_type_blacklist*]"},{"line_number":31,"context_line":"#  (optional) list of VNIC types for which support in Neutron is"},{"line_number":32,"context_line":"#  administratively prohibited by the SR-IOV mechanism driver"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":35,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":36,"context_line":"  $ovs_vnic_type_blacklist      \u003d [],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f4c43b2_1512dfb1","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"3f4c43b2_d52b577f","updated":"2020-04-17 11:55:55.000000000","message":"I understand what these are for, but still these parameters look unrelated to resource_provider_bandwidth for me.\n\nBut I don\u0027t have big objections agaist including these parameters here because seems like these parameters are actually added into tht during implementing resource_provider_bandwitdh so can be somehow related. :-)\n\nThanks for your explanation.","commit_id":"9c8dce525526e6154d65525964fbb16932be3262"}],"spec/classes/neutron_agents_ml2_sriov_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74102789168f427ee27de22a7dd87e25b34af191","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    end"},{"line_number":147,"context_line":"  end"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  on_supported_os({"},{"line_number":151,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"},{"line_number":152,"context_line":"  }).each do |os,facts|"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3f4c43b2_28a7eb51","line":149,"updated":"2020-04-15 15:49:21.000000000","message":"we don\u0027t need this line.","commit_id":"03312b716b2427a781dc4d912ff62e8480db5334"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a7b0e106a7333f453770c70396387c28fa6f4d96","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    end"},{"line_number":147,"context_line":"  end"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  on_supported_os({"},{"line_number":151,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"},{"line_number":152,"context_line":"  }).each do |os,facts|"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3f4c43b2_3ed6fef2","line":149,"in_reply_to":"3f4c43b2_28a7eb51","updated":"2020-04-15 19:38:57.000000000","message":"Sorry, it was added by mistake :)","commit_id":"03312b716b2427a781dc4d912ff62e8480db5334"}]}