)]}'
{"lib/puppet/provider/neutron_uwsgi_config/openstackconfig.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe1e643932a5d39dca26e4ea227c76ece4fbc964","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_uwsgi_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_e30f5285","line":1,"updated":"2020-05-20 01:53:50.000000000","message":"Please add unit tests for this.\nRefer spec/unit/type to find existing tests.","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2ececbf2fa4827487b12ef4a31b527f12cfdc27a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:neutron_uwsgi_config).provide("},{"line_number":2,"context_line":"  :openstackconfig,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_9df22e99","line":1,"in_reply_to":"ff570b3c_e30f5285","updated":"2020-05-20 12:15:34.000000000","message":"Done","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"}],"lib/puppet/type/neutron_uwsgi_config.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe1e643932a5d39dca26e4ea227c76ece4fbc964","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_2325ca09","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"updated":"2020-05-20 01:53:50.000000000","message":"Ditto. Needs tests.","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2ececbf2fa4827487b12ef4a31b527f12cfdc27a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_c0d83954","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"in_reply_to":"ff570b3c_2325ca09","updated":"2020-05-20 12:15:34.000000000","message":"I\u0027m really not sure how to test this. Can you point at some place where to look for an example?","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"07edada48ee7b454fd477950970c3962a2ba3d04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_aa583b56","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"in_reply_to":"ff570b3c_2b0bbf8d","updated":"2020-05-26 08:53:51.000000000","message":"Done","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6ae105fbf35a6550ec139ef2d7924fdf5c7d4e5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_eb41c7a7","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"in_reply_to":"ff570b3c_2b0bbf8d","updated":"2020-05-21 12:56:00.000000000","message":"seems like you have added tests for type, then you can add tests also for provider like;\n\n spec/unit/provider/neutron_sfc_service_config/openstackconfig_spec.rb","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e5793697931d4898ed82bc6ff2d906d094ec9e3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_2b0bbf8d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"in_reply_to":"ff570b3c_c0d83954","updated":"2020-05-21 12:54:17.000000000","message":"I expect something like;\n\n spec/unit/type/neutron_api_paste_ini_spec.rb","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"07edada48ee7b454fd477950970c3962a2ba3d04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.newtype(:neutron_uwsgi_config) do"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  ensurable"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_8a557720","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":46},"in_reply_to":"ff570b3c_eb41c7a7","updated":"2020-05-26 08:53:51.000000000","message":"Done","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"}],"manifests/server.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe1e643932a5d39dca26e4ea227c76ece4fbc964","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e $service_providers;"},{"line_number":409,"context_line":"    \u0027ovs/igmp_snooping_enable\u0027:                 value \u003d\u003e $igmp_snooping_enable;"},{"line_number":410,"context_line":"  }"},{"line_number":411,"context_line":"  if $::os_package_type \u003d\u003d\u0027debian\u0027 and $api_workers {"},{"line_number":412,"context_line":"    neutron_uwsgi_config {"},{"line_number":413,"context_line":"      \u0027uwsgi/processes\u0027: value \u003d\u003e $api_workers;"},{"line_number":414,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff570b3c_233caa2d","line":411,"range":{"start_line":411,"start_character":39,"end_line":411,"end_character":52},"updated":"2020-05-20 01:53:50.000000000","message":"Can we remove this ? $api_workers is set with $os_workers by default, and we can expect to have valid integer always, as we do for neutron_config. (Thought it\u0027s not validated :-P)","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2ececbf2fa4827487b12ef4a31b527f12cfdc27a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e $service_providers;"},{"line_number":409,"context_line":"    \u0027ovs/igmp_snooping_enable\u0027:                 value \u003d\u003e $igmp_snooping_enable;"},{"line_number":410,"context_line":"  }"},{"line_number":411,"context_line":"  if $::os_package_type \u003d\u003d\u0027debian\u0027 and $api_workers {"},{"line_number":412,"context_line":"    neutron_uwsgi_config {"},{"line_number":413,"context_line":"      \u0027uwsgi/processes\u0027: value \u003d\u003e $api_workers;"},{"line_number":414,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ff570b3c_c03319aa","line":411,"range":{"start_line":411,"start_character":39,"end_line":411,"end_character":52},"in_reply_to":"ff570b3c_233caa2d","updated":"2020-05-20 12:15:34.000000000","message":"Done","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"}],"spec/classes/neutron_api_uwsgi.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fe1e643932a5d39dca26e4ea227c76ece4fbc964","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027neutron::config\u0027 do"},{"line_number":4,"context_line":"  let(:config_hash) do {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_a330ba57","line":1,"updated":"2020-05-20 01:53:50.000000000","message":"This file is not loaded during unit tests because the filename doesn\u0027t ends with _spec.\n\nAlso, what is the change these tests cover ? I don\u0027t see any according manifest file added.\nIMO we should add support for config.pp and add this testing in neutron_config_spec.rb","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2ececbf2fa4827487b12ef4a31b527f12cfdc27a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027neutron::config\u0027 do"},{"line_number":4,"context_line":"  let(:config_hash) do {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ff570b3c_a01a6513","line":1,"in_reply_to":"ff570b3c_a330ba57","updated":"2020-05-20 12:15:34.000000000","message":"Done","commit_id":"7b7043054e823188516ad3283b22670f848c24e3"}],"spec/classes/neutron_api_uwsgi_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c25ffc3ea3c12d457d8366cb300128a1699fed1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027neutron::config\u0027 do"},{"line_number":4,"context_line":"  let(:config_hash) do {"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"ff570b3c_ebf6e75c","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":21},"updated":"2020-05-21 13:00:49.000000000","message":"All of the tests under spec/classes and spec/defines should correspond to each files under manifests. We don\u0027t have manifests/neutron_api_uwsgi.pp so it\u0027s not appropriate to have this file here.\nRegarding the fact that neutron::config doesn\u0027t accept api_config, this seems to be completely broken but skipped because we don\u0027t cover debian in our unit tests atm.\n\nWhat you should do is;\n- Add some test cases to spec/classes/neutron_server_spec.rb to test changes in manifests/server.pp\n- Add implementation of the parameter to override config for uwsgi_conf in manifests/config.pp and implement tests for that change in spec/classes/neutron_config_spec.rb","commit_id":"54ecd6caef165a12323b2c9213a3329d7e10edd4"}]}