)]}'
{"manifests/plugins/ml2/nuage.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9ec707490f949722859a468f63f40706ba288dff","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027PLUGIN/default_allow_non_ip\u0027:          value \u003d\u003e $nuage_default_allow_non_ip;"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  if $::neutron::core_plugin !\u003d \u0027ml2\u0027 or !(\u0027nuage\u0027 in $::neutron::plugins::ml2::mechanism_drivers) {"},{"line_number":111,"context_line":"    fail(\u0027Nuage should be the mechanism driver in neutron.conf\u0027)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf51134e_71408c36","side":"PARENT","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":100},"updated":"2020-07-07 23:39:55.000000000","message":"Can you describe some details about plugins available in nuage integration nowadays ?\n\nI\u0027ve checked a bit old implementation available on github[1], but this validation logic looks valid.\n\n[1] https://github.com/nuagenetworks/nuage-openstack-neutron/blob/master/setup.cfg#L56-L60\n\nI don\u0027t intend to disagree strongly to the Nuage items proposed by Nokia guys, but would like to understand the changes you implemented, which affects this logic.","commit_id":"de2be7503caff6bb1bd2ab3865f2da8913fa0c5b"},{"author":{"_account_id":13988,"name":"Vlad Gridin","email":"vladyslav.gridin@nokia.com","username":"gridinv"},"change_message_id":"aecb9b1d30c6fb11539f5bb4ec6c1a9cfdeb66ee","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    \u0027PLUGIN/default_allow_non_ip\u0027:          value \u003d\u003e $nuage_default_allow_non_ip;"},{"line_number":108,"context_line":"  }"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  if $::neutron::core_plugin !\u003d \u0027ml2\u0027 or !(\u0027nuage\u0027 in $::neutron::plugins::ml2::mechanism_drivers) {"},{"line_number":111,"context_line":"    fail(\u0027Nuage should be the mechanism driver in neutron.conf\u0027)"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf51134e_42d77850","side":"PARENT","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":100},"in_reply_to":"bf51134e_71408c36","updated":"2020-07-08 06:04:34.000000000","message":"\u0027nuage\u0027 and \u0027nuage_hwvtep\u0027 ml2 mechanism drivers are mutualy exclusive.\nCheck for string in array will fail for \u0027nuage_hwvtep\u0027 mechanism driver.\nBut You are right, instead of removing this completely, it can be changed\nto use regex. Will upload new patchset.","commit_id":"de2be7503caff6bb1bd2ab3865f2da8913fa0c5b"}]}