)]}'
{"manifests/agents/ml2/ovs.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"78d8f09bb389838afff0783a927923e6d3532dae","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"  neutron_agent_ovs {"},{"line_number":338,"context_line":"    \u0027ovs/resource_provider_bandwidths\u0027:  value \u003d\u003e $resource_provider_bandwidths_real;"},{"line_number":339,"context_line":"    \u0027ovs/resource_provider_hypervisors\u0027: value \u003d\u003e $resource_provider_hypervisors_real; "},{"line_number":340,"context_line":"  }"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"  # TODO(tobias.urdin): Remove in V release."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f621f24_8a55a8fc","line":339,"updated":"2020-11-17 12:53:39.000000000","message":"eoln ws","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"21bc50db22af6c09eb12d5d998a4fca7af138f1f","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"  neutron_agent_ovs {"},{"line_number":338,"context_line":"    \u0027ovs/resource_provider_bandwidths\u0027:  value \u003d\u003e $resource_provider_bandwidths_real;"},{"line_number":339,"context_line":"    \u0027ovs/resource_provider_hypervisors\u0027: value \u003d\u003e $resource_provider_hypervisors_real; "},{"line_number":340,"context_line":"  }"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"  # TODO(tobias.urdin): Remove in V release."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f621f24_ea97fc43","line":339,"in_reply_to":"1f621f24_8a55a8fc","updated":"2020-11-17 13:16:20.000000000","message":"Done","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"}],"manifests/agents/ml2/sriov.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"78d8f09bb389838afff0783a927923e6d3532dae","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  neutron_sriov_agent_config {"},{"line_number":149,"context_line":"    \u0027sriov_nic/resource_provider_bandwidths\u0027:  value \u003d\u003e $resource_provider_bandwidths_real;"},{"line_number":150,"context_line":"    \u0027sriov_nic/resource_provider_hypervisors\u0027: value \u003d\u003e $resource_provider_hypervisors_real;"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f621f24_aa3d04bc","line":149,"updated":"2020-11-17 12:53:39.000000000","message":"do we have a convention for aligning colons in code like this?","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"21bc50db22af6c09eb12d5d998a4fca7af138f1f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"  }"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  neutron_sriov_agent_config {"},{"line_number":149,"context_line":"    \u0027sriov_nic/resource_provider_bandwidths\u0027:  value \u003d\u003e $resource_provider_bandwidths_real;"},{"line_number":150,"context_line":"    \u0027sriov_nic/resource_provider_hypervisors\u0027: value \u003d\u003e $resource_provider_hypervisors_real;"},{"line_number":151,"context_line":"  }"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1f621f24_caa4c0a8","line":149,"in_reply_to":"1f621f24_aa3d04bc","updated":"2020-11-17 13:16:20.000000000","message":"IIRC we need to align \"\u003d\u003e\" because it is enforced by lint, but don\u0027t need align \":\".\nIn most of the modules we have left \":\" not aligned, so I followed that here.","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"}],"spec/classes/neutron_agents_ml2_sriov_spec.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"78d8f09bb389838afff0783a927923e6d3532dae","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        should contain_neutron_sriov_agent_config(\u0027sriov_nic/resource_provider_bandwidths\u0027).\\"},{"line_number":148,"context_line":"          with_value(\u0027provider-a,provider-b\u0027)"},{"line_number":149,"context_line":"        should contain_neutron_sriov_agent_config(\u0027sriov_nic/resource_provider_hypervisors\u0027).\\"},{"line_number":150,"context_line":"          with_value(\u0027provider-a:compute-a,provider-b:compute-b\u0027) }"},{"line_number":151,"context_line":"      end"},{"line_number":152,"context_line":"    end"},{"line_number":153,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_2a89f473","line":150,"updated":"2020-11-17 12:53:39.000000000","message":"unexpected \u0027}\u0027?","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"21bc50db22af6c09eb12d5d998a4fca7af138f1f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        should contain_neutron_sriov_agent_config(\u0027sriov_nic/resource_provider_bandwidths\u0027).\\"},{"line_number":148,"context_line":"          with_value(\u0027provider-a,provider-b\u0027)"},{"line_number":149,"context_line":"        should contain_neutron_sriov_agent_config(\u0027sriov_nic/resource_provider_hypervisors\u0027).\\"},{"line_number":150,"context_line":"          with_value(\u0027provider-a:compute-a,provider-b:compute-b\u0027) }"},{"line_number":151,"context_line":"      end"},{"line_number":152,"context_line":"    end"},{"line_number":153,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1f621f24_eaa53ca0","line":150,"in_reply_to":"1f621f24_2a89f473","updated":"2020-11-17 13:16:20.000000000","message":"Good catch. That was a left over while refactoring the block with the top \"it ... do\"...","commit_id":"bce9c109f518002168302448f237e4f4aeff0bc9"}]}
