)]}'
{"manifests/agents/ml2/networking_baremetal.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":55,"context_line":"#   (optional) Option to set specific ironic API endpoint address if discovery of"},{"line_number":56,"context_line":"#   ironic API endpoint is not desired or impossible (for example in standalone"},{"line_number":57,"context_line":"#    mode)"},{"line_number":58,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000\u0027"},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*username*]"},{"line_number":61,"context_line":"#   (optional) Username for connection to ironic in admin context"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"65ad0f8f_36f7a3ba","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":39},"updated":"2021-06-15 08:08:15.000000000","message":"The default is $::os_service_default.","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":91,"context_line":"#   ironic-neutron-agent config."},{"line_number":92,"context_line":"#   Defaults to false."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# \u003d\u003d\u003d Deprecated Parameters"},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*ironic_url*]"},{"line_number":97,"context_line":"#   (optional) Ironic API URL, used to set Ironic API URL when auth_strategy"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"60f85529_bcbf19b3","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":27},"updated":"2021-06-15 08:08:15.000000000","message":"DEPRECATED PARAMETERS is what we usually use;\n\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L257","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"93283986a6418cd88ffdc1a794f4b024cb8fd76c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"#   ironic-neutron-agent config."},{"line_number":92,"context_line":"#   Defaults to false."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# \u003d\u003d\u003d Deprecated Parameters"},{"line_number":95,"context_line":"#"},{"line_number":96,"context_line":"# [*ironic_url*]"},{"line_number":97,"context_line":"#   (optional) Ironic API URL, used to set Ironic API URL when auth_strategy"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"f6fcaab9_a1bab05b","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":27},"in_reply_to":"60f85529_bcbf19b3","updated":"2021-06-15 08:20:06.000000000","message":"https://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2/opendaylight.pp#L40","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":96,"context_line":"# [*ironic_url*]"},{"line_number":97,"context_line":"#   (optional) Ironic API URL, used to set Ironic API URL when auth_strategy"},{"line_number":98,"context_line":"#   option is noauth to work with standalone Ironic without keystone."},{"line_number":99,"context_line":"#   Defaults to $::os_service_default"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"class neutron::agents::ml2::networking_baremetal ("},{"line_number":102,"context_line":"  $password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"83d8e85f_39f3c707","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":37},"updated":"2021-06-15 08:08:15.000000000","message":"undef.","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  $manage_service      \u003d true,"},{"line_number":105,"context_line":"  $package_ensure      \u003d \u0027present\u0027,"},{"line_number":106,"context_line":"  $auth_strategy       \u003d $::os_service_default,"},{"line_number":107,"context_line":"  $ironic_url          \u003d undef,"},{"line_number":108,"context_line":"  $endpoint_override   \u003d $::os_service_default,"},{"line_number":109,"context_line":"  $cafile              \u003d $::os_service_default,"},{"line_number":110,"context_line":"  $certfile            \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2e363339_7f26ebcb","line":107,"range":{"start_line":107,"start_character":2,"end_line":107,"end_character":31},"updated":"2021-06-15 08:08:15.000000000","message":"Please move this to the bottom with DEPRECATED PARAMETERS header like\n\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L344-L353","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  if $ironic_url !\u003d undef {"},{"line_number":134,"context_line":"    warn(\u0027neutron::agents::ml2::networking_baremetal::ironic_url is now deprecated and has no effect. \\"},{"line_number":135,"context_line":"Use neutron::agents::ml2::networking_baremetal::endpoint_override instead.\u0027)"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  resources { \u0027ironic_neutron_agent_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7ebdf15c_52dede7b","line":135,"range":{"start_line":133,"start_character":27,"end_line":135,"end_character":76},"updated":"2021-06-15 08:08:15.000000000","message":"I think it\u0027s not very safe to make this noop by this change but we should take care of the case where the deprecated parameter is used.\nHow about implementing something like\n\n$endpoint_override_real \u003d pick($ironic_url, $endpoint_override)\n\nso that the deprecated parameter is honored in case it is still used.","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"93283986a6418cd88ffdc1a794f4b024cb8fd76c","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  if $ironic_url !\u003d undef {"},{"line_number":134,"context_line":"    warn(\u0027neutron::agents::ml2::networking_baremetal::ironic_url is now deprecated and has no effect. \\"},{"line_number":135,"context_line":"Use neutron::agents::ml2::networking_baremetal::endpoint_override instead.\u0027)"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  resources { \u0027ironic_neutron_agent_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dda896f4_0fa5ec34","line":135,"range":{"start_line":133,"start_character":27,"end_line":135,"end_character":76},"in_reply_to":"7ebdf15c_52dede7b","updated":"2021-06-15 08:20:06.000000000","message":"ironic_url does not work now. It\u0027s useless.","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac2f3ef68329c02070f8b54ab2c10beceab80667","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    warn(\u0027neutron::agents::ml2::networking_baremetal::ironic_url is now deprecated and has no effect. \\"},{"line_number":135,"context_line":"Use neutron::agents::ml2::networking_baremetal::endpoint_override instead.\u0027)"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  resources { \u0027ironic_neutron_agent_config\u0027:"},{"line_number":139,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":140,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"61bc1579_d491f05b","line":137,"updated":"2021-06-15 08:08:15.000000000","message":"Let\u0027s add\n\nironic_neutron_agent_config {\n  \u0027ironic/ironic_url\u0027: ensure \u003d\u003e absent;\n}\n\nThis is useful to clean up the deprecated parameter during update.","commit_id":"52386b317a4e50de170b3b52dc5436f90d21149e"}]}