)]}'
{"manifests/agents/l3.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aee43ad79b931beb97719f1bbce33132a190b0dc","unresolved":true,"context_lines":[{"line_number":139,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":140,"context_line":"  $radvd_user                       \u003d $::os_service_default,"},{"line_number":141,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":142,"context_line":"  $logging_rate_limit               \u003d $::os_service_default,"},{"line_number":143,"context_line":"  $logging_burst_limit              \u003d $::os_service_default,"},{"line_number":144,"context_line":"  $logging_local_output_log_base    \u003d $::os_service_default,"},{"line_number":145,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8ff486f5_cd34c8c4","line":142,"range":{"start_line":142,"start_character":3,"end_line":142,"end_character":10},"updated":"2021-08-11 11:34:14.000000000","message":"I\u0027d prefer \u0027network_log_\u0027 prefix to make it consistent with the section name. That\u0027d help us guess the actual parameter and avoid future conflict.","commit_id":"36b24dd8f44216265b10ef0b6bf44c34e5abc0cf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"111d520e685ec36257ee5aad5a7bb7ef6000c27b","unresolved":true,"context_lines":[{"line_number":139,"context_line":"  $extensions                       \u003d $::os_service_default,"},{"line_number":140,"context_line":"  $radvd_user                       \u003d $::os_service_default,"},{"line_number":141,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":142,"context_line":"  $logging_rate_limit               \u003d $::os_service_default,"},{"line_number":143,"context_line":"  $logging_burst_limit              \u003d $::os_service_default,"},{"line_number":144,"context_line":"  $logging_local_output_log_base    \u003d $::os_service_default,"},{"line_number":145,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8aa2ee49_198d14e3","line":142,"range":{"start_line":142,"start_character":3,"end_line":142,"end_character":10},"in_reply_to":"8ff486f5_cd34c8c4","updated":"2021-08-12 05:41:05.000000000","message":"thx a lot, that works for me :)","commit_id":"36b24dd8f44216265b10ef0b6bf44c34e5abc0cf"}],"manifests/plugins/ml2/ovn.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3601f1f400c7e411e14fe79dacc30b4935e129d3","unresolved":true,"context_lines":[{"line_number":136,"context_line":"  $dns_servers                   \u003d $::os_service_default,"},{"line_number":137,"context_line":"  $vhostuser_socket_dir          \u003d $::os_service_default,"},{"line_number":138,"context_line":"  $ovn_emit_need_to_frag         \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $logging_rate_limit            \u003d 100,"},{"line_number":140,"context_line":"  $logging_burst_limit           \u003d 25,"},{"line_number":141,"context_line":"  $logging_local_output_log_base \u003d undef,"},{"line_number":142,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a0ea27c3_445c9692","line":139,"range":{"start_line":139,"start_character":35,"end_line":139,"end_character":38},"updated":"2021-08-11 10:14:52.000000000","message":"IIUC this is same as the default defined in neutron itself, thus can be replaced by $::os_service_default.","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7902996e8a036fc0d8aadcdb2e3c97fb9bd95b50","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  $dns_servers                   \u003d $::os_service_default,"},{"line_number":137,"context_line":"  $vhostuser_socket_dir          \u003d $::os_service_default,"},{"line_number":138,"context_line":"  $ovn_emit_need_to_frag         \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $logging_rate_limit            \u003d 100,"},{"line_number":140,"context_line":"  $logging_burst_limit           \u003d 25,"},{"line_number":141,"context_line":"  $logging_local_output_log_base \u003d undef,"},{"line_number":142,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ab50a14a_f4a9465b","line":139,"range":{"start_line":139,"start_character":35,"end_line":139,"end_character":38},"in_reply_to":"a0ea27c3_445c9692","updated":"2021-08-11 10:33:17.000000000","message":"Done","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3601f1f400c7e411e14fe79dacc30b4935e129d3","unresolved":true,"context_lines":[{"line_number":137,"context_line":"  $vhostuser_socket_dir          \u003d $::os_service_default,"},{"line_number":138,"context_line":"  $ovn_emit_need_to_frag         \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $logging_rate_limit            \u003d 100,"},{"line_number":140,"context_line":"  $logging_burst_limit           \u003d 25,"},{"line_number":141,"context_line":"  $logging_local_output_log_base \u003d undef,"},{"line_number":142,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":143,"context_line":"  $ovn_l3_mode                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9205b259_cb7232d3","line":140,"range":{"start_line":140,"start_character":35,"end_line":140,"end_character":37},"updated":"2021-08-11 10:14:52.000000000","message":"ditto","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7902996e8a036fc0d8aadcdb2e3c97fb9bd95b50","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  $vhostuser_socket_dir          \u003d $::os_service_default,"},{"line_number":138,"context_line":"  $ovn_emit_need_to_frag         \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $logging_rate_limit            \u003d 100,"},{"line_number":140,"context_line":"  $logging_burst_limit           \u003d 25,"},{"line_number":141,"context_line":"  $logging_local_output_log_base \u003d undef,"},{"line_number":142,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":143,"context_line":"  $ovn_l3_mode                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"33d476cf_239457b8","line":140,"range":{"start_line":140,"start_character":35,"end_line":140,"end_character":37},"in_reply_to":"9205b259_cb7232d3","updated":"2021-08-11 10:33:17.000000000","message":"Done","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3601f1f400c7e411e14fe79dacc30b4935e129d3","unresolved":true,"context_lines":[{"line_number":186,"context_line":"    \u0027network_log/burst_limit\u0027      : value \u003d\u003e $logging_burst_limit;"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  if $logging_local_output_log_base {"},{"line_number":190,"context_line":"    neutron_plugin_ml2 {"},{"line_number":191,"context_line":"      \u0027network_log/local_output_log_base\u0027:  value \u003d\u003e $logging_local_output_log_base;"},{"line_number":192,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c47556a7_fd9e0b26","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":35},"updated":"2021-08-11 10:14:52.000000000","message":"This implementation is redundant. You can use $::os_service_default as default, which is an indicator to remove the parameter from conf file.","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7902996e8a036fc0d8aadcdb2e3c97fb9bd95b50","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    \u0027network_log/burst_limit\u0027      : value \u003d\u003e $logging_burst_limit;"},{"line_number":187,"context_line":"  }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"  if $logging_local_output_log_base {"},{"line_number":190,"context_line":"    neutron_plugin_ml2 {"},{"line_number":191,"context_line":"      \u0027network_log/local_output_log_base\u0027:  value \u003d\u003e $logging_local_output_log_base;"},{"line_number":192,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7eece4bb_56276f15","line":189,"range":{"start_line":189,"start_character":6,"end_line":189,"end_character":35},"in_reply_to":"c47556a7_fd9e0b26","updated":"2021-08-11 10:33:17.000000000","message":"Done","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"}],"manifests/server.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3601f1f400c7e411e14fe79dacc30b4935e129d3","unresolved":true,"context_lines":[{"line_number":270,"context_line":"  $max_request_body_size            \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $igmp_snooping_enable             \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $logging_rate_limit               \u003d 100,"},{"line_number":274,"context_line":"  $logging_burst_limit              \u003d 25,"},{"line_number":275,"context_line":"  $logging_local_output_log_base    \u003d undef,"},{"line_number":276,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":277,"context_line":"  $ensure_fwaas_package             \u003d undef,"},{"line_number":278,"context_line":") inherits neutron::params {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"259ea29f_fc014813","line":275,"range":{"start_line":273,"start_character":0,"end_line":275,"end_character":44},"updated":"2021-08-11 10:14:52.000000000","message":"These parameters are not used.","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"67e0ab03238892c1a27c905a1d057f6fafafffe5","unresolved":true,"context_lines":[{"line_number":270,"context_line":"  $max_request_body_size            \u003d $::os_service_default,"},{"line_number":271,"context_line":"  $ovs_integration_bridge           \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $igmp_snooping_enable             \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $logging_rate_limit               \u003d 100,"},{"line_number":274,"context_line":"  $logging_burst_limit              \u003d 25,"},{"line_number":275,"context_line":"  $logging_local_output_log_base    \u003d undef,"},{"line_number":276,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":277,"context_line":"  $ensure_fwaas_package             \u003d undef,"},{"line_number":278,"context_line":") inherits neutron::params {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"cc6467b5_71571031","line":275,"range":{"start_line":273,"start_character":0,"end_line":275,"end_character":44},"in_reply_to":"259ea29f_fc014813","updated":"2021-08-11 10:28:28.000000000","message":"Yes, I forgot to remove them after I added it here at first glance :)","commit_id":"9b0ba8f610e001fdae5e54d5ef3cf4a18aad37a8"}]}