)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e0245764032875060b0de87db26e7210ae4c994","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     waleedm \u003cwaleedm@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-19 11:12:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change sdn authentication from basic(username,password) to token authentication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8b347a4705045dfa0363284ec41e9e519ec19f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"45878191_3e67dadb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":79},"updated":"2021-10-19 11:35:35.000000000","message":"The general guidance is to keep the first line shorter than 50 characters. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"963d1f023de6b71da21c1d3a255aa9251fd9245a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     waleedm \u003cwaleedm@nvidia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-19 11:12:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change sdn authentication from basic(username,password) to token authentication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8b347a4705045dfa0363284ec41e9e519ec19f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"70de94b7_9431b60d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":79},"in_reply_to":"45878191_3e67dadb","updated":"2021-10-28 06:34:51.000000000","message":"Done","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"895b2ae27d3775b1f07959569b3e53185d38be1a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-19 11:12:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change sdn authentication from basic(username,password) to token authentication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8b347a4705045dfa0363284ec41e9e519ec19f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d8f00e2_be032379","line":8,"updated":"2021-10-19 11:42:25.000000000","message":"This change should depend on https://review.opendev.org/c/x/networking-mlnx/+/814557","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e0245764032875060b0de87db26e7210ae4c994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88fcc07c_07ef1021","updated":"2021-10-19 11:35:35.000000000","message":"Thank you for proposing the patch. Please find the comments inline.\n\nAlso, could you please add a release note file to explain the change in parameter interface ?","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"963d1f023de6b71da21c1d3a255aa9251fd9245a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35a6ddb9_6aa95f62","in_reply_to":"88fcc07c_07ef1021","updated":"2021-10-28 06:34:51.000000000","message":"Done","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82ec8496_59a8f4fc","updated":"2021-10-28 11:32:20.000000000","message":"Just made some minor fixes.\n-1 because of this is depending on the change in networking-mlnx side. https://review.opendev.org/c/x/networking-mlnx/+/814557","commit_id":"3194f7d056fcf074a19045ef26447cf79f560510"}],"manifests/plugins/ml2/mellanox/mlnx_sdn_assist.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e0245764032875060b0de87db26e7210ae4c994","unresolved":true,"context_lines":[{"line_number":42,"context_line":"# Defaults to []"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("},{"line_number":45,"context_line":"  $sdn_token \u003d $::os_service_default,"},{"line_number":46,"context_line":"  $sdn_url      \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $sdn_domain   \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $sync_enabled                 \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"463e5d75_8602b450","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":37},"updated":"2021-10-19 11:35:35.000000000","message":"Please do not remove the old parameter because it is breaking the interface. Any parameters should be deprecated first and kept for one cycle.\n\nAlso, I\u0027d agree that adding sdn_token would be useful but I don\u0027t really see much benefit of removing username and password and wondering whether it makes sense to keep basic auth and just ad the token parameter. Is there any specific concern with allowing usage of username/password ? (I\u0027d agree with dropping basic auth if that is deprecated in mellanox plugin)","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"963d1f023de6b71da21c1d3a255aa9251fd9245a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# Defaults to []"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class neutron::plugins::ml2::mellanox::mlnx_sdn_assist ("},{"line_number":45,"context_line":"  $sdn_token \u003d $::os_service_default,"},{"line_number":46,"context_line":"  $sdn_url      \u003d $::os_service_default,"},{"line_number":47,"context_line":"  $sdn_domain   \u003d $::os_service_default,"},{"line_number":48,"context_line":"  $sync_enabled                 \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"13f38d49_a5d6c775","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":37},"in_reply_to":"463e5d75_8602b450","updated":"2021-10-28 06:34:51.000000000","message":"Done","commit_id":"2bbc8e91ba7bc630b226c78ae6de3c8b3400489b"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"db0b1ba30c8e4d0529bd7d0d6f5ee70c11f6fb83","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# [*sdn_url*]"},{"line_number":13,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":14,"context_line":"# Defaults to $::os_service_default"},{"line_number":15,"context_line":"# Example: \u0027http://127.0.0.1/neo\u0027"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*sdn_domain*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"962c1c1f_5061e6e0","line":15,"updated":"2021-10-28 06:34:49.000000000","message":"what is the default for ufm","commit_id":"d45e3b36b7c35505ac80e99af5aeebb425d2551b"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"5f3b279aab08b5b503f0d81921e55dcfa94190f1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"# [*sdn_url*]"},{"line_number":13,"context_line":"# (optional) The Mellanox controller neutron URL"},{"line_number":14,"context_line":"# Defaults to $::os_service_default"},{"line_number":15,"context_line":"# Example: \u0027http://127.0.0.1/neo\u0027"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# [*sdn_domain*]"},{"line_number":18,"context_line":"# (optional) The Mellanox controller domain"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"92d6c288_e15a4c58","line":15,"in_reply_to":"962c1c1f_5061e6e0","updated":"2021-10-28 06:44:25.000000000","message":"moved it http://127.0.0.1/ufmRestV3/\u0027","commit_id":"d45e3b36b7c35505ac80e99af5aeebb425d2551b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e4ed8776240ed07484d1a8049edb8f791fb32cb","unresolved":true,"context_lines":[{"line_number":68,"context_line":"and has no effect.\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":"  neutron_plugin_ml2 {"},{"line_number":71,"context_line":"    \u0027sdn/username\u0027:    ensure \u003d\u003e absent;"},{"line_number":72,"context_line":"    \u0027sdn/password \u0027:   ensure \u003d\u003e absent;"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"4494c305_8a331535","line":71,"range":{"start_line":71,"start_character":20,"end_line":71,"end_character":22},"updated":"2021-10-28 11:23:50.000000000","message":"(nit) you can remove two spaces.","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"and has no effect.\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":"  neutron_plugin_ml2 {"},{"line_number":71,"context_line":"    \u0027sdn/username\u0027:    ensure \u003d\u003e absent;"},{"line_number":72,"context_line":"    \u0027sdn/password \u0027:   ensure \u003d\u003e absent;"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"f244630b_8fbdafc1","line":71,"range":{"start_line":71,"start_character":20,"end_line":71,"end_character":22},"in_reply_to":"4494c305_8a331535","updated":"2021-10-28 11:32:20.000000000","message":"Done","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"}],"releasenotes/notes/add_token_auth-daa888e87da725da.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e4ed8776240ed07484d1a8049edb8f791fb32cb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_username and"},{"line_number":5,"context_line":"    neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_password have been"},{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"76c50e9a_83ea371e","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":70},"updated":"2021-10-28 11:23:50.000000000","message":"I prefer quoting class names or parameter names by ``foo`` to make them more visible.","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e4ed8776240ed07484d1a8049edb8f791fb32cb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_username and"},{"line_number":5,"context_line":"    neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_password have been"},{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c3a2e044_3793a452","line":4,"range":{"start_line":4,"start_character":71,"end_line":4,"end_character":74},"updated":"2021-10-28 11:23:50.000000000","message":"parameter and","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_username and"},{"line_number":5,"context_line":"    neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_password have been"},{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3870dfa0_01791fce","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":70},"in_reply_to":"76c50e9a_83ea371e","updated":"2021-10-28 11:32:20.000000000","message":"Done","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_username and"},{"line_number":5,"context_line":"    neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_password have been"},{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4c2a46b1_bf64d466","line":4,"range":{"start_line":4,"start_character":71,"end_line":4,"end_character":74},"in_reply_to":"c3a2e044_3793a452","updated":"2021-10-28 11:32:20.000000000","message":"Done","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e4ed8776240ed07484d1a8049edb8f791fb32cb","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    A new param neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_token"},{"line_number":10,"context_line":"    has been added to authenticate sdn"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"250887f6_e8e0ae05","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":15},"updated":"2021-10-28 11:23:50.000000000","message":"Because this is the documentation \u0027parameter\u0027 would be better.","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    deprecated"},{"line_number":7,"context_line":"other:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    A new param neutron::plugins::ml2::mellanox::mlnx_sdn_assist::sdn_token"},{"line_number":10,"context_line":"    has been added to authenticate sdn"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e9860881_7602b649","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":15},"in_reply_to":"250887f6_e8e0ae05","updated":"2021-10-28 11:32:20.000000000","message":"Done","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"}],"spec/classes/neutron_plugins_ml2_mlnx_sdn_assist_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e4ed8776240ed07484d1a8049edb8f791fb32cb","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :params do"},{"line_number":21,"context_line":"    {"},{"line_number":22,"context_line":"      :sdn_token    \u003d\u003e \u0027token\u0027,"},{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"b13ae6d1_0dae4cae","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":19},"updated":"2021-10-28 11:23:50.000000000","message":"(nit) redundant spaces.","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90a25e6848bb4832fa45321125b0f2616e427b5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  let :params do"},{"line_number":21,"context_line":"    {"},{"line_number":22,"context_line":"      :sdn_token    \u003d\u003e \u0027token\u0027,"},{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"  end"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"340c7b85_57e6eb54","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":19},"in_reply_to":"b13ae6d1_0dae4cae","updated":"2021-10-28 11:32:20.000000000","message":"Done","commit_id":"6d8b50161227325b540016cf47eeb074a47d3589"}]}