)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"260a3b20d31a55281d213a553853d69ab778146f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"dc417c19_10f044a3","updated":"2021-11-17 08:20:37.000000000","message":"do we need to check that?","commit_id":"d4830443fb9fcb5d0ef6ae008803df5102a64234"}],"lib/puppet/provider/neutron_subnet/openstack.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ad9806435888ca066f515762f0efe26b57202362","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        :dns_nameservers   \u003d\u003e parse_dns_nameservers(subnet[:dns_nameservers]),"},{"line_number":47,"context_line":"        :enable_dhcp       \u003d\u003e subnet[:enable_dhcp],"},{"line_number":48,"context_line":"        :network_id        \u003d\u003e subnet[:network_id],"},{"line_number":49,"context_line":"        :network_name      \u003d\u003e get_network_name(subnet[:network_id]),"},{"line_number":50,"context_line":"        :tenant_id         \u003d\u003e subnet[:project_id],"},{"line_number":51,"context_line":"      )"},{"line_number":52,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"7455ed5c_94ad5045","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":46},"updated":"2021-11-17 08:19:43.000000000","message":"For this new function we never check if command was successful i.e that it didn\u0027t return nil","commit_id":"d4830443fb9fcb5d0ef6ae008803df5102a64234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0ae0c44eaf818e1d50edd5ba60a6c1fee3c9698","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        :dns_nameservers   \u003d\u003e parse_dns_nameservers(subnet[:dns_nameservers]),"},{"line_number":47,"context_line":"        :enable_dhcp       \u003d\u003e subnet[:enable_dhcp],"},{"line_number":48,"context_line":"        :network_id        \u003d\u003e subnet[:network_id],"},{"line_number":49,"context_line":"        :network_name      \u003d\u003e get_network_name(subnet[:network_id]),"},{"line_number":50,"context_line":"        :tenant_id         \u003d\u003e subnet[:project_id],"},{"line_number":51,"context_line":"      )"},{"line_number":52,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"32e8a141_afd682ed","line":49,"range":{"start_line":49,"start_character":30,"end_line":49,"end_character":46},"in_reply_to":"7455ed5c_94ad5045","updated":"2021-11-17 08:33:15.000000000","message":"We use \"openstack network show\" command in this function and the command fails(returns 1) if the network is not found. So unless any exception is raised, we can safely assume this function finds the network and returns its name.","commit_id":"d4830443fb9fcb5d0ef6ae008803df5102a64234"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"260a3b20d31a55281d213a553853d69ab778146f","unresolved":true,"context_lines":[{"line_number":189,"context_line":"      :dns_nameservers   \u003d\u003e self.class.parse_dns_nameservers(subnet[:dns_nameservers]),"},{"line_number":190,"context_line":"      :enable_dhcp       \u003d\u003e subnet[:enable_dhcp],"},{"line_number":191,"context_line":"      :network_id        \u003d\u003e subnet[:network_id],"},{"line_number":192,"context_line":"      :network_name      \u003d\u003e self.class.get_network_name(subnet[:network_id]),"},{"line_number":193,"context_line":"      :tenant_id         \u003d\u003e subnet[:project_id],"},{"line_number":194,"context_line":"    }"},{"line_number":195,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"3202b9f8_18922127","line":192,"range":{"start_line":192,"start_character":28,"end_line":192,"end_character":55},"updated":"2021-11-17 08:20:37.000000000","message":"same","commit_id":"d4830443fb9fcb5d0ef6ae008803df5102a64234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0ae0c44eaf818e1d50edd5ba60a6c1fee3c9698","unresolved":true,"context_lines":[{"line_number":189,"context_line":"      :dns_nameservers   \u003d\u003e self.class.parse_dns_nameservers(subnet[:dns_nameservers]),"},{"line_number":190,"context_line":"      :enable_dhcp       \u003d\u003e subnet[:enable_dhcp],"},{"line_number":191,"context_line":"      :network_id        \u003d\u003e subnet[:network_id],"},{"line_number":192,"context_line":"      :network_name      \u003d\u003e self.class.get_network_name(subnet[:network_id]),"},{"line_number":193,"context_line":"      :tenant_id         \u003d\u003e subnet[:project_id],"},{"line_number":194,"context_line":"    }"},{"line_number":195,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":37,"id":"89a50322_a4a8a4f6","line":192,"range":{"start_line":192,"start_character":28,"end_line":192,"end_character":55},"in_reply_to":"3202b9f8_18922127","updated":"2021-11-17 08:33:15.000000000","message":"Ditto. The internal command should fail if the network is not found for some reason.","commit_id":"d4830443fb9fcb5d0ef6ae008803df5102a64234"}]}