)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"200d1b526b31823f7fc332225ee4c52e3e630db2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44be8c89_bb6b1d25","updated":"2021-11-19 09:08:06.000000000","message":"Let me leave some early feedback, though it might be too early.\n\nPlease add a release note to explain the parameter and unit tests to validate the new parameter.\nI\u0027ve submitted a separate patch to add missing unit test cases so you can rebase you change on it.\n\nhttps://review.opendev.org/c/openstack/puppet-neutron/+/818517\n\n\nAlso, as I mentioned inline, it would be nice if you can implement the certfile parameter at the same time.","commit_id":"2140b4f40e00ab221aeef7c7457e9881c3a49184"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"611d029c6f789a60380660135f52d3ed365ae5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a8cbe92_52b5cfb9","in_reply_to":"44be8c89_bb6b1d25","updated":"2022-03-25 00:40:41.000000000","message":"Done","commit_id":"2140b4f40e00ab221aeef7c7457e9881c3a49184"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"611d029c6f789a60380660135f52d3ed365ae5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4c1563d_3454b842","updated":"2022-03-25 00:40:41.000000000","message":"Also, appropriate unit test coverage is missing, which I\u0027ve fixed in the latest patchset.","commit_id":"951f9ba6a2edd5abd3124cf1424836dbb979d2f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"839d67890794f9e77858e019cb014647fd44c3ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a68c2fe6_4730f26a","updated":"2022-04-01 15:07:14.000000000","message":"Let\u0027s move this ahead.","commit_id":"2f9c0280bb6b8d2d4ea5f25032b101d28b639338"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d80ad22c69e692aaf82fbfe7fae13058b9221af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"299b030b_e3140877","updated":"2022-03-27 01:55:35.000000000","message":"recheck","commit_id":"2f9c0280bb6b8d2d4ea5f25032b101d28b639338"}],"manifests/designate.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"200d1b526b31823f7fc332225ee4c52e3e630db2","unresolved":true,"context_lines":[{"line_number":41,"context_line":"#   determined using auth_url"},{"line_number":42,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000\u0027"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*cafile*]"},{"line_number":45,"context_line":"#   (Optional) A PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":46,"context_line":"#   connections."},{"line_number":47,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4cdc704a_d248344b","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":10},"updated":"2021-11-19 09:08:06.000000000","message":"Do you mind implementing the certfile as well. Looking at the other place we usually have both these two parameters ?","commit_id":"2140b4f40e00ab221aeef7c7457e9881c3a49184"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"611d029c6f789a60380660135f52d3ed365ae5d6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   determined using auth_url"},{"line_number":42,"context_line":"#   Defaults to \u0027http://127.0.0.1:5000\u0027"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"# [*cafile*]"},{"line_number":45,"context_line":"#   (Optional) A PEM encoded Certificate Authority to use when verifying HTTPs"},{"line_number":46,"context_line":"#   connections."},{"line_number":47,"context_line":"#   Defaults to $::os_service_default."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"67e3f7c6_3678e3fc","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":10},"in_reply_to":"4cdc704a_d248344b","updated":"2022-03-25 00:40:41.000000000","message":"Done","commit_id":"2140b4f40e00ab221aeef7c7457e9881c3a49184"}],"releasenotes/notes/designate-ca-file-2d6e9213a67f1ec5.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"611d029c6f789a60380660135f52d3ed365ae5d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The neutron::designate file has now a new parameter cafile, to allow using"},{"line_number":5,"context_line":"    a self-signed certificate for the Designate API."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5d5f7809_201c0e88","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":31},"updated":"2022-03-25 00:40:41.000000000","message":"class","commit_id":"2140b4f40e00ab221aeef7c7457e9881c3a49184"}]}
