)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f81e62d66a15dec73fdbbc9fa6958d8b8c2bf82b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[ML2 OVN] Add dhcp_for_baremetal_disabled parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This parameter can be used to disable OVN\u0027s DHCP when used with"},{"line_number":10,"context_line":"baremetal ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If38730c5757bdaa6c19ece02c05106f191b91048"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"98d44bc2_40c09def","line":10,"updated":"2022-07-20 05:42:03.000000000","message":"Also can add reference and some context to neutron\u0027s patch which added that option https://review.opendev.org/c/openstack/neutron/+/840316","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"58caf115e974ee1515f2ef8121f1b5da9b173b28","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[ML2 OVN] Add dhcp_for_baremetal_disabled parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This parameter can be used to disable OVN\u0027s DHCP when used with"},{"line_number":10,"context_line":"baremetal ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If38730c5757bdaa6c19ece02c05106f191b91048"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aaeaf61e_a08b2234","line":10,"in_reply_to":"98d44bc2_40c09def","updated":"2022-07-20 06:00:03.000000000","message":"That sounds good. You can use Depends-on: Tag . We usually use the tag to pull the dependent patch in CI but we can use it here to explain dependency.\n\nAlso, you might want to link the original bug by\n\nRelated-Bug: #1971431\n\nFor closes/partial bug I expect you report a bug against puppet-neutron but in this case we use a weak ref(related) so we can use the neutron bug.","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dbfcec67b8ab8f5175f60e4f91bd97f07ba93154","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[ML2 OVN] Add dhcp_for_baremetal_disabled parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This parameter can be used to disable OVN\u0027s DHCP when used with"},{"line_number":10,"context_line":"baremetal ports."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If38730c5757bdaa6c19ece02c05106f191b91048"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae8bb66_31dbf5d7","line":10,"in_reply_to":"aaeaf61e_a08b2234","updated":"2022-07-20 16:39:41.000000000","message":"Done","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1ca4440dd6ebe13fafa5b7f62ac945a3d7086508","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"397db3eb_e2394d23","updated":"2022-07-20 03:52:48.000000000","message":"Also, please add a release note because this change adds a new parameter.","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f81e62d66a15dec73fdbbc9fa6958d8b8c2bf82b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dec970e8_37045353","in_reply_to":"397db3eb_e2394d23","updated":"2022-07-20 05:42:03.000000000","message":"+1","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dbfcec67b8ab8f5175f60e4f91bd97f07ba93154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd1e1e4a_bb9ea864","in_reply_to":"dec970e8_37045353","updated":"2022-07-20 16:39:41.000000000","message":"Done","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"}],"manifests/plugins/ml2/ovn.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"479d2b63cfc1729eda949429853f4ed8bd0b8e5d","unresolved":true,"context_lines":[{"line_number":79,"context_line":"#   Type: boolean"},{"line_number":80,"context_line":"#   Defaults to $::os_service_default"},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*dhcp_for_baremetal_disabled*]"},{"line_number":83,"context_line":"#   (optional) Whether to disable built-in DHCP for baremetal ports."},{"line_number":84,"context_line":"#   Type: boolean"},{"line_number":85,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2b11ecc5_7bf57b14","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":31},"updated":"2022-07-20 03:52:29.000000000","message":"Can we use the original parameter name instead of defining own one here ? Because of a historical reason we ended up using dvr_enabled but using a different parameter name is sometimes confusing especially the puppet parameter is directly mapped to a neutron parameter. Also what this parameter does it to disable ovn dhcp (IIUC) instead the whole dhcp and I prefer \"ovn_dhcp\" to make that point clear.","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"f81e62d66a15dec73fdbbc9fa6958d8b8c2bf82b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"#   Type: boolean"},{"line_number":80,"context_line":"#   Defaults to $::os_service_default"},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*dhcp_for_baremetal_disabled*]"},{"line_number":83,"context_line":"#   (optional) Whether to disable built-in DHCP for baremetal ports."},{"line_number":84,"context_line":"#   Type: boolean"},{"line_number":85,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ecd8f563_d01f268b","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":31},"in_reply_to":"2b11ecc5_7bf57b14","updated":"2022-07-20 05:42:03.000000000","message":"+1 to use disable_ovn_dhcp_for_baremetal_ports and update description too.","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dbfcec67b8ab8f5175f60e4f91bd97f07ba93154","unresolved":false,"context_lines":[{"line_number":79,"context_line":"#   Type: boolean"},{"line_number":80,"context_line":"#   Defaults to $::os_service_default"},{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":"# [*dhcp_for_baremetal_disabled*]"},{"line_number":83,"context_line":"#   (optional) Whether to disable built-in DHCP for baremetal ports."},{"line_number":84,"context_line":"#   Type: boolean"},{"line_number":85,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a30b504_d69f326c","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":31},"in_reply_to":"ecd8f563_d01f268b","updated":"2022-07-20 16:39:41.000000000","message":"I do not disagree :) I\u0027ll gladly change it. It crossed my mind but I was not sure if thats something we do as I saw other variables with a different name.","commit_id":"36f8ab41e15e22d7ec12bed873ade5f3de1d6262"}],"releasenotes/notes/add_disable_ovn_dhcp_for_baremetal_ports-8b99e23e038faa5d.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9295b100750e61bf775464fb2990e19f5806ae17","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027disable_ovn_dhcp_for_baremetal_ports\u0027 parameter which"},{"line_number":5,"context_line":"    allows disabling OVN\u0027s built-in DHCP for baremetal ports."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e9a88e6f_22f69469","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":9},"updated":"2022-07-20 23:33:33.000000000","message":"(nit) this is not interpreted by as character format sign. We usually use `` `` to use bold characters.","commit_id":"13deaf50438bae1375ac90a6abec927e55ec3b5b"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"4267d4d9750082637d2b1fb61eadf9f84e2a7165","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add \u0027disable_ovn_dhcp_for_baremetal_ports\u0027 parameter which"},{"line_number":5,"context_line":"    allows disabling OVN\u0027s built-in DHCP for baremetal ports."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"202df79a_3b30ad2c","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":9},"in_reply_to":"e9a88e6f_22f69469","updated":"2022-07-21 01:29:19.000000000","message":"I dont think I meant to add single quote character. I will remove it","commit_id":"13deaf50438bae1375ac90a6abec927e55ec3b5b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"91ba2ef82c7eaa4f11d738d0e73bac7e53ee6f3a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add disable_ovn_dhcp_for_baremetal_ports parameter which"},{"line_number":5,"context_line":"    allows disabling OVN\u0027s built-in DHCP for baremetal ports."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ab6a80c_c4c01ed7","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":44},"updated":"2022-07-21 14:51:45.000000000","message":"would be better to change it to ``disable_ovn_dhcp_for_baremetal_ports`` so it\u0027s seen in bold format in release notes, currently it\u0027s not see https://20a050517a9a92262cff-454ae315be67c120ece17a0c344becbf.ssl.cf2.rackcdn.com/850439/3/check/build-openstack-releasenotes/c0ded11/docs/unreleased.html.\n\nOr even better as\n    Add ``disable_ovn_dhcp_for_baremetal_ports`` parameter to\n    ``neutron::plugins::ml2::ovn`` class which allows disabling\n    OVN\u0027s built-in DHCP for baremetal ports.\n\nor anything similar to above","commit_id":"8e44dfa405b03c30dc8314e93b0814fcd8b7e9a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59ae1656e678ae887c9b80b0c658ad156bc1acc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add disable_ovn_dhcp_for_baremetal_ports parameter which"},{"line_number":5,"context_line":"    allows disabling OVN\u0027s built-in DHCP for baremetal ports."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c40edb12_56ba79f1","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":44},"in_reply_to":"3ab6a80c_c4c01ed7","updated":"2022-07-25 03:11:20.000000000","message":"Done\n\nThis now looks better\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_192/850439/4/check/build-openstack-releasenotes/1921ce1/docs/unreleased.html#new-features","commit_id":"8e44dfa405b03c30dc8314e93b0814fcd8b7e9a4"}]}