)]}'
{"manifests/plugins/ml2.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  $vni_ranges                            \u003d \u002710:100\u0027,"},{"line_number":136,"context_line":"  $enable_security_group                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":137,"context_line":"  $package_ensure                        \u003d \u0027present\u0027,"},{"line_number":138,"context_line":"  Optional[Array] $physical_network_mtus \u003d undef,"},{"line_number":139,"context_line":"  $path_mtu                              \u003d 0,"},{"line_number":140,"context_line":"  $purge_config                          \u003d false,"},{"line_number":141,"context_line":"  $max_header_size                       \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"16de5683_539338e1","line":138,"updated":"2023-06-21 08:40:15.000000000","message":"dont change the default here","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba786f931f89e49363031738865c00b7a09d42c6","unresolved":true,"context_lines":[{"line_number":135,"context_line":"  $vni_ranges                            \u003d \u002710:100\u0027,"},{"line_number":136,"context_line":"  $enable_security_group                 \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":137,"context_line":"  $package_ensure                        \u003d \u0027present\u0027,"},{"line_number":138,"context_line":"  Optional[Array] $physical_network_mtus \u003d undef,"},{"line_number":139,"context_line":"  $path_mtu                              \u003d 0,"},{"line_number":140,"context_line":"  $purge_config                          \u003d false,"},{"line_number":141,"context_line":"  $max_header_size                       \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"4373a871_55f3731f","line":138,"in_reply_to":"16de5683_539338e1","updated":"2023-06-21 08:55:26.000000000","message":"Let\u0027s merge https://review.opendev.org/c/openstack/puppet-neutron/+/886575 and leave validation for this specific parameter for future work.","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    \u0027ml2/overlay_ip_version\u0027:               value \u003d\u003e $overlay_ip_version;"},{"line_number":213,"context_line":"    \u0027securitygroup/enable_security_group\u0027:  value \u003d\u003e $enable_security_group;"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  if $physical_network_mtus {"},{"line_number":217,"context_line":"    neutron_plugin_ml2 {"},{"line_number":218,"context_line":"      \u0027ml2/physical_network_mtus\u0027: value \u003d\u003e join($physical_network_mtus, \u0027,\u0027);"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"c3804fa6_73debcf9","line":215,"updated":"2023-06-21 08:40:15.000000000","message":"then this logic is still valid instead of changing it","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"}],"manifests/plugins/ml2/arista/l3.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":55,"context_line":"  $primary_l3_host_username,"},{"line_number":56,"context_line":"  $primary_l3_host_password,"},{"line_number":57,"context_line":"  $secondary_l3_host             \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":58,"context_line":"  Optional[Boolean] $mlag_config \u003d undef,"},{"line_number":59,"context_line":"  $l3_sync_interval              \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":60,"context_line":"  $conn_timeout                  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":61,"context_line":"  $use_vrf                       \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7acf1123_6a934673","line":58,"updated":"2023-06-21 08:40:15.000000000","message":"dont change default value","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    \u0027l3_arista/primary_l3_host_username\u0027: value \u003d\u003e $primary_l3_host_username;"},{"line_number":76,"context_line":"    \u0027l3_arista/primary_l3_host_password\u0027: value \u003d\u003e $primary_l3_host_password, secret \u003d\u003e true;"},{"line_number":77,"context_line":"    \u0027l3_arista/secondary_l3_host\u0027       : value \u003d\u003e $secondary_l3_host;"},{"line_number":78,"context_line":"    \u0027l3_arista/mlag_config\u0027             : value \u003d\u003e pick($mlag_config, $facts[\u0027os_service_default\u0027]);"},{"line_number":79,"context_line":"    \u0027l3_arista/l3_sync_interval\u0027        : value \u003d\u003e $l3_sync_interval;"},{"line_number":80,"context_line":"    \u0027l3_arista/conn_timeout\u0027            : value \u003d\u003e $conn_timeout;"},{"line_number":81,"context_line":"    \u0027l3_arista/use_vrf\u0027                 : value \u003d\u003e $use_vrf;"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"c3035853_72a8c21b","line":78,"updated":"2023-06-21 08:40:15.000000000","message":"no pick()","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"}],"manifests/plugins/ml2/type_driver.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  $network_vlan_ranges,"},{"line_number":50,"context_line":"  $vni_ranges,"},{"line_number":51,"context_line":"  $vxlan_group,"},{"line_number":52,"context_line":"  Variant[Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027], Integer] $max_header_size,"},{"line_number":53,"context_line":"){"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"f34e9c16_d2dd466b","line":52,"updated":"2023-06-21 08:40:15.000000000","message":"lets use the new Openstacklib::ServiceDefault type now","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba786f931f89e49363031738865c00b7a09d42c6","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  $network_vlan_ranges,"},{"line_number":50,"context_line":"  $vni_ranges,"},{"line_number":51,"context_line":"  $vxlan_group,"},{"line_number":52,"context_line":"  Variant[Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027], Integer] $max_header_size,"},{"line_number":53,"context_line":"){"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  include neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"cac435d0_bad263f1","line":52,"in_reply_to":"f34e9c16_d2dd466b","updated":"2023-06-21 08:55:26.000000000","message":"I\u0027d rather encourage removing this validation for now, and add it back when we add the consistent type definition for all openstack config options accepting an integer.","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"}],"manifests/server.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":269,"context_line":"  Boolean $ensure_vpnaas_package     \u003d false,"},{"line_number":270,"context_line":"  Boolean $ensure_dr_package         \u003d false,"},{"line_number":271,"context_line":"  $vpnaas_agent_package              \u003d false,"},{"line_number":272,"context_line":"  Optional[Array] $service_providers \u003d undef,"},{"line_number":273,"context_line":"  $auth_strategy                     \u003d \u0027keystone\u0027,"},{"line_number":274,"context_line":"  $enable_proxy_headers_parsing      \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":275,"context_line":"  $max_request_body_size             \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"00d66695_9e4ee993","line":272,"updated":"2023-06-21 08:40:15.000000000","message":"dont change default value","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":332,"context_line":"    \u0027DEFAULT/default_availability_zones\u0027:       value \u003d\u003e join(any2array($default_availability_zones), \u0027,\u0027);"},{"line_number":333,"context_line":"    \u0027DEFAULT/network_auto_schedule\u0027:            value \u003d\u003e $network_auto_schedule;"},{"line_number":334,"context_line":"    \u0027ovs/integration_bridge\u0027:                   value \u003d\u003e $ovs_integration_bridge;"},{"line_number":335,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e pick($service_providers, $facts[\u0027os_service_default\u0027]);"},{"line_number":336,"context_line":"    \u0027ovs/igmp_snooping_enable\u0027:                 value \u003d\u003e $igmp_snooping_enable;"},{"line_number":337,"context_line":"  }"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3e079fcf_b00aa619","line":335,"updated":"2023-06-21 08:40:15.000000000","message":"no pick()","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"}],"manifests/services/l2gw.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"69a78a288edfd72b1e8562dd3e17faa51c6cb513","unresolved":true,"context_lines":[{"line_number":47,"context_line":"  $default_device_name               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":48,"context_line":"  $quota_l2_gateway                  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":49,"context_line":"  $periodic_monitoring_interval      \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":50,"context_line":"  Optional[Array] $service_providers \u003d undef,"},{"line_number":51,"context_line":"  Boolean $sync_db                   \u003d false,"},{"line_number":52,"context_line":"  $package_ensure                    \u003d \u0027present\u0027,"},{"line_number":53,"context_line":"  $purge_config                      \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5b6ac39e_c2772c83","line":50,"updated":"2023-06-21 08:40:15.000000000","message":"same","commit_id":"43e97a0836e523d3024ea63b1e778fedeb362386"}]}