)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"56a665b2ba0c9f61439ddd485ef14d0caf50baee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a9c26f51_509ef758","updated":"2023-06-18 23:07:31.000000000","message":"I think we can just remove that validation for default_availability_zone now, and can support a string value as well. We can add back validations when we globally add validation logic for ListOpt implemented in all services. See  https://review.opendev.org/c/openstack/puppet-neutron/+/886348\n\nWe probably want to keep the validation for service_providers on the other hand, because the option is MultiSrtOpt and users should use an array to put multiple values.","commit_id":"0d6e35f7e1bdf407dac35e5c884ab4ea0a22cd33"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"58d64050bdce05b44af76902c9b615d63d6a7336","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5fc1fd73_c4bb7827","in_reply_to":"a9c26f51_509ef758","updated":"2023-06-19 00:19:49.000000000","message":"I vote for keeping the typeset !","commit_id":"0d6e35f7e1bdf407dac35e5c884ab4ea0a22cd33"}],"manifests/server.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b6bcdc6543caa9e60d4b3348a4fc2479b844c5a","unresolved":true,"context_lines":[{"line_number":257,"context_line":"  $enable_dvr                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":258,"context_line":"  $network_scheduler_driver                                             \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":259,"context_line":"  Neutron::Dhcp_load_type $dhcp_load_type                               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":260,"context_line":"  Variant[Array, Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]] $default_availability_zones \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":261,"context_line":"  $allow_automatic_l3agent_failover                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":262,"context_line":"  $allow_automatic_dhcp_failover                                        \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":263,"context_line":"  $l3_ha                                                                \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"83c59076_59c64ced","line":260,"range":{"start_line":260,"start_character":23,"end_line":260,"end_character":40},"updated":"2023-06-18 22:55:22.000000000","message":"because this is meant to be same as the os_service_default fact, we\u0027d want to define a type (Openstacklib::Default) in openstacklib and use it instead of hard-coding the same string in each manifest.","commit_id":"0d6e35f7e1bdf407dac35e5c884ab4ea0a22cd33"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"58d64050bdce05b44af76902c9b615d63d6a7336","unresolved":true,"context_lines":[{"line_number":257,"context_line":"  $enable_dvr                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":258,"context_line":"  $network_scheduler_driver                                             \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":259,"context_line":"  Neutron::Dhcp_load_type $dhcp_load_type                               \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":260,"context_line":"  Variant[Array, Enum[\u0027\u003cSERVICE DEFAULT\u003e\u0027]] $default_availability_zones \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":261,"context_line":"  $allow_automatic_l3agent_failover                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":262,"context_line":"  $allow_automatic_dhcp_failover                                        \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":263,"context_line":"  $l3_ha                                                                \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"23c32341_ed52161c","line":260,"range":{"start_line":260,"start_character":23,"end_line":260,"end_character":40},"in_reply_to":"83c59076_59c64ced","updated":"2023-06-19 00:19:49.000000000","message":"Ack, see https://review.opendev.org/c/openstack/puppet-openstacklib/+/885996\nBut I don\u0027t think we should wait two releases until we can use it !","commit_id":"0d6e35f7e1bdf407dac35e5c884ab4ea0a22cd33"}]}
