)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a5f40a2758ea11a71b5b38ef7f1fd6821260db16","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"163f4bcc_ce27163b","updated":"2024-03-11 02:46:34.000000000","message":"Can we add a release note, because this introduces new support coverage ?","commit_id":"2263dd3c5915b578e71c04eeb241eb10ab1758cd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88c002a8c5003b87a1ab03b4aee53d2011238d13","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad971927_735b6c10","in_reply_to":"163f4bcc_ce27163b","updated":"2024-03-11 02:47:00.000000000","message":"I\u0027m ok to merge this if the release note addition is submitted as a follow-up","commit_id":"2263dd3c5915b578e71c04eeb241eb10ab1758cd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f4c5234be1d2fa97f2f946ae3c704e2db2b22774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8951bb7_91ab7aa3","in_reply_to":"ad971927_735b6c10","updated":"2024-03-11 08:37:01.000000000","message":"Done!","commit_id":"2263dd3c5915b578e71c04eeb241eb10ab1758cd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"056fa6c2747a2db2f764cfd27e674702f105ccc7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45bd8b6d_d3947067","updated":"2024-03-11 13:12:33.000000000","message":"The proposed change also affects ubuntu.\nIf we don\u0027t know whether the package will be added to ubuntu then please make the change specific to Debian.\nIf we do then update the release note to also mention Ubuntu.","commit_id":"fe26f03af6942b4ac783527b669c92e514832a84"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"82a4a73cc717763ef73b89ecc04c37bce7c1275e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"177e2e2a_b80513b2","in_reply_to":"45bd8b6d_d3947067","updated":"2024-03-12 22:05:33.000000000","message":"That\u0027s correct, Ubuntu still doesn\u0027t provide a bagpipe agent service or package, so I have let the previous behavior under Unbutu (ie: bagpipe.pp will fail in that OS).\nAs for Debian, the package just passed the NEW queue and is now available in Unstable. I\u0027ll make the backport (in our osbpo.debian.net backport repositories) for having an agent service+package in at least Zed through Caracal shortly.","commit_id":"fe26f03af6942b4ac783527b669c92e514832a84"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"36654a05567ca385a9bb26b7916f395aff09a857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29982917_660500e9","updated":"2024-03-15 02:49:07.000000000","message":"recheck irrelevant failure","commit_id":"bd41a741a274dc375324bfcce62f08ca6fd5358f"}],"manifests/agents/bagpipe.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2d42e4e738120768006145fb4441f2f37e21aa77","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  include neutron::deps"},{"line_number":99,"context_line":"  include neutron::params"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $facts[\u0027os\u0027][\u0027family\u0027] !\u003d \u0027RedHat\u0027 and $facts[\u0027os\u0027][\u0027name\u0027] !\u003d \u0027Debian\u0027 {"},{"line_number":102,"context_line":"    fail(\u0027BaGPipe agent is currently supported only in RedHat OS family or Debian (not Ubuntu).\u0027)"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  resources { \u0027neutron_bgpvpn_bagpipe_config\u0027:"},{"line_number":106,"context_line":"    purge \u003d\u003e $purge_config,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7fd4788d_cbab2a6d","line":103,"range":{"start_line":101,"start_character":2,"end_line":103,"end_character":3},"updated":"2024-03-13 02:06:08.000000000","message":"maybe we can simplify this by\n\n```\nif ! $::neutron::params::bagpipe_bgp_package {\n  fail(\u0027BaGPipe agent is currently unsupported in this operating system.\u0027)\n}\n```","commit_id":"065a9af528bdfdfdfcb5c6ddc39f568840b37f39"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"bad981f7c941d8242bcf42b6b47e320b9a256b84","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  include neutron::deps"},{"line_number":99,"context_line":"  include neutron::params"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if $facts[\u0027os\u0027][\u0027family\u0027] !\u003d \u0027RedHat\u0027 and $facts[\u0027os\u0027][\u0027name\u0027] !\u003d \u0027Debian\u0027 {"},{"line_number":102,"context_line":"    fail(\u0027BaGPipe agent is currently supported only in RedHat OS family or Debian (not Ubuntu).\u0027)"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  resources { \u0027neutron_bgpvpn_bagpipe_config\u0027:"},{"line_number":106,"context_line":"    purge \u003d\u003e $purge_config,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"e8d12622_bbe39dce","line":103,"range":{"start_line":101,"start_character":2,"end_line":103,"end_character":3},"in_reply_to":"7fd4788d_cbab2a6d","updated":"2024-03-13 09:42:37.000000000","message":"Done","commit_id":"065a9af528bdfdfdfcb5c6ddc39f568840b37f39"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1095fc2d0a99de7d6105ff04e3b8955439d372dc","unresolved":true,"context_lines":[{"line_number":91,"context_line":"      }"},{"line_number":92,"context_line":"      $dynamic_routing_package            \u003d \u0027python3-neutron-dynamic-routing\u0027"},{"line_number":93,"context_line":"      $bgp_dragent_package                \u003d \u0027neutron-bgp-dragent\u0027"},{"line_number":94,"context_line":"      $bagpipe_bgp_package                \u003d \u0027networking-bagpipe-bgp-agent\u0027"},{"line_number":95,"context_line":"      $bagpipe_bgp_service                \u003d \u0027networking-bagpipe-bgp-agent\u0027"},{"line_number":96,"context_line":"      $bgpvpn_bagpipe_package             \u003d \u0027python3-networking-bagpipe\u0027"},{"line_number":97,"context_line":"      $ovs_agent_package                  \u003d \u0027neutron-openvswitch-agent\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f4aa2bb_9bc81262","line":94,"range":{"start_line":94,"start_character":44,"end_line":94,"end_character":74},"updated":"2024-03-11 02:55:46.000000000","message":"hmm. does this package really exist ?\n\nI checked [1] but could not find it for Deiban. Also, ubuntu does not provide it, either.\n\n[1] https://packages.debian.org/search?suite\u003dall\u0026searchon\u003dnames\u0026keywords\u003dnetworking-bagpipe-bgp-agent","commit_id":"2263dd3c5915b578e71c04eeb241eb10ab1758cd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"f4c5234be1d2fa97f2f946ae3c704e2db2b22774","unresolved":false,"context_lines":[{"line_number":91,"context_line":"      }"},{"line_number":92,"context_line":"      $dynamic_routing_package            \u003d \u0027python3-neutron-dynamic-routing\u0027"},{"line_number":93,"context_line":"      $bgp_dragent_package                \u003d \u0027neutron-bgp-dragent\u0027"},{"line_number":94,"context_line":"      $bagpipe_bgp_package                \u003d \u0027networking-bagpipe-bgp-agent\u0027"},{"line_number":95,"context_line":"      $bagpipe_bgp_service                \u003d \u0027networking-bagpipe-bgp-agent\u0027"},{"line_number":96,"context_line":"      $bgpvpn_bagpipe_package             \u003d \u0027python3-networking-bagpipe\u0027"},{"line_number":97,"context_line":"      $ovs_agent_package                  \u003d \u0027neutron-openvswitch-agent\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1079fcf8_f5781902","line":94,"range":{"start_line":94,"start_character":44,"end_line":94,"end_character":74},"in_reply_to":"7f4aa2bb_9bc81262","updated":"2024-03-11 08:37:01.000000000","message":"The package was added recently, and is currently waiting in the Debian FTP master NEW queue for approval. I intend to backport the feature up to Victoria.","commit_id":"2263dd3c5915b578e71c04eeb241eb10ab1758cd"}],"spec/classes/neutron_agents_bagpipe_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2d42e4e738120768006145fb4441f2f37e21aa77","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            :bagpipe_bgp_service \u003d\u003e \u0027networking-bagpipe-bgp-agent\u0027 }"},{"line_number":123,"context_line":"        end"},{"line_number":124,"context_line":"      end"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      it_behaves_like \u0027neutron bgpvpn bagpipe agent\u0027"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9603e76a_23a6ba40","line":125,"updated":"2024-03-13 02:06:08.000000000","message":"you have to restore and modify if block","commit_id":"065a9af528bdfdfdfcb5c6ddc39f568840b37f39"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"bad981f7c941d8242bcf42b6b47e320b9a256b84","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            :bagpipe_bgp_service \u003d\u003e \u0027networking-bagpipe-bgp-agent\u0027 }"},{"line_number":123,"context_line":"        end"},{"line_number":124,"context_line":"      end"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"      it_behaves_like \u0027neutron bgpvpn bagpipe agent\u0027"},{"line_number":127,"context_line":"    end"},{"line_number":128,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1af46a89_54306bda","line":125,"in_reply_to":"9603e76a_23a6ba40","updated":"2024-03-13 09:42:37.000000000","message":"Done","commit_id":"065a9af528bdfdfdfcb5c6ddc39f568840b37f39"}]}