)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"adc7033b_16e527c5","updated":"2026-10-06 02:35:27.000000000","message":"Leaving a few suggestions inline","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc1b9b73_5886c63d","updated":"2026-10-06 06:59:26.000000000","message":"adapted all, thanks for reviewing.","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4e2dcee0ba4ef46a23bb778b718e63b11868284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6e7393b0_feeaf84b","updated":"2026-10-06 12:48:46.000000000","message":"Updated the release note slightly for (hopefully) better formatting","commit_id":"c29958d717a9e0e0e24a8c4430d076b8e106122a"}],"manifests/db.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":true,"context_lines":[{"line_number":59,"context_line":"#   before error is raised. Set to -1 to specify an infinite retry count."},{"line_number":60,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# [*connection_parameters*]"},{"line_number":63,"context_line":"#   add connection parameters"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*api_database_connection*]"},{"line_number":66,"context_line":"#   (optional) Connection url to connect to nova api database."},{"line_number":67,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"cb78eab6_fe861057","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":1},"updated":"2026-10-06 02:35:27.000000000","message":"```suggestion\n# [*connection_parameters*]\n#   (Optional) URL parameters to append onto the main DB connection URL at connect time.\n#   Defaults to $facts[\u0027os_service_default\u0027]\n#\n```","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   before error is raised. Set to -1 to specify an infinite retry count."},{"line_number":60,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":61,"context_line":"#"},{"line_number":62,"context_line":"# [*connection_parameters*]"},{"line_number":63,"context_line":"#   add connection parameters"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*api_database_connection*]"},{"line_number":66,"context_line":"#   (optional) Connection url to connect to nova api database."},{"line_number":67,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bd455774_cdf12b93","line":64,"range":{"start_line":62,"start_character":0,"end_line":64,"end_character":1},"in_reply_to":"cb78eab6_fe861057","updated":"2026-10-06 06:59:26.000000000","message":"Done","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":true,"context_lines":[{"line_number":95,"context_line":"#   (Optional) If set, use this value for pool_timeout with SQLAlchemy."},{"line_number":96,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":97,"context_line":"#"},{"line_number":98,"context_line":"# [*api_connection_parameters*]"},{"line_number":99,"context_line":"#   add connection parameters"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":102,"context_line":"#"},{"line_number":103,"context_line":"# [*mysql_enable_ndb*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bbbca18b_e4a32212","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":1},"updated":"2026-10-06 02:35:27.000000000","message":"```suggestion\n# [*api_connection_parameters*]\n#   (Optional) URL parameters to append onto the API DB connection URL at connect time.\n#   Defaults to $facts[\u0027os_service_default\u0027]\n#\n```","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#   (Optional) If set, use this value for pool_timeout with SQLAlchemy."},{"line_number":96,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":97,"context_line":"#"},{"line_number":98,"context_line":"# [*api_connection_parameters*]"},{"line_number":99,"context_line":"#   add connection parameters"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":102,"context_line":"#"},{"line_number":103,"context_line":"# [*mysql_enable_ndb*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4f61911f_8e283270","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":1},"in_reply_to":"bbbca18b_e4a32212","updated":"2026-10-06 06:59:26.000000000","message":"Done","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  $database_max_overflow                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":116,"context_line":"  $database_pool_timeout                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":117,"context_line":"  $database_db_max_retries                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $connection_parameters     \u003d undef,"},{"line_number":119,"context_line":"  $api_database_connection                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $api_slave_connection                                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":121,"context_line":"  $api_database_connection_recycle_time                          \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b72c5201_b86234ba","line":118,"range":{"start_line":118,"start_character":67,"end_line":118,"end_character":72},"updated":"2026-10-06 02:35:27.000000000","message":"use os_service_default fact for consistency","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":true,"context_lines":[{"line_number":115,"context_line":"  $database_max_overflow                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":116,"context_line":"  $database_pool_timeout                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":117,"context_line":"  $database_db_max_retries                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $connection_parameters     \u003d undef,"},{"line_number":119,"context_line":"  $api_database_connection                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $api_slave_connection                                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":121,"context_line":"  $api_database_connection_recycle_time                          \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"f3163ba1_dd4fc7ab","line":118,"range":{"start_line":118,"start_character":67,"end_line":118,"end_character":72},"in_reply_to":"b72c5201_b86234ba","updated":"2026-10-06 06:59:26.000000000","message":"Well this is not really Puppet best practice anymore (years ago when the os_service_default fact was invented, you could not set a parameter to undef. So that\u0027s why this workaround exists). I stronlgy suggest to migrate towards using undef where possible instead of the os_service_default fact. I would not do a migration of all existing parameters, but for new parameters I think we should line up with the Puppet language as much as possible (puppet optional parameters are set to undef). \nSince you probably will insist in this change I adapted.","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6cae851b2a5c2cad8484ecdbff57e7cc5338ee59","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  $database_max_overflow                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":116,"context_line":"  $database_pool_timeout                                         \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":117,"context_line":"  $database_db_max_retries                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":118,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $connection_parameters     \u003d undef,"},{"line_number":119,"context_line":"  $api_database_connection                                       \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":120,"context_line":"  $api_slave_connection                                          \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":121,"context_line":"  $api_database_connection_recycle_time                          \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"b66d2b09_1d5d2e33","line":118,"range":{"start_line":118,"start_character":67,"end_line":118,"end_character":72},"in_reply_to":"f3163ba1_dd4fc7ab","updated":"2026-10-06 12:47:44.000000000","message":"I\u0027m not against using undef but I\u0027d rather prefer consistency (within manifest, across modules). we can do migration separately.","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":true,"context_lines":[{"line_number":124,"context_line":"  $api_database_retry_interval                                   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":125,"context_line":"  $api_database_max_overflow                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":126,"context_line":"  $api_database_pool_timeout                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":127,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $api_connection_parameters \u003d undef,"},{"line_number":128,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":129,"context_line":"  $mysql_enable_ndb                     \u003d undef,"},{"line_number":130,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e61d00ce_08e64c60","line":127,"range":{"start_line":127,"start_character":67,"end_line":127,"end_character":72},"updated":"2026-10-06 02:35:27.000000000","message":"ditto","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6cae851b2a5c2cad8484ecdbff57e7cc5338ee59","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  $api_database_retry_interval                                   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":125,"context_line":"  $api_database_max_overflow                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":126,"context_line":"  $api_database_pool_timeout                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":127,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $api_connection_parameters \u003d undef,"},{"line_number":128,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":129,"context_line":"  $mysql_enable_ndb                     \u003d undef,"},{"line_number":130,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"803b06c6_fc5c320f","line":127,"range":{"start_line":127,"start_character":67,"end_line":127,"end_character":72},"in_reply_to":"1cc554c9_802a6e92","updated":"2026-10-06 12:47:44.000000000","message":"Done","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":true,"context_lines":[{"line_number":124,"context_line":"  $api_database_retry_interval                                   \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":125,"context_line":"  $api_database_max_overflow                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":126,"context_line":"  $api_database_pool_timeout                                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":127,"context_line":"  Optional[Oslo::Dbconn::Conn_params] $api_connection_parameters \u003d undef,"},{"line_number":128,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":129,"context_line":"  $mysql_enable_ndb                     \u003d undef,"},{"line_number":130,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1cc554c9_802a6e92","line":127,"range":{"start_line":127,"start_character":67,"end_line":127,"end_character":72},"in_reply_to":"e61d00ce_08e64c60","updated":"2026-10-06 06:59:26.000000000","message":"ditto","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"}],"releasenotes/notes/add_db_connection_parameters-810fca2fa3e6da62.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a437ccd0eb43c753e1151b77c4e1dfc919c92b63","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add possibility to specify database connection parameters."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3ad0a6ce_42939c3f","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":62},"updated":"2026-10-06 02:35:27.000000000","message":"I\u0027d rather mention the specific option names ( ``[database] connection_parameters`` and ``[api_database] connection_parameters`` ), to describe the responsibility of the moudle.","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d87208b6315f9344b91c672c4c0e23e49b2c1e17","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add possibility to specify database connection parameters."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f8615ee_740bb5dc","line":4,"range":{"start_line":4,"start_character":23,"end_line":4,"end_character":62},"in_reply_to":"3ad0a6ce_42939c3f","updated":"2026-10-06 06:59:26.000000000","message":"Done","commit_id":"7678352f2d39802290606488a5a5eb3f7c048ba4"}]}