)]}'
{"manifests/compute/rbd.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"38faac354791a870a7f6afa354f22d2f1b2a2bac","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  # Fedora is the only one that has a different name"},{"line_number":57,"context_line":"  # for the ceph client package"},{"line_number":58,"context_line":"  if $operatingsystem \u003d\u003d \"Fedora\" {"},{"line_number":59,"context_line":"    $ceph_package \u003d \"ceph\""},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"baada198_063cc6be","line":58,"updated":"2014-07-09 20:57:44.000000000","message":"Puppet-lint is failing cause of:\n- $::operatingsystem instead of $operatingsystem\n- You use double quote instead of simple quote","commit_id":"e9e27155d4dce8921310fea7e12fc37df9abbdd4"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8e136e02769fb922af8cd58d686a744bf3b452c5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  # Fedora is the only one that has a different name"},{"line_number":57,"context_line":"  # for the ceph client package"},{"line_number":58,"context_line":"  if $::operatingsystem \u003d\u003d \u0027Fedora\u0027 {"},{"line_number":59,"context_line":"    $ceph_package \u003d \u0027ceph\u0027"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_bd9fa002","line":58,"updated":"2014-07-10 02:02:06.000000000","message":"This ought to be in nova::params.","commit_id":"e523b5d1f2d56fa0e708371879cca659c592fbd4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6b3e90e06217907c7429712ee7703b15f4e2fd29","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  # Install ceph client libraries"},{"line_number":57,"context_line":"  package { \u0027ceph_client_package\u0027:"},{"line_number":58,"context_line":"    ensure \u003d\u003e \u0027installed\u0027,"},{"line_number":59,"context_line":"    name   \u003d\u003e $nova::params::ceph_client_package_name,"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9aa7fdbe_47d36938","line":58,"updated":"2014-10-20 01:47:44.000000000","message":"I think we should do like with other packages. Make them optional.","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"a755186d262d2da84e8556f3b48ccfc3e10a94ac","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  # Install ceph client libraries"},{"line_number":57,"context_line":"  package { \u0027ceph_client_package\u0027:"},{"line_number":58,"context_line":"    ensure \u003d\u003e \u0027installed\u0027,"},{"line_number":59,"context_line":"    name   \u003d\u003e $nova::params::ceph_client_package_name,"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a930d6b_3fc81874","line":58,"updated":"2015-01-21 14:12:38.000000000","message":"This shouldn\u0027t be hard coded to \u0027installed\u0027, the class should take a $package_ensure parameter like most other classes do.\n\nEmilien, are you suggesting add a $manage_package variable or some such?  Would adding $package_ensure address that?  It could be set to undef or absent, depending on what the user needed.","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7574dae50a948175d46d70cd31604da9c2fb4abf","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  # Install ceph client libraries"},{"line_number":57,"context_line":"  package { \u0027ceph_client_package\u0027:"},{"line_number":58,"context_line":"    ensure \u003d\u003e \u0027installed\u0027,"},{"line_number":59,"context_line":"    name   \u003d\u003e $nova::params::ceph_client_package_name,"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"fa963961_29669ced","line":58,"in_reply_to":"1a930d6b_3fc81874","updated":"2015-03-27 18:54:22.000000000","message":"The other nova::compute::* classes just hard code to \u0027present\u0027, since it\u0027s assumed that if you\u0027re including this class then you need those packages.","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"a755186d262d2da84e8556f3b48ccfc3e10a94ac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      creates \u003d\u003e \u0027/etc/nova/virsh.secret\u0027,"},{"line_number":81,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":85,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret $(cat /etc/nova/virsh.secret) --base64 $(ceph auth get-key ${rbd_keyring})\","},{"line_number":86,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-list | grep ${rbd_keyring}\","}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a930d6b_7fb620de","line":83,"updated":"2015-01-21 14:12:38.000000000","message":"You need to add a require on the ceph package to this Exec.","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"69fea69ba52592ee07c62bc90a47cf1d1b45d302","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  if $manage_ceph_client {"},{"line_number":81,"context_line":"    # Install ceph client libraries"},{"line_number":82,"context_line":"    package { \u0027ceph_client_package\u0027:"},{"line_number":83,"context_line":"      ensure \u003d\u003e $ceph_client_ensure,"},{"line_number":84,"context_line":"      name   \u003d\u003e $nova::params::ceph_client_package_name,"},{"line_number":85,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027],"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a5de9d1_2f7462cd","line":82,"updated":"2016-01-29 00:03:40.000000000","message":"i know this is really picky, but can we use - for the name instead of _? All the other names for packages in nova have - in them.","commit_id":"8ebd0b9a6d85df20c25000268b787e7ec8a7795e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d219f6fec6bbfb2bb27250eb4550a26bb91bb546","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  if $manage_ceph_client {"},{"line_number":81,"context_line":"    # Install ceph client libraries"},{"line_number":82,"context_line":"    package { \u0027ceph_client_package\u0027:"},{"line_number":83,"context_line":"      ensure \u003d\u003e $ceph_client_ensure,"},{"line_number":84,"context_line":"      name   \u003d\u003e $nova::params::ceph_client_package_name,"},{"line_number":85,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027],"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"7a5de9d1_cffd8e3b","line":82,"updated":"2016-01-29 00:00:56.000000000","message":"i know this is really picky, but can we use - for the name instead of _? All the other names for packages in nova have - in them.","commit_id":"8ebd0b9a6d85df20c25000268b787e7ec8a7795e"}],"manifests/params.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"1611ab8a853be76c7421b7d55e99f3fa9a1770c8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          $special_service_provider \u003d undef"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027: {"},{"line_number":48,"context_line":"          if ($::operatingsystemmajrelease \u003c 7) {"},{"line_number":49,"context_line":"            $special_service_provider \u003d \u0027init\u0027"},{"line_number":50,"context_line":"          } else {"},{"line_number":51,"context_line":"            $special_service_provider \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a890539_2f688620","side":"PARENT","line":48,"updated":"2014-11-21 15:05:53.000000000","message":"You can use the fact `operatingsystemmajrelease` to get `$sysrelease` value you are looking for here","commit_id":"93a0c27ac9f4a4eeec761250838aae2e321eb1b1"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"0a098f98f5b71e6652412fd12c08131cc2833c2a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"          $special_service_provider \u003d undef"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027: {"},{"line_number":49,"context_line":"          if is_string($::operatingsystemrelease) {"},{"line_number":50,"context_line":"            $sysrelease \u003d values_at(split($::operatingsystemrelease, \u0027.\u0027), 0)"},{"line_number":51,"context_line":"          } else {"},{"line_number":52,"context_line":"            $sysrelease \u003d $::operatingsystemrelease"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"5a890539_8f95fae5","line":49,"updated":"2014-11-21 15:13:36.000000000","message":"You can use the fact `operatingsystemmajrelease` to get `$sysrelease` value you are looking for here\n\nExample: https://github.com/stackforge/puppet-cinder/blob/master/manifests/params.pp#L44-L49","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"}],"spec/classes/nova_compute_libvirt_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6b3e90e06217907c7429712ee7703b15f4e2fd29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9aa7fdbe_271745ef","updated":"2014-10-20 01:47:44.000000000","message":"Instead of deleting a test, I would rather test both contexts, to validate your params.pp syntax.","commit_id":"a59a249efcaab79f0809cfa450ef9405393a491f"}]}