)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"12349850a9e6640238f66ab9acc56bea296265ba","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Notes:"},{"line_number":12,"context_line":"- We keep the same default behavior by defaulting use_libvirt to true"},{"line_number":13,"context_line":"- We do not ensure absent if use_libvirt is false"},{"line_number":14,"context_line":"  (as not to possibly break current implementations)"},{"line_number":15,"context_line":"- With this commit, libvirt_rbd_user, libvirt_rbd_secret_uuid become a"},{"line_number":16,"context_line":"  bit redundant and should probably be deprecated in favor of rbd_user"},{"line_number":17,"context_line":"  and rbd_secret_uuid."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_530d5536","line":14,"updated":"2015-03-25 22:39:57.000000000","message":"The default is true so I don\u0027t think it would break current implementations to have it ensure absent.","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"}],"manifests/compute/rbd.pp":[{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"2a83b3ec6cdd559b8906afd9c72d99e19e49dd77","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      \u0027libvirt/images_type\u0027:          value \u003d\u003e \u0027rbd\u0027;"},{"line_number":70,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      value \u003d\u003e $libvirt_images_rbd_pool;"},{"line_number":71,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: value \u003d\u003e $libvirt_images_rbd_ceph_conf;"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa98f980_163a6334","line":72,"updated":"2014-09-17 06:27:06.000000000","message":"If we set use_libvirt \u003dtrue and then change it to false. These options would still stay in nova.conf.\nI think it\u0027s better to add else logic.","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a6742a9283a054857de6561c4acd592472f35faf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      value \u003d\u003e $libvirt_images_rbd_pool;"},{"line_number":71,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: value \u003d\u003e $libvirt_images_rbd_ceph_conf;"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"},{"line_number":76,"context_line":"    if $use_libvirt {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a890539_e859af35","line":73,"updated":"2014-11-18 01:27:52.000000000","message":"@Xingchao: could you give us an example of what you have in mind?","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"12349850a9e6640238f66ab9acc56bea296265ba","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      value \u003d\u003e $libvirt_images_rbd_pool;"},{"line_number":71,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: value \u003d\u003e $libvirt_images_rbd_ceph_conf;"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"},{"line_number":76,"context_line":"    if $use_libvirt {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_f84c5ea0","line":73,"in_reply_to":"5a890539_e859af35","updated":"2015-03-25 22:39:57.000000000","message":"I think Xingchao is looking for\n\n else {\n    nova_config {\n      \u0027libvirt/images_type\u0027: ensure \u003d\u003e absent\n      #...\n    }\n  }\n\nsimilar to http://git.openstack.org/cgit/stackforge/puppet-nova/tree/manifests/init.pp#n458","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"2a83b3ec6cdd559b8906afd9c72d99e19e49dd77","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"},{"line_number":76,"context_line":"    if $use_libvirt {"},{"line_number":77,"context_line":"      nova_config {"},{"line_number":78,"context_line":"        \u0027libvirt/rbd_secret_uuid\u0027: value \u003d\u003e $libvirt_rbd_secret_uuid;"},{"line_number":79,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa98f980_56d6abf2","line":76,"updated":"2014-09-17 06:27:06.000000000","message":"it should be if ! $use_libvirt here.\nwhen use_libvirt is false, it means use ceph backend cinder volume, so it need use this option.","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a6742a9283a054857de6561c4acd592472f35faf","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"},{"line_number":76,"context_line":"    if $use_libvirt {"},{"line_number":77,"context_line":"      nova_config {"},{"line_number":78,"context_line":"        \u0027libvirt/rbd_secret_uuid\u0027: value \u003d\u003e $libvirt_rbd_secret_uuid;"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a890539_08443b48","line":77,"updated":"2014-11-18 01:27:52.000000000","message":"@Xingchao: I think he did that to maintain backward compatibility and do not break current deployments.","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"476ce7bb87c195c44c95f0e035f4e7855449a530","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  if $libvirt_rbd_secret_uuid {"},{"line_number":76,"context_line":"    if $use_libvirt {"},{"line_number":77,"context_line":"      nova_config {"},{"line_number":78,"context_line":"        \u0027libvirt/rbd_secret_uuid\u0027: value \u003d\u003e $libvirt_rbd_secret_uuid;"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da9b358b_2b17bc52","line":78,"updated":"2015-03-30 16:40:14.000000000","message":"we need rbd_secret_uuid when $use_libvirt is false as well, that and rbd_user are the only two we need in that case so both can be set regardless of $use_libvirt","commit_id":"6ef45cad27d817cb60435282b2ce6f6fca23e337"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e6b77c1b1096b6f25d3a54401269d9e3c90fb507","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"  } else {"},{"line_number":111,"context_line":"    nova_config {"},{"line_number":112,"context_line":"      \u0027libvirt/images_type\u0027:          ensure \u003d\u003e absent;"},{"line_number":113,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      ensure \u003d\u003e absent;"},{"line_number":114,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: ensure \u003d\u003e absent;"},{"line_number":115,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a016987_545d7f13","line":112,"updated":"2015-05-21 13:58:44.000000000","message":"On a second thought, should we set this to absent? Someone might want to set the images_type to something different from elsewhere in Puppet... Setting the images_rbd_* to absent is probably okay.","commit_id":"fc978ed075a596b111e18161ecb0083c52686f46"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2bd081291ca0dcc5e466a25f3630c18e849a21c2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"  } else {"},{"line_number":111,"context_line":"    nova_config {"},{"line_number":112,"context_line":"      \u0027libvirt/images_type\u0027:          ensure \u003d\u003e absent;"},{"line_number":113,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      ensure \u003d\u003e absent;"},{"line_number":114,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: ensure \u003d\u003e absent;"},{"line_number":115,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a016987_54d69ff1","line":112,"in_reply_to":"7a016987_545d7f13","updated":"2015-05-21 14:21:08.000000000","message":"thanks for checking this, comment seems valid to me, will remove L112","commit_id":"fc978ed075a596b111e18161ecb0083c52686f46"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"b4f8f9c89a52aba3f4bc72d87f0a68567dd86423","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    concat { \u0027/etc/nova/secret.xml\u0027: }"},{"line_number":80,"context_line":"    concat::fragment { \u0027/etc/nova/secret.xml\u0027:"},{"line_number":81,"context_line":"      target  \u003d\u003e \u0027/etc/nova/secret.xml\u0027,"},{"line_number":82,"context_line":"      content \u003d\u003e template(\u0027nova/secret.xml-compute.erb\u0027),"},{"line_number":83,"context_line":"      require \u003d\u003e Class[\u0027::nova\u0027]"},{"line_number":84,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3afb71cf_bc1ce3c1","line":81,"updated":"2015-06-09 00:09:11.000000000","message":"This change does not appear to be relevant to the rest of the patch and isn\u0027t explained in the commit message.","commit_id":"2b76954aa96d7d31e106690f9d999a41374829ea"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"99cc3b5839643657c42984075fd5acca86621003","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*ephemeral_storage*]"},{"line_number":53,"context_line":"#   (optional) Wether or not to use the rbd driver for the nova"},{"line_number":54,"context_line":"#   ephmeral storage or for the cinder volumes only."},{"line_number":55,"context_line":"#   Defaults to true."},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"fa32b979_442677bb","line":54,"updated":"2015-06-22 12:58:53.000000000","message":"typo: ephemeral","commit_id":"ab22941afa76fdda4f386196cf2de0bf478b0ef5"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f5e6a2dec300bfd06a0a931eb50b178902cfcb46","unresolved":false,"context_lines":[{"line_number":51,"context_line":"#"},{"line_number":52,"context_line":"# [*ephemeral_storage*]"},{"line_number":53,"context_line":"#   (optional) Wether or not to use the rbd driver for the nova"},{"line_number":54,"context_line":"#   ephmeral storage or for the cinder volumes only."},{"line_number":55,"context_line":"#   Defaults to true."},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"fa32b979_da91029c","line":54,"in_reply_to":"fa32b979_442677bb","updated":"2015-06-22 13:41:31.000000000","message":"will fix","commit_id":"ab22941afa76fdda4f386196cf2de0bf478b0ef5"}]}