)]}'
{"manifests/api.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"48034f4bcd1c7753bd2d84f848416875c0085f19","unresolved":false,"context_lines":[{"line_number":379,"context_line":"      $tries     \u003d\u003e $tries,"},{"line_number":380,"context_line":"      $try_sleep \u003d\u003e $try_sleep,"},{"line_number":381,"context_line":"      subscribe   \u003d\u003e Service[\u0027nova-api\u0027],"},{"line_number":382,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":383,"context_line":"    }"},{"line_number":384,"context_line":"  }"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a8c0949_4e109d01","line":382,"updated":"2014-11-05 10:25:37.000000000","message":"align arrows","commit_id":"7f554d524938cac979331b77c9f3ef6805d1189d"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"910da3422af68feeff2cb137d839db3553b5b3bf","unresolved":false,"context_lines":[{"line_number":121,"context_line":"#   Defaults to false"},{"line_number":122,"context_line":"#"},{"line_number":123,"context_line":"# [*validate*]"},{"line_number":124,"context_line":"# (optional) Whether to validate the service is working"},{"line_number":125,"context_line":"# after any service refreshes"},{"line_number":126,"context_line":"# Defaults to false"},{"line_number":127,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8c0949_d1598d5c","line":124,"updated":"2014-11-05 13:57:32.000000000","message":"not sure how much this matters, but your 2nd line in these is not lined up with the rest of the file, should be moved over 1 space.","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cf1bd6dbd97cdeb308bece44daa8cf8f9f8ebf81","unresolved":false,"context_lines":[{"line_number":121,"context_line":"#   Defaults to false"},{"line_number":122,"context_line":"#"},{"line_number":123,"context_line":"# [*validate*]"},{"line_number":124,"context_line":"# (optional) Whether to validate the service is working"},{"line_number":125,"context_line":"# after any service refreshes"},{"line_number":126,"context_line":"# Defaults to false"},{"line_number":127,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8c0949_d4209bb2","line":124,"in_reply_to":"7a8c0949_d1598d5c","updated":"2014-11-05 14:41:08.000000000","message":"and the original syntax is wrong, it\u0027s should respect the syntax I\u0027m using.\nI\u0027ll do a separate patchset to fix it later.","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"910da3422af68feeff2cb137d839db3553b5b3bf","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \u0027filter:authtoken/auth_admin_prefix\u0027: ensure \u003d\u003e absent;"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"  if $insecure {"},{"line_number":358,"context_line":"    $insecure_s \u003d \u0027--insecure\u0027"},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    $insecure_s \u003d \u0027\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8c0949_f1812990","line":357,"updated":"2014-11-05 13:57:32.000000000","message":"why not have these blocks inside if $validate?","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"fec8eb1d1f729ec20a641a0a2282162fe3685eca","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \u0027filter:authtoken/auth_admin_prefix\u0027: ensure \u003d\u003e absent;"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"  if $insecure {"},{"line_number":358,"context_line":"    $insecure_s \u003d \u0027--insecure\u0027"},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    $insecure_s \u003d \u0027\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8c0949_cac9d27a","line":357,"in_reply_to":"7a8c0949_b425cfc3","updated":"2014-11-05 16:10:45.000000000","message":"I think matt is correct because insecure_s and cacert_s are only used if validate is true.","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8dc14bfdbbd7303c8a7cbe2c84fa2848eb6b9976","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \u0027filter:authtoken/auth_admin_prefix\u0027: ensure \u003d\u003e absent;"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"  if $insecure {"},{"line_number":358,"context_line":"    $insecure_s \u003d \u0027--insecure\u0027"},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    $insecure_s \u003d \u0027\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a890539_7bf3a20a","line":357,"in_reply_to":"7a8c0949_cac9d27a","updated":"2014-11-10 10:00:45.000000000","message":"Done","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cf1bd6dbd97cdeb308bece44daa8cf8f9f8ebf81","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    \u0027filter:authtoken/auth_admin_prefix\u0027: ensure \u003d\u003e absent;"},{"line_number":355,"context_line":"  }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"  if $insecure {"},{"line_number":358,"context_line":"    $insecure_s \u003d \u0027--insecure\u0027"},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    $insecure_s \u003d \u0027\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a8c0949_b425cfc3","line":357,"in_reply_to":"7a8c0949_f1812990","updated":"2014-11-05 14:41:08.000000000","message":"they have no relation with validation.\nIt\u0027s just that I wanted to re-use those parameters.","commit_id":"7bf346fe5e9f10414a7be7b8158c450ff614c32c"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"59362e8d3d1f794b10dbef9840c58810fc2c6270","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  $ratelimits            \u003d undef,"},{"line_number":186,"context_line":"  $ratelimits_factory    \u003d"},{"line_number":187,"context_line":"    \u0027nova.api.openstack.compute.limits:RateLimitingMiddleware.factory\u0027,"},{"line_number":188,"context_line":"  $validate              \u003d false,"},{"line_number":189,"context_line":"  $command               \u003d false,"},{"line_number":190,"context_line":"  $path                  \u003d \u0027/usr/bin:/bin:/usr/sbin:/sbin\u0027,"},{"line_number":191,"context_line":"  $provider              \u003d \u0027shell\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"5a890539_d4e87bb6","line":188,"updated":"2014-11-13 16:25:32.000000000","message":"This should be named validate_service. validate is too broad.","commit_id":"dc3db8620a66212119e25c8b1426730a5d120d13"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"9895d49f8c01b4c70a6c32d538200be8e05f07b4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  $ratelimits            \u003d undef,"},{"line_number":186,"context_line":"  $ratelimits_factory    \u003d"},{"line_number":187,"context_line":"    \u0027nova.api.openstack.compute.limits:RateLimitingMiddleware.factory\u0027,"},{"line_number":188,"context_line":"  $validate              \u003d false,"},{"line_number":189,"context_line":"  $validation_command    \u003d false,"},{"line_number":190,"context_line":"  $validation_path       \u003d \u0027/usr/bin:/bin:/usr/sbin:/sbin\u0027,"},{"line_number":191,"context_line":"  $validation_provider   \u003d \u0027shell\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5a890539_23f07566","line":188,"updated":"2014-11-14 19:26:18.000000000","message":"This should be $validate_service to follow the same schema as $manage_service, etc.","commit_id":"4f08ee3fb205e457788ea32917c9add295b1358a"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"9895d49f8c01b4c70a6c32d538200be8e05f07b4","unresolved":false,"context_lines":[{"line_number":191,"context_line":"  $validation_provider   \u003d \u0027shell\u0027,"},{"line_number":192,"context_line":"  $validation_tries      \u003d 10,"},{"line_number":193,"context_line":"  $validation_try_sleep  \u003d 2,"},{"line_number":194,"context_line":"  $insecure              \u003d false,"},{"line_number":195,"context_line":"  $cacert                \u003d undef,"},{"line_number":196,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":197,"context_line":"  $workers               \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5a890539_83ebe976","line":194,"updated":"2014-11-14 19:26:18.000000000","message":"This should be prefixed too to not conflict or confuse with insecure from keystonemiddleware.","commit_id":"4f08ee3fb205e457788ea32917c9add295b1358a"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"9895d49f8c01b4c70a6c32d538200be8e05f07b4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  $validation_tries      \u003d 10,"},{"line_number":193,"context_line":"  $validation_try_sleep  \u003d 2,"},{"line_number":194,"context_line":"  $insecure              \u003d false,"},{"line_number":195,"context_line":"  $cacert                \u003d undef,"},{"line_number":196,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":197,"context_line":"  $workers               \u003d undef,"},{"line_number":198,"context_line":"  $conductor_workers     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"5a890539_239795ed","line":195,"updated":"2014-11-14 19:26:18.000000000","message":"This should be prefixed too to not conflict or confuse with ca_file from Nova.","commit_id":"4f08ee3fb205e457788ea32917c9add295b1358a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"f97668971e5de88529de9dcf7a338f2667e97cb4","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        \u0027command\u0027  \u003d\u003e \"nova --os-auth-url ${auth_uri_real} --os-tenant-name ${admin_tenant_name} --os-username ${admin_user} --os-password ${admin_password} flavor-list\","},{"line_number":339,"context_line":"      }"},{"line_number":340,"context_line":"    }"},{"line_number":341,"context_line":"    $valitation_options_hash \u003d merge ($defaults, $validation_options)"},{"line_number":342,"context_line":"    create_resources(\u0027openstacklib::service_validation\u0027, $valitation_options_hash, {\u0027subscribe\u0027 \u003d\u003e \u0027Service[nova-api]\u0027})"},{"line_number":343,"context_line":"  }"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"5a890539_c8fb2a45","line":341,"updated":"2014-11-17 13:46:13.000000000","message":"Typo/spelling error here. ($valitation_options)","commit_id":"5f7665413333ed9c4641956c574d283cefcf6907"}]}