)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"3d950e2119f29b1bf1c6d6f85704e0496016bc55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a80dd14_5653f1e1","updated":"2015-03-17 13:49:42.000000000","message":"I\u0027d like to see the commit message also mention that this is switching from a nova-manage backend to using the nova client.","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"3d950e2119f29b1bf1c6d6f85704e0496016bc55","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support allow_start and allow_end parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new nova version added this paramters that allow users"},{"line_number":10,"context_line":"to set a range of allowed ip\u0027s for instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Conflicts:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_b6ec2d2b","line":9,"updated":"2015-03-17 13:49:42.000000000","message":"Typo","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"3d950e2119f29b1bf1c6d6f85704e0496016bc55","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The new nova version added this paramters that allow users"},{"line_number":10,"context_line":"to set a range of allowed ip\u0027s for instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Conflicts:"},{"line_number":13,"context_line":"\tmanifests/network.pp"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic0eae504f462d198e5f38d1d8ad596f49411506f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_76463551","line":12,"updated":"2015-03-17 13:49:42.000000000","message":"Since this is a new change, I don\u0027t think you should have a Conflicts: tag in the commit message.","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1d126fd51fb4c6f3fb099cd84706fd22357fa2a3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to set a range of allowed ip\u0027s for instances."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Conflicts:"},{"line_number":13,"context_line":"\tmanifests/network.pp"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic0eae504f462d198e5f38d1d8ad596f49411506f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a41bdd9_a79253f4","line":13,"updated":"2015-07-16 01:02:28.000000000","message":"Still need to drop this. Conflicts appear in merge commits, this is just a new change and should not have any conflicts.","commit_id":"3e90623a2942e27d72c637afc163a26b678b7dc0"}],"lib/puppet/provider/nova_network/nova_manage.rb":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  desc \"Manage nova network\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  optional_commands :nova_manage \u003d\u003e \u0027nova-manage\u0027, :nova \u003d\u003e \u0027nova\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  # I need to setup caching and what-not to make this lookup performance not suck"},{"line_number":8,"context_line":"  def self.instances"},{"line_number":9,"context_line":"    begin"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_ad5a704d","line":6,"updated":"2014-12-03 23:08:58.000000000","message":"suggesting changing to nova_networking. Nova is too ambiguous.","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      :vlan_start       \u003d\u003e \u0027--vlan-start\u0027,"},{"line_number":34,"context_line":"      :allowed_start    \u003d\u003e \u0027--allowed-start\u0027,"},{"line_number":35,"context_line":"      :allowed_end      \u003d\u003e \u0027--allowed-end\u0027,"},{"line_number":36,"context_line":"    }.each do |param, opt|"},{"line_number":37,"context_line":"      if resource[param]"},{"line_number":38,"context_line":"        optional_opts.push(opt).push(resource[param])"},{"line_number":39,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_6d3c08e2","line":36,"updated":"2014-12-03 23:08:58.000000000","message":"do you need comma for the last element?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"277984c89318a4617154416b83c0294bc7b7364a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      :vlan_start       \u003d\u003e \u0027--vlan-start\u0027,"},{"line_number":34,"context_line":"      :allowed_start    \u003d\u003e \u0027--allowed-start\u0027,"},{"line_number":35,"context_line":"      :allowed_end      \u003d\u003e \u0027--allowed-end\u0027,"},{"line_number":36,"context_line":"    }.each do |param, opt|"},{"line_number":37,"context_line":"      if resource[param]"},{"line_number":38,"context_line":"        optional_opts.push(opt).push(resource[param])"},{"line_number":39,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a930d6b_3f3498dd","line":36,"in_reply_to":"5a890539_6d3c08e2","updated":"2015-01-21 14:01:21.000000000","message":"I generally think that putting a comma on the last element is a good practice.  Seems like a matter of style.","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    nova(\u0027network-create\u0027,"},{"line_number":43,"context_line":"      resource[:label],"},{"line_number":44,"context_line":"      \u0027--fixed-range-v4\u0027,"},{"line_number":45,"context_line":"      resource[:name],"},{"line_number":46,"context_line":"      optional_opts"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_a8d97e84","line":45,"updated":"2014-12-03 23:08:58.000000000","message":"where is that stated which parameters are valid besides \"--fixed-range-v4\"?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"9a486129459b2725ca0dfa4a525738a35161bfe9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    nova(\u0027network-create\u0027,"},{"line_number":43,"context_line":"      resource[:label],"},{"line_number":44,"context_line":"      \u0027--fixed-range-v4\u0027,"},{"line_number":45,"context_line":"      resource[:name],"},{"line_number":46,"context_line":"      optional_opts"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a961159_b8345249","line":45,"in_reply_to":"5a890539_a8d97e84","updated":"2015-01-17 01:06:35.000000000","message":"Those parameters are mandatory, the others are optional","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      resource[:label],"},{"line_number":44,"context_line":"      \u0027--fixed-range-v4\u0027,"},{"line_number":45,"context_line":"      resource[:name],"},{"line_number":46,"context_line":"      optional_opts"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_c8b6ca3d","line":46,"updated":"2014-12-03 23:08:58.000000000","message":"do you need to document handle deprecated num_networks and network_size arguments?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"9a486129459b2725ca0dfa4a525738a35161bfe9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      resource[:label],"},{"line_number":44,"context_line":"      \u0027--fixed-range-v4\u0027,"},{"line_number":45,"context_line":"      resource[:name],"},{"line_number":46,"context_line":"      optional_opts"},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a961159_78f10a69","line":46,"in_reply_to":"5a890539_c8b6ca3d","updated":"2015-01-17 01:06:35.000000000","message":"i\u0027m not sure how to handle parameter deprecation","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      :bridge           \u003d\u003e \u0027--bridge\u0027,"},{"line_number":33,"context_line":"      :vlan_start       \u003d\u003e \u0027--vlan-start\u0027,"},{"line_number":34,"context_line":"      :allowed_start    \u003d\u003e \u0027--allowed-start\u0027,"},{"line_number":35,"context_line":"      :allowed_end      \u003d\u003e \u0027--allowed-end\u0027,"},{"line_number":36,"context_line":"    }.each do |param, opt|"},{"line_number":37,"context_line":"      if resource[param]"},{"line_number":38,"context_line":"        optional_opts.push(opt).push(resource[param])"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a80dd14_5513e60c","line":35,"updated":"2015-03-17 14:22:26.000000000","message":"drop last comma.","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b4283c2f9d21d618d4a84a787c30990e882ba8ef","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    nova(\u0027network-create\u0027,"},{"line_number":43,"context_line":"      resource[:label],"},{"line_number":44,"context_line":"      \u0027--fixed-range-v4\u0027,"},{"line_number":45,"context_line":"      resource[:name],"},{"line_number":46,"context_line":"      optional_opts"},{"line_number":47,"context_line":"    )"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a50d1a3_74110cac","line":44,"updated":"2015-07-20 15:04:35.000000000","message":"This fine for a single network but previous version was trying to handle multiple networks. Was that just dead code?","commit_id":"9eaf5d74a5f78426798b174bbee8cd453d747ef3"}],"lib/puppet/type/nova_network.rb":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"b46fef394c85d37b42f701d7ec0beb4211829e3d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  newparam(:dns2) do"},{"line_number":38,"context_line":"  end"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  newparam(:allowed_start) do"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  newparam(:allowed_end) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_aa805647","line":40,"updated":"2014-11-18 22:23:40.000000000","message":"Could we add a description here and a check that this is an actual ip address using newvalues().","commit_id":"f303219e131e809111bc60e1eb5ce9f8eb24095c"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"b46fef394c85d37b42f701d7ec0beb4211829e3d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  newparam(:allowed_start) do"},{"line_number":41,"context_line":"  end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  newparam(:allowed_end) do"},{"line_number":44,"context_line":"  end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  newparam(:vlan_start) do"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5a890539_ca94c28e","line":43,"updated":"2014-11-18 22:23:40.000000000","message":"ditto","commit_id":"f303219e131e809111bc60e1eb5ce9f8eb24095c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    desc \u0027Start of allowed addresses for instances\u0027"},{"line_number":42,"context_line":"    newvalues(/^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$/)"},{"line_number":43,"context_line":"  end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  newparam(:allowed_end) do"},{"line_number":46,"context_line":"    desc \u0027End of allowed addresses for instances\u0027"},{"line_number":47,"context_line":"    newvalues(/^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$/)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_082e1243","line":44,"updated":"2014-12-03 23:08:58.000000000","message":"That is specific to v4 option specified in previous file. SHould that be conditional based on the option specified?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  end"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  newparam(:network_size) do"},{"line_number":54,"context_line":"    defaultto(\u0027256\u0027)"},{"line_number":55,"context_line":"  end"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  validate do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_0839b2a3","line":54,"updated":"2014-12-03 23:08:58.000000000","message":"Isn\u0027t that deprecated now?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"}],"manifests/manage/network.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"b46fef394c85d37b42f701d7ec0beb4211829e3d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# [*project*]"},{"line_number":19,"context_line":"#   (optional) Project that network should be associated with"},{"line_number":20,"context_line":"#   Defaults to undef"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"define nova::manage::network ("},{"line_number":23,"context_line":"  $network,"},{"line_number":24,"context_line":"  $label         \u003d \u0027novanetwork\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_aa45b618","line":21,"updated":"2014-11-18 22:23:40.000000000","message":"I know it has been commented in manifest/network.pp but since documentation has been kep up to date here can you copy/paste it here also ?","commit_id":"f303219e131e809111bc60e1eb5ce9f8eb24095c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fd7a7cc253ce88ec224a1b37c35ac266c0adcc8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $vlan_start    \u003d undef,"},{"line_number":34,"context_line":"  $project       \u003d undef,"},{"line_number":35,"context_line":"  $allowed_start \u003d undef,"},{"line_number":36,"context_line":"  $allowed_end   \u003d undef,"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  File[\u0027/etc/nova/nova.conf\u0027] -\u003e Nova_network[$name]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a890539_8896824a","line":36,"updated":"2014-12-03 23:08:58.000000000","message":"What do you need both vlan_start and allowed_start?\nWhat is the relationship between network_size and allowed range? Do you really need both?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"874f43302280da25aa08fc89bb82659dbfd5710b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $vlan_start    \u003d undef,"},{"line_number":34,"context_line":"  $project       \u003d undef,"},{"line_number":35,"context_line":"  $allowed_start \u003d undef,"},{"line_number":36,"context_line":"  $allowed_end   \u003d undef,"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  File[\u0027/etc/nova/nova.conf\u0027] -\u003e Nova_network[$name]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a890539_45b1d78d","line":36,"in_reply_to":"5a890539_8896824a","updated":"2014-12-04 07:23:01.000000000","message":"no this needs, some cleanup, thanks for the observation","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"9a486129459b2725ca0dfa4a525738a35161bfe9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $vlan_start    \u003d undef,"},{"line_number":34,"context_line":"  $project       \u003d undef,"},{"line_number":35,"context_line":"  $allowed_start \u003d undef,"},{"line_number":36,"context_line":"  $allowed_end   \u003d undef,"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  File[\u0027/etc/nova/nova.conf\u0027] -\u003e Nova_network[$name]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a961159_38dce2e0","line":36,"in_reply_to":"5a890539_8896824a","updated":"2015-01-17 01:06:35.000000000","message":"wich is the proper way to handle parameter deprecation?","commit_id":"7dab1af217d2c48ab334fd7b828d9625846e940f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*allowed_start]"},{"line_number":19,"context_line":"#   (optional) Start of allowed addresses for instances"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*allowed_end]"},{"line_number":22,"context_line":"#   (optional) End of allowed addresses for instances"},{"line_number":23,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_f5fdba09","line":20,"updated":"2015-03-17 14:22:26.000000000","message":"add defaults for both start and end","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $vlan_start    \u003d undef,"},{"line_number":34,"context_line":"  $project       \u003d undef,"},{"line_number":35,"context_line":"  $allowed_start \u003d undef,"},{"line_number":36,"context_line":"  $allowed_end   \u003d undef,"},{"line_number":37,"context_line":") {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  File[\u0027/etc/nova/nova.conf\u0027] -\u003e Nova_network[$name]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_950e3e31","line":36,"updated":"2015-03-17 14:22:26.000000000","message":"drop \",\"","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    project       \u003d\u003e $project,"},{"line_number":49,"context_line":"    vlan_start    \u003d\u003e $vlan_start,"},{"line_number":50,"context_line":"    allowed_start \u003d\u003e $allowed_start,"},{"line_number":51,"context_line":"    allowed_end   \u003d\u003e $allowed_end,"},{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_152a4e7e","line":51,"updated":"2015-03-17 14:22:26.000000000","message":"drop last comma.","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"}],"manifests/network.pp":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# [*allowed_start]"},{"line_number":59,"context_line":"#   (optional) Start of allowed addresses for instances"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*allowed_end]"},{"line_number":62,"context_line":"#   (optional) End of allowed addresses for instances"},{"line_number":63,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_f54bfa5c","line":60,"updated":"2015-03-17 14:22:26.000000000","message":"add defaults for start and end","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $ensure_package    \u003d \u0027present\u0027,"},{"line_number":76,"context_line":"  $install_service   \u003d true,"},{"line_number":77,"context_line":"  $allowed_start     \u003d undef,"},{"line_number":78,"context_line":"  $allowed_end       \u003d undef,"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  include ::nova::params"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_35567207","line":78,"updated":"2015-03-17 14:22:26.000000000","message":"drop last comma","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      network_size  \u003d\u003e $network_size,"},{"line_number":117,"context_line":"      vlan_start    \u003d\u003e $vlan_start,"},{"line_number":118,"context_line":"      allowed_start \u003d\u003e $allowed_start,"},{"line_number":119,"context_line":"      allowed_end   \u003d\u003e $allowed_end,"},{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":"    if $floating_range {"},{"line_number":122,"context_line":"      nova::manage::floating { \u0027nova-vm-floating\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a80dd14_15788e8e","line":119,"updated":"2015-03-17 14:22:26.000000000","message":"drop last comma","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"}],"spec/defines/nova_manage_networks_spec.rb":[{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f7e3870bcb9691e79447d25e78060dfaa4d6b8fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      :num_networks  \u003d\u003e 1,"},{"line_number":28,"context_line":"      :project       \u003d\u003e nil,"},{"line_number":29,"context_line":"      :allowed_start \u003d\u003e nil,"},{"line_number":30,"context_line":"      :allowed_end   \u003d\u003e nil,"},{"line_number":31,"context_line":"    ) }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":"  describe \u0027when overriding num networks\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5a890539_4ffe1b07","line":30,"updated":"2014-11-19 03:16:39.000000000","message":"Can you please add also one more test where there are actually some values for allowed_(start|end) parameters?","commit_id":"975bc5dbdd2b8c0e41a66cfbda130ca0b03563c0"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      :num_networks  \u003d\u003e 1,"},{"line_number":28,"context_line":"      :project       \u003d\u003e nil,"},{"line_number":29,"context_line":"      :allowed_start \u003d\u003e nil,"},{"line_number":30,"context_line":"      :allowed_end   \u003d\u003e nil,"},{"line_number":31,"context_line":"    ) }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":"  describe \u0027when overriding num networks\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a80dd14_b560a2d0","line":30,"updated":"2015-03-17 14:22:26.000000000","message":"drop last comma","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"36766add1fe082820f8ed7bcbbb20a0f37010c75","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      :allowed_end   \u003d\u003e \u002710.0.0.5\u0027"},{"line_number":71,"context_line":"    ) }"},{"line_number":72,"context_line":"  end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a80dd14_956d5e9c","line":73,"updated":"2015-03-17 14:22:26.000000000","message":"add a test to ensure that start and end share first 3 octets.\nAlso add a test for start preceding or equal to end.","commit_id":"87d27a65fa96da544afda76f3f5714d53c967e5d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"a7ec9aceb4aad9ed8f24a2ed077027542735bd22","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        :network \u003d\u003e \u002710.0.0.0/24\u0027"},{"line_number":21,"context_line":"      }"},{"line_number":22,"context_line":"    end"},{"line_number":23,"context_line":"    it { should contain_nova_network(\u0027foo\u0027).with("},{"line_number":24,"context_line":"      :ensure        \u003d\u003e \u0027present\u0027,"},{"line_number":25,"context_line":"      :network       \u003d\u003e \u002710.0.0.0/24\u0027,"},{"line_number":26,"context_line":"      :label         \u003d\u003e \u0027novanetwork\u0027,"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"3a50d1a3_bc7b167b","line":23,"updated":"2015-07-19 16:26:23.000000000","message":"You accidently reverted this to rspec 2.x syntax.  This is causing deprecation warnings in the test runs.","commit_id":"0524ecf42ecfec7585225fe8fae35106a268f045"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b4283c2f9d21d618d4a84a787c30990e882ba8ef","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      :num_networks  \u003d\u003e 1,"},{"line_number":28,"context_line":"      :project       \u003d\u003e nil,"},{"line_number":29,"context_line":"      :allowed_start \u003d\u003e nil,"},{"line_number":30,"context_line":"      :allowed_end   \u003d\u003e nil,"},{"line_number":31,"context_line":"    ) }"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":"  describe \u0027when overriding num networks\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a50d1a3_c74b91af","line":30,"updated":"2015-07-20 15:04:35.000000000","message":"Would really appreciate if we have a common guideline for ending data structure and select statement. In some cases we have last element ends with \",\" and in some cases  it end on nothing.","commit_id":"9eaf5d74a5f78426798b174bbee8cd453d747ef3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b4283c2f9d21d618d4a84a787c30990e882ba8ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    let :params do"},{"line_number":61,"context_line":"      {"},{"line_number":62,"context_line":"        :network       \u003d\u003e \u002710.0.0.0/20\u0027,"},{"line_number":63,"context_line":"        :allowed_start \u003d\u003e \u002710.0.0.1\u0027,"},{"line_number":64,"context_line":"        :allowed_end   \u003d\u003e \u002710.0.0.5\u0027"},{"line_number":65,"context_line":"      }"},{"line_number":66,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a50d1a3_0a70a071","line":63,"updated":"2015-07-20 15:04:35.000000000","message":"Should we start that range to ...2.\n.1 usually taken by gateway.","commit_id":"9eaf5d74a5f78426798b174bbee8cd453d747ef3"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"b4283c2f9d21d618d4a84a787c30990e882ba8ef","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    end"},{"line_number":67,"context_line":"    it { is_expected.to contain_nova_network(\u0027foo\u0027).with("},{"line_number":68,"context_line":"      :network       \u003d\u003e \u002710.0.0.0/20\u0027,"},{"line_number":69,"context_line":"      :allowed_start \u003d\u003e \u002710.0.0.1\u0027,"},{"line_number":70,"context_line":"      :allowed_end   \u003d\u003e \u002710.0.0.5\u0027"},{"line_number":71,"context_line":"    ) }"},{"line_number":72,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3a50d1a3_eaf9b4c9","line":69,"updated":"2015-07-20 15:04:35.000000000","message":"ditto","commit_id":"9eaf5d74a5f78426798b174bbee8cd453d747ef3"}]}