)]}'
{"manifests/rabbitmq.pp":[{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"b74abbf8eb74a5b2a087a8ec3f72076bc456cae3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   (optional) The rabbitmq puppet class to depend on,"},{"line_number":34,"context_line":"#   which is dependent on the puppet-rabbitmq version."},{"line_number":35,"context_line":"#   Use the default for 1.x, use \u0027rabbitmq\u0027 for 3.x."},{"line_number":36,"context_line":"#   Use false, if rabbitmq class should not be configured"},{"line_number":37,"context_line":"#   here"},{"line_number":38,"context_line":"#   Defaults to \u0027rabbitmq::server\u0027"},{"line_number":39,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a961159_26c1e381","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":14},"updated":"2015-01-12 14:37:44.000000000","message":"Drop the comma before \"if\".","commit_id":"5ea0dd0d5ad556a603502af850de53ab473ab473"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"4ce53f2f77e9a98376d77c56436b6d3c78430828","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_user\u003c| title \u003d\u003d $userid |\u003e"},{"line_number":96,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_vhost\u003c| title \u003d\u003d $virtual_host |\u003e"},{"line_number":97,"context_line":"    # only configure nova after the queue is up"},{"line_number":98,"context_line":"    Class[$rabbitmq_class] -\u003e Anchor\u003c| title \u003d\u003d \u0027nova-start\u0027 |\u003e"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if ($enabled) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a961159_f6478278","line":98,"updated":"2015-01-12 17:19:16.000000000","message":"I think we should replace this with something like:\n\n    Rabbitmq_user\u003c| title \u003d\u003d $userid |\u003e -\u003e Anchor\u003c| title \u003d\u003d nova-start |\u003e\n    Rabbitmq_vhost\u003c| title \u003d\u003d $virtual_host |\u003e -\u003e Anchor\u003c| title \u003d\u003d nova-start |\u003e\n\nAnd it should be moved outside of the conditional","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b36b5076db50b672d0d81698aec2b2eb7cce6aa7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_user\u003c| title \u003d\u003d $userid |\u003e"},{"line_number":96,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_vhost\u003c| title \u003d\u003d $virtual_host |\u003e"},{"line_number":97,"context_line":"    # only configure nova after the queue is up"},{"line_number":98,"context_line":"    Class[$rabbitmq_class] -\u003e Anchor\u003c| title \u003d\u003d \u0027nova-start\u0027 |\u003e"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if ($enabled) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a961159_1d132a02","line":98,"in_reply_to":"3a961159_852266b8","updated":"2015-01-13 14:29:45.000000000","message":"It\u0027s hard to say :) I guess that is the question out of the patch scope.","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b7f496388aefa96d930896ad67165fc6d5b409e4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_user\u003c| title \u003d\u003d $userid |\u003e"},{"line_number":96,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_vhost\u003c| title \u003d\u003d $virtual_host |\u003e"},{"line_number":97,"context_line":"    # only configure nova after the queue is up"},{"line_number":98,"context_line":"    Class[$rabbitmq_class] -\u003e Anchor\u003c| title \u003d\u003d \u0027nova-start\u0027 |\u003e"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if ($enabled) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a961159_852266b8","line":98,"in_reply_to":"3a961159_c4271b62","updated":"2015-01-13 13:39:55.000000000","message":"I think see what you\u0027re saying. This functionality isn\u0027t already existing in the previous code?\n\nI think this is generically useful and probably shouldn\u0027t exist solely in the deprecation.  How is this not broken in the existing code?","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a250846ebda19b69da4b497a4a12f455967ea0ff","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_user\u003c| title \u003d\u003d $userid |\u003e"},{"line_number":96,"context_line":"    Class[$rabbitmq_class] -\u003e Rabbitmq_vhost\u003c| title \u003d\u003d $virtual_host |\u003e"},{"line_number":97,"context_line":"    # only configure nova after the queue is up"},{"line_number":98,"context_line":"    Class[$rabbitmq_class] -\u003e Anchor\u003c| title \u003d\u003d \u0027nova-start\u0027 |\u003e"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  if ($enabled) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a961159_c4271b62","line":98,"in_reply_to":"3a961159_f6478278","updated":"2015-01-13 08:18:54.000000000","message":"That is just a replacement of lines #49, #60, #95. I\u0027m not sure we should change dependencies in the deprecation patch, that would be out of the change scope","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"}],"spec/classes/nova_rabbitmq_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1e4a5eb9d6eb5f69fc26718c8f7c1565ffba1226","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  end"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  describe \u0027then no rabbitmq class specified\u0027 do"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    let :params do"},{"line_number":107,"context_line":"      {"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_a3f57e52","line":104,"updated":"2015-01-14 06:16:21.000000000","message":"This should be \"when\" instead of \"then\" (see the other \"when\" tests)","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"283867b3e76df4bf3c4561253f78e1153fbdae8a","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  end"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  describe \u0027then no rabbitmq class specified\u0027 do"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    let :params do"},{"line_number":107,"context_line":"      {"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_c1835f53","line":104,"in_reply_to":"3a961159_a3f57e52","updated":"2015-01-14 09:25:39.000000000","message":"Thanks! (I know the difference, I swear :-) )","commit_id":"1a84098a2acb460d00a966dff3c2e0d3ad3353fb"}]}