)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"c8e1d2909b532db60aea70666495dcf94285c6e5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":146,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":147,"context_line":"    } else {"},{"line_number":148,"context_line":"      class { \u0027::nova::migration::libvirt\u0027:"},{"line_number":149,"context_line":"        use_tls \u003d\u003e $migration_use_tls,"},{"line_number":150,"context_line":"        auth    \u003d\u003e $migration_auth,"},{"line_number":151,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aa53dc9_b84ab2c3","line":148,"updated":"2015-04-08 23:32:42.000000000","message":"I think we should use include instead of class and ask the user to define the class before nova::compute::libvirt with needed parameters or use Hiera.\n\nParameterized classes within class are evil as you will have to add more and more parameters to nova::compute::libvirt, only be passed to nova::migration::libvirt.","commit_id":"0ead9a92308b19c427ee1d1d56d374efd88693ec"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ba8f322bc3523c68ca3f3692e4cf03aebb3b3674","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa32b979_67e69de9","line":138,"updated":"2015-06-18 08:16:28.000000000","message":"This makes the class parameters pointless. Shouldn\u0027t be here the class call with the use_tls and auth parameters passed from the main class instead?","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4c17c36e817fe557063736ca4062a78e56b3590","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_e5f61a8e","line":138,"in_reply_to":"3a50d1a3_d65df647","updated":"2015-07-23 07:51:50.000000000","message":"Okay than, sounds reasonable","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6611b1c8332888972e0c26bfc39017382578ad28","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_d65df647","line":138,"in_reply_to":"fa32b979_0659818e","updated":"2015-07-22 17:17:22.000000000","message":"I\u0027m fine with this change. If a user wants to take advantage of the new parameters but does not use hiera, this allows them to declare the class in a profile with the parameters set. Adding more parameters to this class just causes a lot of duplicate code being passed through many levels of classes.","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"63c5bde3b0e9fc22451de965f8f7316652959d6f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa32b979_c5a441bb","line":138,"in_reply_to":"fa32b979_67e69de9","updated":"2015-06-18 09:00:52.000000000","message":"this way the parameters can be passed in via hiera, otherwise you have to hardcode the value or have to add parameters and then forward them which leads to dependency hell.\nI actually changed it to an include after a discussion spawned by mgagnes comment on version 1 of this patch.","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"d915785608621c46304e7d5b09bef85d1d3ffa57","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa32b979_0659818e","line":138,"in_reply_to":"fa32b979_a55c9d7d","updated":"2015-06-19 18:51:50.000000000","message":"Puppet will automatically look up parameters in Hiera. https://docs.puppetlabs.com/hiera/1/puppet.html#automatic-parameter-lookup","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d849571c9d25f2bd3ebfe1a0c4e297e06d3ac2e9","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if $vncserver_listen !\u003d \u00270.0.0.0\u0027 and $vncserver_listen !\u003d \u0027::0\u0027 {"},{"line_number":136,"context_line":"      fail(\u0027For migration support to work, you MUST set vncserver_listen to \\\u00270.0.0.0\\\u0027 or \\\u0027::0\\\u0027\u0027)"},{"line_number":137,"context_line":"    } else {"},{"line_number":138,"context_line":"      include ::nova::migration::libvirt"},{"line_number":139,"context_line":"    }"},{"line_number":140,"context_line":"  }"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa32b979_a55c9d7d","line":138,"in_reply_to":"fa32b979_c5a441bb","updated":"2015-06-18 09:08:36.000000000","message":"I\u0027m only raised this because normally and historically class parameters are being passed from calling classes. Did I miss changes which allow to include parametrized classes and imply the hiera  side configuration? I\u0027m sorry being not aware, if so.","commit_id":"1383cee7d46c5c6b6c83bed194822c846b10782d"}],"manifests/migration/libvirt.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"fd3a64fbc194c532a12ff536f45ca6829660885c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*auth*]"},{"line_number":12,"context_line":"#   (optional) Use this authentication scheme for remote libvirt connections."},{"line_number":13,"context_line":"#   Valid options are none and sasl."},{"line_number":14,"context_line":"#   Defaults to \u0027none\u0027"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"class nova::migration::libvirt("},{"line_number":17,"context_line":"  $use_tls \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_566883f5","line":14,"updated":"2015-04-12 22:34:13.000000000","message":"Is auth \u003d\u003e sasl ever valid with use_tls \u003d\u003e false and vice versa? Would it make more sense just to always use sasl if use_tls is true, and use none if not?","commit_id":"21588d3f417436ca4023b50288af9ab0f28a7fe0"},{"author":{"_account_id":11479,"name":"David Gurtner","email":"aldavud@crimson.ch","username":"aldavud"},"change_message_id":"7fd0c07cef69589628ccc30bf87acb44352e02e3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# [*auth*]"},{"line_number":12,"context_line":"#   (optional) Use this authentication scheme for remote libvirt connections."},{"line_number":13,"context_line":"#   Valid options are none and sasl."},{"line_number":14,"context_line":"#   Defaults to \u0027none\u0027"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"class nova::migration::libvirt("},{"line_number":17,"context_line":"  $use_tls \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aaa499b_09253caa","line":14,"in_reply_to":"7aaa499b_566883f5","updated":"2015-04-12 23:07:49.000000000","message":"All possible combinations are valid and useful.","commit_id":"21588d3f417436ca4023b50288af9ab0f28a7fe0"}]}