)]}'
{"manifests/network.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2f22d954370290d3f9e4789c438035c8caec70b2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*enabled*]"},{"line_number":38,"context_line":"#   (optional) Whether the network service should be enabled."},{"line_number":39,"context_line":"#   Defaults to true"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*network_manager*]"},{"line_number":42,"context_line":"#   (optional) The type of network manager to use."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa32b979_122743b7","line":39,"updated":"2015-06-16 07:48:58.000000000","message":"Nove network should be disabled by default, IMHO. Neutron looks like a default option since IceHouse?..\nAnd we may assume users who include Nova will include Neutron as well. Is it correct?","commit_id":"59196bf285175ebd619e5f09361d6778c3ea3c6b"}],"manifests/objectstore.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2f22d954370290d3f9e4789c438035c8caec70b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*enabled*]"},{"line_number":8,"context_line":"#   (optional) Whether to enable the service"},{"line_number":9,"context_line":"#   Defaults to true"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (optional) Whether to start/stop the service"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa32b979_f2a89fdd","line":9,"updated":"2015-06-16 07:48:58.000000000","message":"Ditto to Swift as a default choice instead of Nova-object storage. I believe this should be default to False.","commit_id":"59196bf285175ebd619e5f09361d6778c3ea3c6b"}],"manifests/spicehtml5proxy.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2f22d954370290d3f9e4789c438035c8caec70b2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#   (optional) enable spicehtml5proxy service"},{"line_number":13,"context_line":"#   Defaults to true"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*manage_service*]"},{"line_number":16,"context_line":"#   (optional) Whether to start/stop the service"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa32b979_b2c0d77d","line":13,"updated":"2015-06-16 07:48:58.000000000","message":"This service\u0027s default should be mutually exclusive to vnc. They both cannot be enabled by default, please see http://docs.openstack.org/admin-guide-cloud/content/spice-console.html : VNC must be explicitly disabled to get access to the SPICE console","commit_id":"59196bf285175ebd619e5f09361d6778c3ea3c6b"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"7855afdb59794184865c90b5006c5311e46f6c8b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#   (optional) enable spicehtml5proxy service"},{"line_number":13,"context_line":"#   Defaults to true"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*manage_service*]"},{"line_number":16,"context_line":"#   (optional) Whether to start/stop the service"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba3cc151_4f9e07ba","line":13,"updated":"2015-07-02 19:18:34.000000000","message":"We dont use SPICE and so I\u0027m curious if this really should default to enabled. Unlike many of the other services here this one seems more optional to me. Thoughts?","commit_id":"84fcb3ed56c12a1cdc44513aeeaf0642c9935600"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"1cd36638d609c9f78d57d981d7074b8aba145771","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#   (optional) enable spicehtml5proxy service"},{"line_number":13,"context_line":"#   Defaults to true"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*manage_service*]"},{"line_number":16,"context_line":"#   (optional) Whether to start/stop the service"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba3cc151_0cfb0648","line":13,"in_reply_to":"ba3cc151_4f9e07ba","updated":"2015-07-03 15:11:05.000000000","message":"If you don\u0027t use spice, you just won\u0027t use this class in your composition layer ... or am I missing something?","commit_id":"84fcb3ed56c12a1cdc44513aeeaf0642c9935600"}],"manifests/vncproxy.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2f22d954370290d3f9e4789c438035c8caec70b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*enabled*]"},{"line_number":8,"context_line":"#   (optional) Whether to run the vncproxy service"},{"line_number":9,"context_line":"#   Defaults to true"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*manage_service*]"},{"line_number":12,"context_line":"#   (optional) Whether to start/stop the service"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa32b979_1238a39f","line":9,"updated":"2015-06-16 07:48:58.000000000","message":"see my comment about the spice console","commit_id":"59196bf285175ebd619e5f09361d6778c3ea3c6b"}],"spec/acceptance/basic_nova_spec.rb":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"7855afdb59794184865c90b5006c5311e46f6c8b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"      class { \u0027::nova::cert\u0027: enabled \u003d\u003e true }"},{"line_number":111,"context_line":"      class { \u0027::nova::client\u0027: }"},{"line_number":112,"context_line":"      class { \u0027::nova::conductor\u0027: }"},{"line_number":113,"context_line":"      class { \u0027::nova::consoleauth\u0027: enabled \u003d\u003e true }"},{"line_number":114,"context_line":"      class { \u0027::nova::cron::archive_deleted_rows\u0027: }"},{"line_number":115,"context_line":"      class { \u0027::nova::compute\u0027: vnc_enabled \u003d\u003e true }"},{"line_number":116,"context_line":"      class { \u0027::nova::compute::libvirt\u0027:"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"ba3cc151_2f7e236a","line":113,"updated":"2015-07-02 19:18:34.000000000","message":"this enabled isnt needed","commit_id":"84fcb3ed56c12a1cdc44513aeeaf0642c9935600"}]}