)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6dda3d3abd21d5109b7f0c355ebb602f9d3b0942","unresolved":false,"context_lines":[{"line_number":16,"context_line":"These may be somewhat obscure settings, but I believe in the"},{"line_number":17,"context_line":"philosophy of providing as many config parameters as possible"},{"line_number":18,"context_line":"directly in the classes.  This allows end users to easily take"},{"line_number":19,"context_line":"advantage of automatic data binding with hiera, etc.  Addding"},{"line_number":20,"context_line":"these in yourself with nova::config or nova_config resources"},{"line_number":21,"context_line":"is slightly more effort."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_d737b0ae","line":19,"updated":"2015-06-30 00:56:37.000000000","message":"Not a -1 but if you make another patchset, typo here (Addding)","commit_id":"aee4da8ee3ec9cdcc6d2ae9c99a6b25621f1d2cb"}],"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"656837e582e50709f1bf441c5db6f20f40358d90","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  $validate                               \u003d false,"},{"line_number":191,"context_line":"  $validation_options                     \u003d {},"},{"line_number":192,"context_line":"  $osapi_max_limit                        \u003d 1000,"},{"line_number":193,"context_line":"  $osapi_compute_unique_server_name_scope \u003d \u0027\u0027,"},{"line_number":194,"context_line":"  $multi_instance_display_name_template   \u003d \u0027%(name)s-%(count)d\u0027,"},{"line_number":195,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":196,"context_line":"  $auth_protocol                          \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_37604735","line":193,"updated":"2015-06-22 13:37:03.000000000","message":"I don\u0027t like \u0027\u0027, I would rather use undef and make sure the value is only set if the param is set (and make sure the param is absent).","commit_id":"2bf32a0e09cadc192b01d73fe859ea9fa9ed4eb7"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"6be733200c83651259ebed7f3f6877d04f2c9c31","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  $validate                               \u003d false,"},{"line_number":191,"context_line":"  $validation_options                     \u003d {},"},{"line_number":192,"context_line":"  $osapi_max_limit                        \u003d 1000,"},{"line_number":193,"context_line":"  $osapi_compute_unique_server_name_scope \u003d \u0027\u0027,"},{"line_number":194,"context_line":"  $multi_instance_display_name_template   \u003d \u0027%(name)s-%(count)d\u0027,"},{"line_number":195,"context_line":"  # DEPRECATED PARAMETER"},{"line_number":196,"context_line":"  $auth_protocol                          \u003d \u0027http\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa32b979_4e676db7","line":193,"in_reply_to":"fa32b979_37604735","updated":"2015-06-22 15:34:14.000000000","message":"Not opposed to that for this one parameter.  I\u0027ll change it.","commit_id":"2bf32a0e09cadc192b01d73fe859ea9fa9ed4eb7"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6dda3d3abd21d5109b7f0c355ebb602f9d3b0942","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    nova_config {"},{"line_number":255,"context_line":"      \u0027DEFAULT/osapi_compute_unique_server_name_scope\u0027: ensure \u003d\u003e absent;"},{"line_number":256,"context_line":"    }"},{"line_number":257,"context_line":"  }"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  if ($neutron_metadata_proxy_shared_secret){"},{"line_number":260,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_77c26487","line":257,"updated":"2015-06-30 00:56:37.000000000","message":"If we\u0027re adding this paradigm for this one parameter why not for the others?","commit_id":"aee4da8ee3ec9cdcc6d2ae9c99a6b25621f1d2cb"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"b27f8163b1e5c5544cfaf75f69519eea598f906b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    nova_config {"},{"line_number":255,"context_line":"      \u0027DEFAULT/osapi_compute_unique_server_name_scope\u0027: ensure \u003d\u003e absent;"},{"line_number":256,"context_line":"    }"},{"line_number":257,"context_line":"  }"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  if ($neutron_metadata_proxy_shared_secret){"},{"line_number":260,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_f43af297","line":257,"in_reply_to":"ba3cc151_77c26487","updated":"2015-07-10 20:40:29.000000000","message":"I think the intention is to eventually retool the _config providers such that value \u003d\u003e undef will mimic the ensure \u003d\u003e absent behavior.  So assuming that will change in the future, I didn\u0027t see a reason to convert all the other nova_config items here.\n\nIn patchset 2 I had followed the same model as all the other nova_config parameters here, but there were comments suggesting we do it this way instead.\n\nPersonally, I don\u0027t care either way.  But the patchest 2 style might be better just so it\u0027s consistent with what\u0027s already here.","commit_id":"aee4da8ee3ec9cdcc6d2ae9c99a6b25621f1d2cb"}]}