)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"06e501714e1a5bad36ac2f8027309121392a2f16","unresolved":false,"context_lines":[{"line_number":4,"context_line":"class nova::db::sync inherits nova::params {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  Package\u003c| title \u003d\u003d $::nova::params::api_package_name |\u003e    -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":7,"context_line":"  Package\u003c| title \u003d\u003d $::nova::params::common_package_name |\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":8,"context_line":"  Nova_config \u003c||\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":9,"context_line":"  Nova_config \u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":10,"context_line":"  Exec\u003c| title \u003d\u003d \u0027post-nova-config\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba3cc151_ffcadf4e","line":7,"updated":"2015-06-29 17:00:13.000000000","message":"I would like to see dependencies on the other nova service packages here, too.  So if you don\u0027t run nova-api (like in a compute cell, for example), you still get the db sync triggered.","commit_id":"0d1c058eb3a5a1859580b90fd722dbe4b35077a1"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"5a84c500a7b76973618a6914228f0fdf301c5688","unresolved":false,"context_lines":[{"line_number":4,"context_line":"class nova::db::sync inherits nova::params {"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  Package\u003c| title \u003d\u003d $::nova::params::api_package_name |\u003e    -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":7,"context_line":"  Package\u003c| title \u003d\u003d $::nova::params::common_package_name |\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":8,"context_line":"  Nova_config \u003c||\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":9,"context_line":"  Nova_config \u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":10,"context_line":"  Exec\u003c| title \u003d\u003d \u0027post-nova-config\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba3cc151_976a33ed","line":7,"in_reply_to":"ba3cc151_ffcadf4e","updated":"2015-07-01 13:27:28.000000000","message":"After thinking about this more and talking to Clayton, I think we should go forward with this patch as-is.  Then in the future, look at converting this stuff to using a tags mechanism, like in https://review.openstack.org/#/c/197172 , so that other stuff can more easily hook into the package installs, db syncs, etc.","commit_id":"0d1c058eb3a5a1859580b90fd722dbe4b35077a1"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"7df925d20ae3a2880f35c0dd93a7f6eae3b75df7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  Package\u003c| title \u003d\u003d $::nova::params::common_package_name |\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":8,"context_line":"  Nova_config \u003c||\u003e -\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":9,"context_line":"  Nova_config \u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":10,"context_line":"  Exec\u003c| title \u003d\u003d \u0027post-nova-config\u0027 |\u003e ~\u003e Exec[\u0027nova-db-sync\u0027]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  exec { \u0027nova-db-sync\u0027:"},{"line_number":13,"context_line":"    command     \u003d\u003e \u0027/usr/bin/nova-manage db sync\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba3cc151_559a1163","line":10,"updated":"2015-07-09 11:52:07.000000000","message":"it should be Exec[\u0027post-nova_config\u0027]","commit_id":"0d1c058eb3a5a1859580b90fd722dbe4b35077a1"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"ec63e0a4f6ac9ced4f4ba602153dcbe178710e5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Class to execute nova dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"class nova::db::sync {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a41bdd9_505588f7","line":1,"updated":"2015-07-14 19:54:22.000000000","message":"Package upgrades need to notify the exec so that migrations run.","commit_id":"52052023c74ccaa97fa25112b39c00110d2a1756"}]}