)]}'
{"manifests/scheduler/filter.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"6b1047a89562bde04e600bd405673d3a0c5e6167","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d \u0027nova.scheduler.filters.all_filters\u0027,"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"},{"line_number":82,"context_line":"  $scheduler_use_baremetal_filters     \u003d false,"},{"line_number":83,"context_line":") {"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_295c9824","line":81,"updated":"2015-07-20 10:20:26.000000000","message":"IMO the upstream default should be provided here as it is on all the paramters.\n\nList of default value : https://github.com/openstack/nova/blob/4cf6ef68199183697a0209751575f88fe5b2a733/nova/scheduler/ironic_host_manager.py#L34-L42","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c7f5018680ee6aa0ad390c805d9ef8b2465b3ad2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d \u0027nova.scheduler.filters.all_filters\u0027,"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"},{"line_number":82,"context_line":"  $scheduler_use_baremetal_filters     \u003d false,"},{"line_number":83,"context_line":") {"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_cc608938","line":81,"in_reply_to":"3a50d1a3_1ab0f142","updated":"2015-07-20 18:18:54.000000000","message":"Sounds reasonable, I\u0027me fine with that. @Yanis?","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"730c435b2f87a6f7c88c8cfd781917247cd3c0c5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d \u0027nova.scheduler.filters.all_filters\u0027,"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"},{"line_number":82,"context_line":"  $scheduler_use_baremetal_filters     \u003d false,"},{"line_number":83,"context_line":") {"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_1ab0f142","line":81,"in_reply_to":"3a50d1a3_295c9824","updated":"2015-07-20 13:47:12.000000000","message":"This change is the version that was agreed upon in irc (http://irclog.perlgeek.de/puppet-openstack/2015-07-15#i_10901855). We should not be prescribing the defaults via puppet as they may change over time in code and this would lead to having to manage them in two places. The best way to do this is to leave it undefined so we are not setting anything via configuration management and allow an operator to manage it only if they are choosing to change the configuration from the defaults.","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c914b9b274b6e83525ab0550aab76f22ce31e9e5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d \u0027nova.scheduler.filters.all_filters\u0027,"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"},{"line_number":82,"context_line":"  $scheduler_use_baremetal_filters     \u003d false,"},{"line_number":83,"context_line":") {"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_b2868411","line":81,"in_reply_to":"3a50d1a3_c97fff64","updated":"2015-07-21 13:38:08.000000000","message":"I think the better way is to document the defaults in the parameter documentation because by trying to manage the current defaults in all the files will ultimately be unmaintainable. I know we\u0027ve run into a few instances where the defaults were there for 2 years but have been updated in the python project several times but missed in puppet because no one uses the class or just overrides the parameter without fixing the default.  The code seems to have a default if not specified so by not providing it, it should fall back to the current python defaults. Unless there is an instance where this does not occur, i think it\u0027s best to leave undef unless absolutely necessary.  But I totally understand your concern and thank you for pointing out what the current pattern is.","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"2beeb653c6a9be910c31764e0967e325051d0cb9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d \u0027nova.scheduler.filters.all_filters\u0027,"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"},{"line_number":82,"context_line":"  $scheduler_use_baremetal_filters     \u003d false,"},{"line_number":83,"context_line":") {"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_c97fff64","line":81,"in_reply_to":"3a50d1a3_cc608938","updated":"2015-07-21 07:22:10.000000000","message":"I understand the undef and do prefer this pattern. This is why there is an on going effort to try to figure out a global pattern for parameter default.\n\nMy concern here is more about simply breaking the current pattern in this same file, every single parameter in this file default to the *current* upstream default value. Now I agree undef will let a user default to upstream automatically but introduce a new pattern within the same file.\n\nI\u0027ll remove my -1 as I don\u0027t want to block this as code itself looks good.  Just want to note that it isn\u0027t consistent with current pattern.","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1bb2f8bbf99d80d0307ff9520e09d70a67cd6296","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":"  if ($baremetal_scheduler_default_filters)  {"},{"line_number":106,"context_line":"    nova_config { \u0027DEFAULT/baremetal_scheduler_default_filters\u0027: value \u003d\u003e join($baremetal_scheduler_default_filters,\u0027,\u0027)"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"  } else {"},{"line_number":109,"context_line":"    nova_config { \u0027DEFAULT/baremetal_scheduler_default_filters\u0027: ensure \u003d\u003e absent"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a4dcd0f_1d91b8f0","line":106,"updated":"2015-08-04 12:34:39.000000000","message":"I wonder if we should sanitize by validate_array function before.\nBut since it\u0027s not the case for previous filters, I won\u0027t -1. Though a separate pat would be useful.","commit_id":"6e508ef56c81e6bc03e3198fb7894c33a70ca83c"}]}