)]}'
{"manifests/compute/rbd.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ff4ba7be9a0ceff77f4d0ed1293d08d944100314","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    # if there\u0027s no value change, leave it untouched."},{"line_number":88,"context_line":"    exec { \u0027undefine-if-value-not-match virsh secret\u0027:"},{"line_number":89,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":90,"context_line":"      onlyif  \u003d\u003e \"/usr/bin/virsh secret-dumpxml --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null | /bin/sed -n \\\"/\u003c\\\\/name\u003e/s/ *\u003cname\u003e\\\\(.*\\\\) secret\u003c\\\\/name\u003e/\\\\1/p\\\" | grep -q -v -w \\\"${rbd_keyring}\\\"\","},{"line_number":91,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":92,"context_line":"    } -\u003e"},{"line_number":93,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_6aaaf572","line":90,"updated":"2015-09-24 01:40:11.000000000","message":"Is the sed necessary? Wouldn\u0027t greping the entire xml output give a definitive answer?\n\nslight nit - this could be cleaned up a bit by adding path \u003d\u003e \"/usr/bin\"","commit_id":"57403b73529240540130268ad966ad3fc0778674"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"b30a2b733e14fc6064f18fef17ae6487dc7d34ea","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    # if there\u0027s no value change, leave it untouched."},{"line_number":88,"context_line":"    exec { \u0027undefine-if-value-not-match virsh secret\u0027:"},{"line_number":89,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":90,"context_line":"      onlyif  \u003d\u003e \"/usr/bin/virsh secret-dumpxml --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null | /bin/sed -n \\\"/\u003c\\\\/name\u003e/s/ *\u003cname\u003e\\\\(.*\\\\) secret\u003c\\\\/name\u003e/\\\\1/p\\\" | grep -q -v -w \\\"${rbd_keyring}\\\"\","},{"line_number":91,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":92,"context_line":"    } -\u003e"},{"line_number":93,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_10004665","line":90,"in_reply_to":"ba15a1d1_6aaaf572","updated":"2015-09-24 03:23:00.000000000","message":"not necessary for this case,\ncould we guarantee there\u0027s exactly \"secret-dumpxml\" return exactly one \u003cname\u003eXXX\u003c/name\u003e ?\n\nin this case,\nsed is just for ensuring we\u0027re greping on the line with specific pattern.\n\nand yes, it could be cleaned up by adding path \u003d\u003e [ \"/bin\", \"/usr/bin\" ]","commit_id":"57403b73529240540130268ad966ad3fc0778674"}]}